Skip to content

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Dec 9, 2022

What this PR does / why we need it:
Related to changes outlined in https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke

Which issue(s) this PR fixes:

More task details in Asana.

Special notes for your reviewer:

@Walther Walther requested a review from stefreak December 12, 2022 16:58
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images/circleci-runner needs a version bump (see comment) and for the other images I'm not 100% sure if there are additional, similar TODOs

@vvagaytsev
Copy link
Contributor

I've made some extra changes:

  • bumped circleci-runner image version in ad0302f, built and pushed the new image to the Docker hub
  • Updated the CircleCI config to use the new image in c0995d2
  • Updated GCloud SDK version in the CircleCI config in ae0da5b

A similar GCloud SDK version update was done in #3013 and in its patch PR #3037.

@vvagaytsev vvagaytsev requested a review from stefreak December 15, 2022 09:42
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vvagaytsev vvagaytsev merged commit b25606c into main Dec 15, 2022
@vvagaytsev vvagaytsev deleted the 2022-12-09-gcloud branch December 15, 2022 10:21
stefreak added a commit that referenced this pull request Jan 17, 2023
* chore(ci): fix windows tests

* chore(ci): set CLOUDSDK_PYTHON env variable

The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431

Additionally, we apply the workaround described in https://stackoverflow.com/questions/57024587/why-the-gcloud-components-update-command-always-show-restarting-command/75137898#75137898 which sets an environment variable that makes gcloud install command work without additional terminal windows.

See also https://stackoverflow.com/a/75137898/1518423

Co-authored-by: Steffen Neubauer <steffen@garden.io>
vvagaytsev pushed a commit that referenced this pull request Jan 24, 2023
* chore(ci): fix windows tests

* chore(ci): set CLOUDSDK_PYTHON env variable

The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431

Additionally, we apply the workaround described in https://stackoverflow.com/questions/57024587/why-the-gcloud-components-update-command-always-show-restarting-command/75137898#75137898 which sets an environment variable that makes gcloud install command work without additional terminal windows.

See also https://stackoverflow.com/a/75137898/1518423

Co-authored-by: Steffen Neubauer <steffen@garden.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants