-
Notifications
You must be signed in to change notification settings - Fork 288
chore: upgrade gcloud cli and install gke auth plugin #3431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
images/circleci-runner
needs a version bump (see comment) and for the other images I'm not 100% sure if there are additional, similar TODOs
I've made some extra changes:
A similar GCloud SDK version update was done in #3013 and in its patch PR #3037. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* chore(ci): fix windows tests * chore(ci): set CLOUDSDK_PYTHON env variable The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431 Additionally, we apply the workaround described in https://stackoverflow.com/questions/57024587/why-the-gcloud-components-update-command-always-show-restarting-command/75137898#75137898 which sets an environment variable that makes gcloud install command work without additional terminal windows. See also https://stackoverflow.com/a/75137898/1518423 Co-authored-by: Steffen Neubauer <steffen@garden.io>
* chore(ci): fix windows tests * chore(ci): set CLOUDSDK_PYTHON env variable The google cloud auth changes https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke require a new plugin to be installed, and forgot to add it to our windows runners during #3431 Additionally, we apply the workaround described in https://stackoverflow.com/questions/57024587/why-the-gcloud-components-update-command-always-show-restarting-command/75137898#75137898 which sets an environment variable that makes gcloud install command work without additional terminal windows. See also https://stackoverflow.com/a/75137898/1518423 Co-authored-by: Steffen Neubauer <steffen@garden.io>
What this PR does / why we need it:
Related to changes outlined in https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke
Which issue(s) this PR fixes:
More task details in Asana.
Special notes for your reviewer: