ci(edge-release): update existing instead of re-create #3492
Conversation
images/circleci-release/garden.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| kind: Module | |||
| type: container | |||
| name: circleci-release | |||
There was a problem hiding this comment.
Might I suggest just using the circleci-runner for this? Seems like unnecessary overhead to add a whole new image. Also curious why we can't use an upstream image to begin with?
There was a problem hiding this comment.
Why a custom image is necessary: If we update the existing release, we need another utility called gh that is not included together with ghr in any upstream container I looked at.
I can change this to circleci-runner if you prefer
There was a problem hiding this comment.
Aha I see, makes sense. But yeah, I think just the one CircleCI image makes most sense.
There was a problem hiding this comment.
@edvald OK, changed it now. But to be able to upload the image I need permission on dockerhub
There was a problem hiding this comment.
@edvald CI ran with the new image now, feel free to approve and then I'd just merge this and we could look at whether this actually works
To avoid spamming our fellow coder's GitHub timeline, update the existing edge release with new binaries and a new SHA target instead of creating a new edge release every time.
cc37a98 to
2209b35
Compare
|
Can't say if it's related, but the |
|
@edvald we'll solve this in another PR and it is unrelated. Are you ok if we still merge this PR to get it off my todo list, and fix the test in another PR? |
|
Yep all good! PR looks solid, just wanted to check for awareness on that.
Sent via Superhuman iOS ( ***@***.*** )
…On Mon, Jan 16 2023 at 6:02 PM, Steffen Neubauer < ***@***.*** > wrote:
@edvald ( https://github.com/edvald ) we'll solve this in another PR and it
is unrelated. Are you ok if we still merge this PR to get it off my todo
list, and fix the test in another PR?
—
Reply to this email directly, view it on GitHub (
#3492 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AABGAJH4X2PX2OYM5H7WJFLWSV5J3ANCNFSM6AAAAAATQ4UXWM
).
You are receiving this because you were mentioned. Message ID: <garden-io/garden/pull/3492/c1384330307
@ github. com>
|
* ci(edge-release): update existing instead of re-create To avoid spamming our fellow coder's GitHub timeline, update the existing edge release with new binaries and a new SHA target instead of creating a new edge release every time. * chore: move ghr and gh to circleci-runner image
What this PR does / why we need it:
To avoid spamming our fellow coders GitHub timelines, update the
existing edge release with new binaries and a new SHA target instead
of creating a new edge release every time.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: