Skip to content

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Nov 6, 2021

Restores the AppModel feature landed in #93161 as "SharedAppData". The original name collided with existing public API. The new name is clunkier, but doesn't appear to collide with an existing name.

Other than the AppModel to SharedAppData name change, this is the same PR as
#93161

Fixes #93275

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 6, 2021
@google-cla google-cla bot added the cla: yes label Nov 6, 2021
@HansMuller HansMuller requested a review from goderbauer November 6, 2021 00:59
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/93175

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #93175 at sha a9013939f03dacf947d221fb8b2bb1a0f7ea5f4f

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 7, 2021
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit f4f23ec into flutter:master Nov 8, 2021
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 8, 2021
@HansMuller HansMuller deleted the shared_app_data branch November 8, 2021 20:37
godofredoc added a commit that referenced this pull request Nov 12, 2021
…93448)

* Added SharedAppData to the widgets library (#93175)

* 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml'

* 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre'

* Pin to specific plugin version in multidex test (#93148)

Co-authored-by: Hans Muller <hans.muller@gmail.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
ryanawhelan pushed a commit to ryanawhelan/flutter that referenced this pull request Jan 13, 2022
…lutter#93448)

* Added SharedAppData to the widgets library (flutter#93175)

* 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml'

* 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre'

* Pin to specific plugin version in multidex test (flutter#93148)

Co-authored-by: Hans Muller <hans.muller@gmail.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for sharing WidgetApp scoped data without an umbrella widget
3 participants