-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Added SharedAppData to the widgets library #93175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
091ad22
to
e70e00d
Compare
Gold has detected about 1 new digest(s) on patchset 2. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #93175 at sha a9013939f03dacf947d221fb8b2bb1a0f7ea5f4f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart
Outdated
Show resolved
Hide resolved
examples/api/lib/widgets/shared_app_data/shared_app_data.1.dart
Outdated
Show resolved
Hide resolved
a901393
to
52db14b
Compare
…93448) * Added SharedAppData to the widgets library (#93175) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre' * Pin to specific plugin version in multidex test (#93148) Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Emmanuel Garcia <egarciad@google.com>
…lutter#93448) * Added SharedAppData to the widgets library (flutter#93175) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre' * Pin to specific plugin version in multidex test (flutter#93148) Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Restores the AppModel feature landed in #93161 as "SharedAppData". The original name collided with existing public API. The new name is clunkier, but doesn't appear to collide with an existing name.
Other than the AppModel to SharedAppData name change, this is the same PR as
#93161
Fixes #93275