Skip to content

Bump Android dependencies that rely on Jcenter #96558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 13, 2022
Merged

Bump Android dependencies that rely on Jcenter #96558

merged 8 commits into from
Jan 13, 2022

Conversation

blasten
Copy link

@blasten blasten commented Jan 12, 2022

Fixes #96550

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 12, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman
jmagman reviewed Jan 12, 2022
View reviewed changes
dev/integration_tests/flutter_gallery/pubspec.yaml
@@ -13,7 +13,7 @@ dependencies:
string_scanner: 1.1.0
url_launcher: 6.0.17
cupertino_icons: 1.0.4
video_player: 2.1.1
video_player: 2.2.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, this totally exists, and it works for me locally.

ERR : Because flutter_gallery depends on video_player 2.2.11 which doesn't match any versions, version solving failed.

Also, run flutter update-packages --force-upgrade, you'll see the autogenerated video_player_web line get bumped too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a comment that the latest version doesn't work in CI. Very weird:
https://github.com/flutter/flutter/pull/96558/files#diff-61e5e832b7178fde4befd707ba407f598be7966a1671db8dc1a607661f09cca2L38-R38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reasoning in #83367 or #82275. @zanderso do you remember?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blasten does 2.1.2 work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.2.11 worked after you ran update-packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why it was pinned.

@jmagman
Copy link
Member

jmagman commented Jan 12, 2022

device_info has a similar problem #96550 (comment)

@blasten blasten changed the title Bump video_player in flutter gallery Bump Android dependencies that rely on Jcenter Jan 12, 2022
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 12, 2022
jmagman
jmagman reviewed Jan 13, 2022
View reviewed changes
jmagman
jmagman reviewed Jan 13, 2022
View reviewed changes
jmagman
jmagman reviewed Jan 13, 2022
View reviewed changes
blasten and others added 3 commits January 12, 2022 17:01
@blasten @jmagman
Update dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
b75d866 
Co-authored-by: Jenn Magder <magder@google.com>
@blasten @jmagman
Update dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart
02249c1 
Co-authored-by: Jenn Magder <magder@google.com>
@blasten @jmagman
Update dev/devicelab/bin/tasks/module_test.dart
9bc9264 
Co-authored-by: Jenn Magder <magder@google.com>
@blasten blasten requested a review from jmagman January 13, 2022 01:12
jmagman
jmagman reviewed Jan 13, 2022
View reviewed changes
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart Outdated
@@ -66,7 +66,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
String content = pubspec.readAsStringSync();
content = content.replaceFirst(
'\ndependencies:\n',
'\ndependencies:\n device_info: 0.4.1\n package_info: 0.4.0+9\n connectivity: 3.0.3\n',
'\ndependencies:\n device_info: 2.0.3\n package_info: 2.0.2\n connectivity: 3.0.6\n',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr

  "reason": "FileSystemException: Expected file to exist., path = '/opt/s/w/ir/x/t/flutter_module_test.GlHziT/hello_module/flutter-frameworks/Debug/device_info.xcframework/ios-arm64_armv7/device_info.framework/Headers/DeviceInfoPlugin.h'"

Working on a fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it passed: https://ci.chromium.org/p/flutter/builders/try/Mac%20build_ios_framework_module_test/13177

jmagman
jmagman approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit f01556a into flutter:master Jan 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
f01556a Bump Android dependencies that rely on Jcenter (flutter/flutt…
2f80dec 
…er#96558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
f01556a Bump Android dependencies that rely on Jcenter (flutter/flutt…
f6bc712 
…er#96558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
f01556a Bump Android dependencies that rely on Jcenter (flutter/flutt…
841166c 
…er#96558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
f01556a Bump Android dependencies that rely on Jcenter (flutter/flutt…
e911513 
…er#96558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso left review comments

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine -> FW roller failing due to gradle resolution errors
3 participants
@blasten @jmagman @zanderso