Skip to content

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 11, 2021

Unblock the latest test version by revving mockito. Though this introduces more dev deps, we're close to eliminating it anyway.

Fixes #81516
Fixes #81834
Fixes #81294

@jonahwilliams jonahwilliams requested a review from Piinks as a code owner May 11, 2021 16:52
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 11, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams
Copy link
Contributor Author

@jakemac53

@google-cla google-cla bot added the cla: yes label May 11, 2021
@jonahwilliams jonahwilliams requested a review from zanderso May 11, 2021 16:52
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 11, 2021
@jonahwilliams
Copy link
Contributor Author

it looks like we cant update our version of test because we have customer tests that dont version solve. I'm not sure what to do here

@zanderso
Copy link
Member

it looks like we cant update our version of test because we have customer tests that dont version solve. I'm not sure what to do here

In general, we have to update the customer repos before landing changes that would break them. So, I guess in this case that would bean loosening the constraints in the customer pubspecs?

@jonahwilliams
Copy link
Contributor Author

It looks like https://github.com/PhilipsHue/flutter_reactive_ble/blob/master/pubspec.yaml is already up to date, but a new version needs to be rolled in. This can't be done atomically so I'll have to disable and then re-enable

@jonahwilliams
Copy link
Contributor Author

provider (https://github.com/rrousselGit/provider/blob/master/pubspec.yaml ) has also been updated and will require a similar disable then re-enable to roll in

@Hixie
Copy link
Contributor

Hixie commented May 11, 2021

test-exempt: dependency upgrade.

We really should make an automated bot to roll these.

@jonahwilliams
Copy link
Contributor Author

This one was definitely not gonna roll in automatically 😓

@Hixie
Copy link
Contributor

Hixie commented May 11, 2021

Yeah, but an automated roller would let us know as soon as that kind of problem came around, instead of us finding out at inconvenient times.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented May 25, 2021

Trying again in #83367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
3 participants