Skip to content

Add frontend_server_client to dependency allowlist #80912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2021
Merged

Add frontend_server_client to dependency allowlist #80912

merged 2 commits into from
Apr 22, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 22, 2021 •
edited
Loading

  1. Add new test_core 0.3.20 transitive dependency frontend_server_client to allowlist.
  2. Update expected signature
  3. Run flutter update-packages --force-upgrade because there were _fe_analyzer_shared conflicts
▌17:57:34▐ RUNNING: cd .; bin/flutter analyze --flutter-repo
Package "_fe_analyzer_shared" has conflicts:
  29 sources want "/Users/m/.pub-cache/hosted/pub.dartlang.org/_fe_analyzer_shared-21.0.0/lib":
    /Users/m/Projects/flutter/dev/snippets/.packages
...
    /Users/m/Projects/flutter/packages/flutter_driver/.packages
  1 source wants "/Users/m/.pub-cache/hosted/pub.dartlang.org/_fe_analyzer_shared-20.0.0/lib":

Work around #80909.

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 22, 2021
@jmagman jmagman self-assigned this Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@jmagman jmagman requested a review from jonahwilliams April 22, 2021 01:03
jonahwilliams
jonahwilliams approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman changed the title Allow frontend_server_client to dependency allowlist Add frontend_server_client to dependency allowlist Apr 22, 2021
@jmagman
Copy link
Member Author

jmagman commented Apr 22, 2021

analyzer-linux passed, merging to green the build/unblock PRs.

@jmagman jmagman merged commit 4f3ec01 into flutter:master Apr 22, 2021
@jmagman jmagman deleted the frontend branch April 22, 2021 01:13
@jmagman jmagman mentioned this pull request Apr 22, 2021
Closed
renyou pushed a commit to renyou/flutter that referenced this pull request Apr 22, 2021
@jmagman @renyou
Add frontend_server_client to dependency allowlist (flutter#80912)
8aab417
renyou added a commit that referenced this pull request Apr 22, 2021
@renyou @jmagman
Revert "Replace some dynamic to Object? type (#80772)" (#80965) (#…
519d985 
…80986)

* Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965)

This reverts commit 12a2e68.

* Add frontend_server_client to dependency allowlist (#80912)

Co-authored-by: Jenn Magder <magder@google.com>
renyou added a commit that referenced this pull request Apr 26, 2021
@renyou @jmagman @jason-simmons
Revert "[RenderEditable] Dont paint caret when selection is invalid" #…
d72bfb8 
…81076 (#81155)

* Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965)

This reverts commit 12a2e68.

* Add frontend_server_client to dependency allowlist (#80912)

* Revert "[RenderEditable] Dont paint caret when selection is invalid (#79607)" (#81076)

This reverts commit 0f8148e.

* Convert AnimatedSize to a StatefulWidget (#80554)

Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @jonahwilliams