Skip to content

Replace some dynamic to Object? type #80772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2021
Merged

Replace some dynamic to Object? type #80772

merged 4 commits into from
Apr 21, 2021

Conversation

xu-baolin
Copy link
Member

Replace some dynamic to Object? type

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2021
@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@xu-baolin
Copy link
Member Author

@Hixie hi, can this test-exempt?

shihaohong
shihaohong reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, minus one analyzer failure.

I'm wondering if it really isn't possible to test for this change, since it'd be quite easy to just start using dynamic everywhere instead of Object? in the codebase in the future

packages/flutter/lib/src/widgets/navigator.dart Outdated
key as String?,
List<Object>.from(value as List<dynamic>, growable: true),
List<Object>.from(value as List<Object?>, growable: true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the analyzer failure. I believe it's expecting a List<Object>, but you're giving it a List<Object?>

xu-baolin
xu-baolin commented Apr 20, 2021
View reviewed changes
xu-baolin
xu-baolin commented Apr 20, 2021
View reviewed changes
xu-baolin
xu-baolin commented Apr 20, 2021
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Apr 21, 2021

test-exempt: code refactor without semantic change

@fluttergithubbot fluttergithubbot merged commit 12a2e68 into flutter:master Apr 21, 2021
renyou added a commit that referenced this pull request Apr 22, 2021
@renyou
Revert "Replace some dynamic to Object? type (#80772)"
16da361 
This reverts commit 12a2e68.
@renyou renyou mentioned this pull request Apr 22, 2021
Merged
chunhtai pushed a commit that referenced this pull request Apr 22, 2021
@renyou
Revert "Replace some dynamic to Object? type (#80772)" (#80965)
7750482 
This reverts commit 12a2e68.
renyou added a commit to renyou/flutter that referenced this pull request Apr 22, 2021
@renyou
Revert "Replace some dynamic to Object? type (flutter#80772)" (fl…
0e7d326 
…utter#80965)

This reverts commit 12a2e68.
renyou added a commit that referenced this pull request Apr 22, 2021
@renyou @jmagman
Revert "Replace some dynamic to Object? type (#80772)" (#80965) (#…
519d985 
…80986)

* Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965)

This reverts commit 12a2e68.

* Add frontend_server_client to dependency allowlist (#80912)

Co-authored-by: Jenn Magder <magder@google.com>
renyou added a commit that referenced this pull request Apr 26, 2021
@renyou @jmagman @jason-simmons
Revert "[RenderEditable] Dont paint caret when selection is invalid" #…
d72bfb8 
…81076 (#81155)

* Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965)

This reverts commit 12a2e68.

* Add frontend_server_client to dependency allowlist (#80912)

* Revert "[RenderEditable] Dont paint caret when selection is invalid (#79607)" (#81076)

This reverts commit 0f8148e.

* Convert AnimatedSize to a StatefulWidget (#80554)

Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xu-baolin @Hixie @shihaohong @fluttergithubbot