Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Update compileSdkVersion to 31 and gradle lockfiles #557

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

andreidiaconu
Copy link
Contributor

@andreidiaconu andreidiaconu commented Nov 5, 2021

flutter/flutter#89511 requires compileSdkVersion 31 and it also introduces new android dependencies which means the gradle lockfiles need to be updated.

Helps with relanding flutter/flutter#89511 which was reverted in flutter/flutter#93098

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreidiaconu
Copy link
Contributor Author

The flutter_gallery integration test copy inside the flutter framework repo also needed multidex support, but this repo seems to not need that (compiles fine on my machine). Seems like dependencies are sufficiently different between the two.

@andreidiaconu
Copy link
Contributor Author

flutter/flutter#93117 reland PR depends on this PR.

@guidezpl guidezpl merged commit 9eb785c into flutter:master Nov 5, 2021
@amanv8060
Copy link
Contributor

@guidezpl Flutter gallery for android doesn't compile after this pr , i can successfully run gallery on android at commit 4fd7491

@andreidiaconu
Copy link
Contributor Author

@amanv8060 Please try the latest flutter master and let me know if you still can't compile.

@amanv8060
Copy link
Contributor

amanv8060 commented Nov 21, 2021

@andreidiaconu Thanks, I can now run now, it's weird but I tried earlier and was unable to build the app with errors
similar to

Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.5.30' which is part of the dependency lock state

I don't remember exactly which flutter/flutter commit I was on when I faced this issue.

Also, See similar prob here : #558

@andreidiaconu
Copy link
Contributor Author

andreidiaconu commented Nov 21, 2021

Thank you for also posting the actual error. I can now confirm my initial hunch: This PR updated the gallery repo to be compatible with the newest flutter master, but because that is how gradle lockfiles work, it also means that the repo is incompatible with older versions of flutter. I think this happens every time the lockfiles need to be updated, but maybe maintainers of this repo can confirm.

The reason why you had problems using flutter master until today is that the flutter change that required this PR hit a few bumps in the road, got reverted, relanded, etc - but it is now merged correctly and as long as you use flutter master for a while (until Display Features flutter/engine#29585 are promoted to other channels) you should not see this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants