Skip to content

Remove support for Fastly WAF (legacy EoL product) #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

Remove support for Fastly WAF (legacy EoL product) #1419

merged 2 commits into from
Mar 3, 2025

Conversation

kpfleming
Copy link
Contributor

The 'placement' parameter to the logging commands has been removed; it was only used in combination with the Fastly WAF, which is no longer supported.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change? - the 'placement' parameter for various logging commands is no longer available

Are there any considerations that need to be addressed for release?

This is a breaking change.

@kpfleming
Remove support for Fastly WAF (legacy EoL product)
b78aed9 
The 'placement' parameter to the logging commands has been removed; it
was only used in combination with the Fastly WAF, which is no longer
supported.
@kpfleming kpfleming marked this pull request as ready for review February 28, 2025 21:04
@kpfleming kpfleming requested a review from a team as a code owner February 28, 2025 21:04
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpfleming kpfleming merged commit 733303a into fastly:main Mar 3, 2025
8 of 14 checks passed
@kpfleming kpfleming deleted the cdtool-1015 branch March 3, 2025 14:56
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2025
Merged
anthony-gomez-fastly added a commit that referenced this pull request Mar 26, 2025
@anthony-gomez-fastly
Revert "Remove support for Fastly WAF (legacy EoL product) (#1419)"
d3358c3 
This reverts commit 733303a.
anthony-gomez-fastly added a commit that referenced this pull request Mar 26, 2025
@anthony-gomez-fastly
Revert placement removal (#1444)
eca011a 
* Revert "Remove some leftover code that should have been removed in PR 1419. (#1426)"

This reverts commit 122251a.

* Revert "Remove support for Fastly WAF (legacy EoL product) (#1419)"

This reverts commit 733303a.

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfleming @anthony-gomez-fastly