Skip to content

Revert placement removal #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Revert placement removal #1444

merged 3 commits into from
Mar 26, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Mar 26, 2025 •
edited by jira bot
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

As per CDTOOL-1032 removing this param doesn't allow users to use the cli for logging, reverting changes.

@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner March 26, 2025 18:12
@anthony-gomez-fastly anthony-gomez-fastly merged commit eca011a into main Mar 26, 2025
11 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the revert-placement-removal branch March 26, 2025 19:00
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @kpfleming