stats: change duplicate histogram log level to debug #3219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama <rama.rao@salesforce.com>
ramaraochavali
referenced
this pull request
Apr 26, 2018
Signed-off-by: Rama <rama.rao@salesforce.com>
|
@ramaraochavali I'm going to go ahead and merge this to help with debugging today. If we end up having to temporarily revert the histogram change we will need to revert this also. |
mattklein123
approved these changes
Apr 26, 2018
mattklein123
added a commit
that referenced
this pull request
Apr 26, 2018
This reverts commit fd687dd. Signed-off-by: Matt Klein <mklein@lyft.com>
htuch
pushed a commit
that referenced
this pull request
May 3, 2018
This change unreverts: #3130 #3183 #3219 Also fixes #3223 Please see the 2nd commit for the actual changes. The changes are: Bring in a new histogram library version with the fix (and more debug checking). Fix a small issue with scope iteration during merging. Remove de-dup for histograms until we iterate to shared storage for overlapping scope histograms. Personally, I found this very confusing when debugging and I think the way I changed it is better for now given the code we have. Signed-off-by: Matt Klein <mklein@lyft.com>
ramaraochavali
added a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
Signed-off-by: Rama <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rama rama.rao@salesforce.com
Description:
Changes the log level to debug as this warning spams during every flush.
Risk Level: Low
Testing: Automated test
Docs Changes: NA
Release Notes: NA