Skip to content

docs: fix a small typo #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

simonpasquier
Copy link
Contributor

Signed-off-by: Simon Pasquier spasquie@redhat.com

title: docs: fix a small typo

Description:
s/inteval/interval/

Risk Level: Low

Testing: N/A

Docs Changes: see description

Release Notes: N/A

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Copy link
Member

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ggreenway ggreenway merged commit 5455ed1 into envoyproxy:master Apr 24, 2018
@simonpasquier simonpasquier deleted the fix-doc-typo branch April 25, 2018 13:54
mattklein123 added a commit that referenced this pull request Apr 26, 2018
This reverts commit 5455ed1.

Signed-off-by: Matt Klein <mklein@lyft.com>
htuch pushed a commit that referenced this pull request May 3, 2018
This change unreverts:
#3130
#3183
#3219
Also fixes #3223

Please see the 2nd commit for the actual changes. The changes are:

Bring in a new histogram library version with the fix (and more debug
checking).
Fix a small issue with scope iteration during merging.
Remove de-dup for histograms until we iterate to shared
storage for overlapping scope histograms. Personally, I found
this very confusing when debugging and I think the way I changed
it is better for now given the code we have.

Signed-off-by: Matt Klein <mklein@lyft.com>
ramaraochavali pushed a commit to ramaraochavali/envoy that referenced this pull request May 3, 2018
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Rama <rama.rao@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants