Skip to content

Conversation

mpuncel
Copy link
Contributor

@mpuncel mpuncel commented Apr 17, 2019

Description: Add integration tests around HTTP timeouts in the router filter including per try and global timeout.
Risk Level: Low
Testing: integration tests
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@mpuncel mpuncel force-pushed the mpuncel/timeout-integration-tests branch from 562c254 to d6ef958 Compare April 17, 2019 16:59
@mpuncel
Copy link
Contributor Author

mpuncel commented Apr 17, 2019

This is split out from my hedging PR, the tests aren't related to hedging but I added coverage there using simulated time since I was writing similar tests around hedging.

@mpuncel
Copy link
Contributor Author

mpuncel commented Apr 17, 2019

/retest

@htuch htuch changed the title Mpuncel/timeout integration tests Timeout integration tests Apr 17, 2019
@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6621 (comment) was created by @mpuncel.

see: more, trace.

@htuch htuch self-assigned this Apr 17, 2019
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice!

@htuch htuch merged commit 504e15f into envoyproxy:master Apr 17, 2019
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 19, 2019
* master: (26 commits)
  docs: update docs to recommend /retest repokitteh command (envoyproxy#6655)
  http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646)
  access log: add response code details to the access log formatter (envoyproxy#6626)
  build: add ppc build badge to README (envoyproxy#6629)
  Revert dispatcher stats (envoyproxy#6649)
  Batch implementation with timer (envoyproxy#6452)
  fault filter: reset token bucket on data start (envoyproxy#6627)
  event: update libevent dependency to fix race condition (envoyproxy#6637)
  examples: standardize docker-compose version and yaml extension (envoyproxy#6613)
  quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612)
  router: support customizable retry back-off intervals (envoyproxy#6568)
  api: create OpenRCA service proto file (envoyproxy#6497)
  ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503)
  build: update jinja to 2.10.1. (envoyproxy#6623)
  tools: check spelling in pre-push hook (envoyproxy#6631)
  security: blameless postmortem template. (envoyproxy#6553)
  Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477)
  add HTTP integration tests exercising timeouts (envoyproxy#6621)
  event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619)
  Add tag extractor for RDS route config name (envoyproxy#6618)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants