Skip to content

Conversation

gsagula
Copy link
Member

@gsagula gsagula commented Apr 6, 2019

Description:
This PR adds a configurable option to ext_authz that allows the filter clearing the route cache. This is particularly useful when the authorization response headers are intended to influence the route decision of an authorized request.

Risk Level: Low
Testing: Yes
Docs Changes: Yes
Release Notes: Yes
Fixes: #6481

Gabriel added 6 commits April 6, 2019 00:05
…authz filter

Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Gabriel added 2 commits April 11, 2019 19:06
Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review: Thanks @gsagula for working on this! Small nits and a question:

Gabriel added 3 commits April 13, 2019 20:01
Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
dio
dio previously approved these changes Apr 16, 2019
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 2 small comments.

/wait

Signed-off-by: Gabriel <gsagula@gmail.com>
Gabriel added 3 commits April 17, 2019 11:22
Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
Gabriel added 2 commits April 17, 2019 16:31
…ar-route-cache

Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mattklein123 mattklein123 merged commit 0e109cb into envoyproxy:master Apr 18, 2019
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 19, 2019
* master: (26 commits)
  docs: update docs to recommend /retest repokitteh command (envoyproxy#6655)
  http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646)
  access log: add response code details to the access log formatter (envoyproxy#6626)
  build: add ppc build badge to README (envoyproxy#6629)
  Revert dispatcher stats (envoyproxy#6649)
  Batch implementation with timer (envoyproxy#6452)
  fault filter: reset token bucket on data start (envoyproxy#6627)
  event: update libevent dependency to fix race condition (envoyproxy#6637)
  examples: standardize docker-compose version and yaml extension (envoyproxy#6613)
  quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612)
  router: support customizable retry back-off intervals (envoyproxy#6568)
  api: create OpenRCA service proto file (envoyproxy#6497)
  ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503)
  build: update jinja to 2.10.1. (envoyproxy#6623)
  tools: check spelling in pre-push hook (envoyproxy#6631)
  security: blameless postmortem template. (envoyproxy#6553)
  Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477)
  add HTTP integration tests exercising timeouts (envoyproxy#6621)
  event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619)
  Add tag extractor for RDS route config name (envoyproxy#6618)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers added in envoy.ext_authz http_filter are not used for route matching
3 participants