Skip to content

chore: end support for Node 18 and upgrade to node-gyp 11.x #16218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

chore: end support for Node 18 and upgrade to node-gyp 11.x #16218

merged 1 commit into from
Sep 2, 2025

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Aug 26, 2025 •
edited
Loading

What it does

Resolves #15857
Resolves #13670

  • update node types to node 20, upgrade node-gyp to 11.x
  • update developer guide
  • update GH workflows
    • use active LTS (Node 22.x)
    • use python 3.13

How to test

  • Needs to build on all platforms and the active LTS (Node 22.x)
  • Do a general "smoke" test using the IDE

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Aug 26, 2025
@ndoschek ndoschek force-pushed the GH-15857_13670 branch 2 times, most recently from 920fdab to be962c1 Compare August 27, 2025 07:18
@ndoschek ndoschek changed the title chore: end support for Node 18 and upgrade to node-gyp 11.x chore: end support for Node 18 and upgrade to node-gyp 10.x Aug 27, 2025
@ndoschek ndoschek changed the title chore: end support for Node 18 and upgrade to node-gyp 10.x chore: end support for Node 18 and upgrade to node-gyp 11.x Aug 27, 2025
@ndoschek ndoschek force-pushed the GH-15857_13670 branch 2 times, most recently from 89593c7 to 204bc6e Compare August 27, 2025 08:11
@ndoschek
chore: end support for Node 18 and upgrade to node-gyp 11.x
e1c7b02 
Resolves #15857
Resolves #13670

- update node types to node 20, upgrade node-gyp to 11.x
- update developer guide
- update GH workflows
   - use active LTS (Node 22.x)
   - use python 3.13

Contributed on behalf of STMicroelectronics
@ndoschek ndoschek mentioned this pull request Aug 27, 2025
Open
@ndoschek ndoschek marked this pull request as ready for review August 27, 2025 09:58
@jfaltermeier
Copy link
Contributor

With node 20 I get a warning:

$ npm ci
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'node-abi@4.12.0',
npm warn EBADENGINE   required: { node: '>=22.12.0' },
npm warn EBADENGINE   current: { node: 'v20.19.2', npm: '10.8.2' }
npm warn EBADENGINE }

Build still works as far as I can see.

@ndoschek
Copy link
Contributor Author

Thanks @jfaltermeier, I had a quick look, and this behavior is already the same on current master.
The previous node-abi version also had the same Node engine requirement:

image

jfaltermeier
jfaltermeier approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Ubuntu 24.04 I haven't noticed any other issues. LGTM, thanks!

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Aug 27, 2025
@ndoschek ndoschek merged commit 3aae716 into master Sep 2, 2025
14 of 34 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Sep 2, 2025
@ndoschek ndoschek deleted the GH-15857_13670 branch September 2, 2025 07:05
@github-actions github-actions bot added this to the 1.65.0 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaltermeier jfaltermeier jfaltermeier approved these changes

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

End support for Node 18 Upgrade to node-gyp 10.x
2 participants
@ndoschek @jfaltermeier