Upgrade to react-native 0.66 #15914

Kudo · 2022-01-14T15:05:32Z

Why

follow up #15817 (comment)
after we use the react-native from npm, the react-native version we used in expo-go is decoupled with other stuffs. that makes us upgrade react-native easier.

How

update versions in package.json
sync changes from react-native-upgrade-helper
~~okio and okhttp were be upgraded in react-native 0.66. this is the same to~~ [packages] Fix okio/okhttp compatibility issue #15915 landed.
RCTComponentData changed its designated initializer in react-native 0.65. to make it compatible with older version, i introduced the EXComponentDataCompatibleWrapper class to support different versions.
[react-native-lab] to fix expo-go build error, we should patch react-native to use the codegen library from its repo but not from node_modules: Fix codegen resolution error when node_modules has different version react-native#29.

Test Plan

CI passed
bare-expo build & launch test
unversioned expo-go build & launch test

Checklist

Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
This diff will work correctly for expo build (eg: updated @expo/xdl).
This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

bbarthec

Superb work!
Nice job taking core of each edge case detected 🚀
I've briefly looked at the upgrade from rn@0.66.4 to rn@0.67.0-rc.6 and observed that there's a change in android/build.gradle regarding fetching react-native from Maven Central. Should we care about it? Maybe that might cause some additional issues? 🤔

bbarthec · 2022-01-18T18:21:50Z

packages/expo-modules-core/ios/NativeModulesProxy/EXComponentDataCompatibleWrapper.m

+// Copyright 2018-present 650 Industries. All rights reserved.
+
+#import <ExpoModulesCore/EXComponentDataCompatibleWrapper.h>
+
+@interface RCTComponentData (EXComponentDataCompatibleWrapper)
+
+// available in RN 0.65+
+- (instancetype)initWithManagerClass:(Class)managerClass
+                              bridge:(RCTBridge *)bridge
+                     eventDispatcher:(id<RCTEventDispatcherProtocol>) eventDispatcher;
+
+- (instancetype)initWithManagerClass:(Class)managerClass bridge:(RCTBridge *)bridge;
+
+@end
+
+@implementation EXComponentDataCompatibleWrapper
+
+- (instancetype)initWithManagerClass:(Class)managerClass
+                              bridge:(RCTBridge *)bridge
+                     eventDispatcher:(id<RCTEventDispatcherProtocol>)eventDispatcher
+{
+  if ([self respondsToSelector:@selector(initWithManagerClass:bridge:)]) {
+    return [super initWithManagerClass:managerClass bridge:bridge];
+  }
+  return [super initWithManagerClass:managerClass bridge:bridge eventDispatcher:eventDispatcher];
+}
+
+@end


Very clean solution 👏

Kudo · 2022-01-20T01:56:41Z

Superb work! Nice job taking core of each edge case detected 🚀 I've briefly looked at the upgrade from rn@0.66.4 to rn@0.67.0-rc.6 and observed that there's a change in android/build.gradle regarding fetching react-native from Maven Central. Should we care about it? Maybe that might cause some additional issues? 🤔

that is a nice to have notation that prevent users accidentally to fetch the old react-native from maven central when they do not fetch from node_modules. since we have implementation "com.facebook.react:react-native:+", in this case, the old version on maven central is also a match.
anyway, i'll try further to upgrade 0.67 and include the gradle change.

… react-native-codegen

…rary

…ct-native-codegen

…29) # Why fix android client build error for expo/expo#15914 when different react-native version between `node_modules/react-native` and `react-native-lab/react-native`. # How use the `react-native-codegen` from the same repository.

expo-bot · 2022-01-20T04:57:16Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against da07926

mangkoran · 2022-01-20T14:35:39Z

Is there any way to try out expo with this PR?

I want to try this out in my project.

Kudo · 2022-01-21T13:39:58Z

@mangkoran you can try to have a react-native 0.66 project and install expo modules

$ npx react-native init RN066 --version 0.66
$ cd RN066
$ npx install-expo-modules

mangkoran · 2022-01-26T03:42:42Z

@Kudo I encountered some issue when trying to run npx install-expo-modules. I filed new issue expo/expo-cli#4163.

@tsapeta

Bump `expo-modules-core` to `0.7.0`: # Changelog: ## 0.7.0 — 2022-01-26 ### 🎉 New features - Allow accessing `RCTBridge` from the modules on iOS. ([#15816](expo/expo#15816) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on iOS. ([#15731](expo/expo#15731) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on Android. ([#15743](expo/expo#15743) by [@lukmccall](https://github.com/lukmccall)) - The `ModuleDefinition` will use class name if the `name` component wasn't provided in Sweet API on Android. ([#15738](expo/expo#15738) by [@lukmccall](https://github.com/lukmccall)) - Added `onViewDestroys` component to the `ViewManager` in Sweet API on Android. ([#15740](expo/expo#15740) by [@lukmccall](https://github.com/lukmccall)) - Added shortened `constants` component that takes `vargs Pair<String, Any?>` as an argument in Sweet API on Android. ([#15742](expo/expo#15742) by [@lukmccall](https://github.com/lukmccall)) - Introduced the concept of chainable exceptions in Sweet API on iOS. ([#15813](expo/expo#15813) by [@tsapeta](https://github.com/tsapeta)) - Sweet function closures can throw errors on iOS. ([#15849](expo/expo#15849) by [@tsapeta](https://github.com/tsapeta)) - Add `requireNativeModule` function to replace accessing native modules from `NativeModulesProxy`. ([#15848](expo/expo#15848) by [@tsapeta](https://github.com/tsapeta)) - Implemented basic functionality of JSI host object to replace `NativeModulesProxy` on iOS. ([#15847](expo/expo#15847) by [@tsapeta](https://github.com/tsapeta)) ### 🐛 Bug fixes - It's no longer possible to directly call methods from the `ModuleDefinition` in the `ViewManagers` on Android. ([#15741](expo/expo#15741) by [@lukmccall](https://github.com/lukmccall)) - Fix compatibility with react-native 0.66. ([#15914](expo/expo#15914) by [@Kudo](https://github.com/kudo)) ## 0.6.4 — 2022-01-05 ### 🐛 Bug fixes - Fix `ReactInstanceManager.onHostPause` exception from moving Android apps to background. ([#15748](expo/expo#15748) by [@Kudo](https://github.com/kudo)) ## 0.6.3 — 2021-12-16 ### 🐛 Bug fixes - Fixed the deep link wasn't passed to the application if the application wasn't running when the deep link was sent. ([#15593](expo/expo#15593) by [@lukmccall](https://github.com/lukmccall)) ## 0.6.2 — 2021-12-15 ### 🎉 New features - Add `onNewIntent` and `onBackPressed` support to `ReactActivityLifecycleListener`. ([#15550](expo/expo#15550) by [@Kudo](https://github.com/Kudo))

# Why follow up expo#15817 (comment) after we use the react-native from npm, the react-native version we used in expo-go is decoupled with other stuffs. that makes us upgrade react-native easier. # How 1. update versions in package.json 2. sync changes from [react-native-upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.64.2&to=0.66.4) 3. `RCTComponentData` changed its designated initializer in react-native 0.65. to make it compatible with older version, i introduced the `EXComponentDataCompatibleWrapper` class to support different versions. 4. [react-native-lab] to fix expo-go build error, we should patch react-native to use the codegen library from its repo but not from node_modules: expo/react-native#29. # Test Plan - CI passed - bare-expo build & launch test - unversioned expo-go build & launch test

…#17266) # Why `__apply_Xcode_12_5_M1_post_install_workaround` was missing when i did #15914. that may introduced some build issue on m1 machine when flipper is enabled. # How - add missing `__apply_Xcode_12_5_M1_post_install_workaround` as from [react-native 0.68 template](https://github.com/facebook/react-native/blob/b5f1b26a8ff4014e45bbb95c5956ba2c2cf286db/template/ios/Podfile#L35) - also update `use_flipper!()` statement as from [react-native 0.68 template](https://github.com/facebook/react-native/blob/b5f1b26a8ff4014e45bbb95c5956ba2c2cf286db/template/ios/Podfile#L31). i think the old flipper issue should be already resolved. # Test Plan tested on m1 macos ```sh $ EXPO_BETA=1 expo init sdk45 # select bare # update ios/Podfile with the change and uncomment use_flipper!() $ expo run:ios # test with flipper ```

expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 14, 2022

Kudo force-pushed the @kudo/rn66 branch from 33d34bb to 3d1bbcb Compare January 15, 2022 02:55

Kudo mentioned this pull request Jan 17, 2022

Fix codegen resolution error when node_modules has different version expo/react-native#29

Merged

Kudo force-pushed the @kudo/rn66 branch 4 times, most recently from e406705 to d875d5f Compare January 18, 2022 13:32

Kudo marked this pull request as ready for review January 18, 2022 14:42

Kudo requested review from barthap, bbarthec, brentvatne, esamelson, EvanBacon, ide, lukmccall and tsapeta as code owners January 18, 2022 14:42

Kudo removed request for barthap, ide, EvanBacon and esamelson January 18, 2022 14:42

bbarthec approved these changes Jan 18, 2022

View reviewed changes

brentvatne approved these changes Jan 18, 2022

View reviewed changes

lukmccall approved these changes Jan 19, 2022

View reviewed changes

Kudo added 6 commits January 20, 2022 10:56

upgrade to react-native 0.66.4

224a532

[bare-expo] upgrade ios project files

19be932

[android] update android project files

c825e8f

[core] Fix RCTComponentData compatibility issue

e9c69a3

[react-native-lab] Fix building android client error from using wrong…

9c8f028

… react-native-codegen

[ios] Fix ios client building error from using wrong react-native lib…

a25949b

…rary

Kudo added 5 commits January 20, 2022 10:56

[react-native-lab] Fix building ios client error from using wrong rea…

ac20d10

…ct-native-codegen

update Podfile.lock

da139e8

[dev-menu] fix unit test linking error from hermes

a839845

[dev-launcher] Fix ci test error

3b113e5

update changelog

1c1f97e

Kudo force-pushed the @kudo/rn66 branch from d875d5f to 1c1f97e Compare January 20, 2022 02:56

[react-native-lab] Update commit after squashed merge

da07926

Kudo merged commit 402679c into master Jan 20, 2022

Kudo deleted the @kudo/rn66 branch January 20, 2022 06:55

tsapeta mentioned this pull request Jan 21, 2022

Fix some failing SDK tests #15999

Merged

mangkoran mentioned this pull request Jan 26, 2022

How to install expo that compatible with RN 0.66.4 expo/expo-cli#4163

Closed

lukmccall mentioned this pull request Jan 26, 2022

[modules-core] Bump version to 0.7.0 software-mansion-labs/expo-maps#24

Merged

Kudo mentioned this pull request Apr 28, 2022

[templates] fix out of sync template from react-native 0.68 #17266

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to react-native 0.66 #15914

Upgrade to react-native 0.66 #15914

Uh oh!

Kudo commented Jan 14, 2022 •

edited

Loading

Uh oh!

bbarthec left a comment •

edited

Loading

Uh oh!

bbarthec Jan 18, 2022

Uh oh!

Kudo commented Jan 20, 2022

Uh oh!

expo-bot commented Jan 20, 2022

Uh oh!

mangkoran commented Jan 20, 2022 •

edited

Loading

Uh oh!

Kudo commented Jan 21, 2022

Uh oh!

mangkoran commented Jan 26, 2022

Uh oh!

Uh oh!

Upgrade to react-native 0.66 #15914

Upgrade to react-native 0.66 #15914

Uh oh!

Conversation

Kudo commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Test Plan

Checklist

Uh oh!

bbarthec left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbarthec Jan 18, 2022

Choose a reason for hiding this comment

Uh oh!

Kudo commented Jan 20, 2022

Uh oh!

expo-bot commented Jan 20, 2022

Uh oh!

mangkoran commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kudo commented Jan 21, 2022

Uh oh!

mangkoran commented Jan 26, 2022

Uh oh!

Uh oh!

Kudo commented Jan 14, 2022 •

edited

Loading

bbarthec left a comment •

edited

Loading

mangkoran commented Jan 20, 2022 •

edited

Loading