[ios] Introduce the concept of chainable exceptions #15813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be227e8 to
42f768f
Compare
bbarthec
approved these changes
Jan 7, 2022
|
|
||
| internal class ArgumentCastException: GenericException<(index: Int, type: AnyArgumentType)> { | ||
| override var reason: String { | ||
| "Argument at index \"\(params.index)\" couldn't be casted to type \"\(params.type.description)\"." |
There was a problem hiding this comment.
Suggested change
| "Argument at index \"\(params.index)\" couldn't be casted to type \"\(params.type.description)\"." | |
| "Argument at index '\(params.index)' couldn't be casted to type '\(params.type.description)'." |
There was a problem hiding this comment.
I don't want to change all the quotes in this PR. I planned to do this once and separately, because there are also some errors/exceptions in the other places that I didn't touch in this PR.
|
|
||
| internal class FunctionCallException: GenericException<String> { | ||
| override var reason: String { | ||
| "Call to function '\(params)' has been rejected" |
There was a problem hiding this comment.
Suggested change
| "Call to function '\(params)' has been rejected" | |
| "Call to function '\(params)' has been rejected." |
| /** | ||
| The location in code where the exception was created. | ||
| */ | ||
| open var location: ExceptionLocation |
There was a problem hiding this comment.
I'm looking for the best work to describe this 👀
I know that you've discarded source, but location seems a bit odd as well (I understand location as a physical presence at some geographic area/point)
Suggested change
| open var location: ExceptionLocation | |
| open var origin: ExceptionOrigin |
lukmccall
approved these changes
Jan 7, 2022
63a8913 to
8e47817
Compare
lukmccall
added a commit
to software-mansion-labs/expo-maps
that referenced
this pull request
Jan 27, 2022
Bump `expo-modules-core` to `0.7.0`: # Changelog: ## 0.7.0 — 2022-01-26 ### 🎉 New features - Allow accessing `RCTBridge` from the modules on iOS. ([#15816](expo/expo#15816) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on iOS. ([#15731](expo/expo#15731) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on Android. ([#15743](expo/expo#15743) by [@lukmccall](https://github.com/lukmccall)) - The `ModuleDefinition` will use class name if the `name` component wasn't provided in Sweet API on Android. ([#15738](expo/expo#15738) by [@lukmccall](https://github.com/lukmccall)) - Added `onViewDestroys` component to the `ViewManager` in Sweet API on Android. ([#15740](expo/expo#15740) by [@lukmccall](https://github.com/lukmccall)) - Added shortened `constants` component that takes `vargs Pair<String, Any?>` as an argument in Sweet API on Android. ([#15742](expo/expo#15742) by [@lukmccall](https://github.com/lukmccall)) - Introduced the concept of chainable exceptions in Sweet API on iOS. ([#15813](expo/expo#15813) by [@tsapeta](https://github.com/tsapeta)) - Sweet function closures can throw errors on iOS. ([#15849](expo/expo#15849) by [@tsapeta](https://github.com/tsapeta)) - Add `requireNativeModule` function to replace accessing native modules from `NativeModulesProxy`. ([#15848](expo/expo#15848) by [@tsapeta](https://github.com/tsapeta)) - Implemented basic functionality of JSI host object to replace `NativeModulesProxy` on iOS. ([#15847](expo/expo#15847) by [@tsapeta](https://github.com/tsapeta)) ### 🐛 Bug fixes - It's no longer possible to directly call methods from the `ModuleDefinition` in the `ViewManagers` on Android. ([#15741](expo/expo#15741) by [@lukmccall](https://github.com/lukmccall)) - Fix compatibility with react-native 0.66. ([#15914](expo/expo#15914) by [@Kudo](https://github.com/kudo)) ## 0.6.4 — 2022-01-05 ### 🐛 Bug fixes - Fix `ReactInstanceManager.onHostPause` exception from moving Android apps to background. ([#15748](expo/expo#15748) by [@Kudo](https://github.com/kudo)) ## 0.6.3 — 2021-12-16 ### 🐛 Bug fixes - Fixed the deep link wasn't passed to the application if the application wasn't running when the deep link was sent. ([#15593](expo/expo#15593) by [@lukmccall](https://github.com/lukmccall)) ## 0.6.2 — 2021-12-15 ### 🎉 New features - Add `onNewIntent` and `onBackPressed` support to `ReactActivityLifecycleListener`. ([#15550](expo/expo#15550) by [@Kudo](https://github.com/Kudo))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Since we've moved arguments validation from the module's functions to the core, the rejection errors are not always useful to narrow down the real reason of failure. One thing (probably only?) I like in Java is the exception chaining.
Also, Swift uses
Errorprotocol to represent any kind of failures, but in some languages (including Java/Kotlin) the error means something that breaks the application that it cannot continue to run (out of memory, dividing by zero). On the other side, the exception means something that can be and should be handled by the developer.How
Exceptionclass that other exceptions can inherit fromGenericExceptionfor parametrized exceptionscausedByfunctionTest Plan
Demo of
console.error(err)on the JS side: