Skip to content

[5.2] Cherry-pick of #3270 - Handle null socket #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

[5.2] Cherry-pick of #3270 - Handle null socket #3284

merged 1 commit into from
Apr 22, 2025

Conversation

paulmedynski
Copy link
Contributor

Cherry-pick of #3270.

@paulmedynski paulmedynski added this to the 5.2.3 milestone Apr 17, 2025
@paulmedynski paulmedynski requested a review from a team April 17, 2025 19:25
@paulmedynski paulmedynski changed the title [6.0] Cherry-pick of #3270 - Handle null socket [5.2] Cherry-pick of #3270 - Handle null socket Apr 18, 2025
@paulmedynski
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.58%. Comparing base (1b8ea5a) to head (5b5597c).
Report is 9 commits behind head on release/5.2.

Files with missing lines Patch % Lines
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release/5.2    #3284      +/-   ##
===============================================
- Coverage        72.81%   72.58%   -0.23%     
===============================================
  Files              310      310              
  Lines            61930    61933       +3     
===============================================
- Hits             45094    44954     -140     
- Misses           16836    16979     +143
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.86% <60.00%> (-0.25%) ⬇️
netfx 70.24% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit 85a6bee into release/5.2 Apr 22, 2025
142 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/5.2-null-socket branch April 22, 2025 16:04
apoorvdeshmukh added a commit that referenced this pull request Apr 28, 2025
@apoorvdeshmukh
Port localizations for the new SNI_ERROR_10 code from PR #3284 (#3308)
1c0b2f6 
Added localizations for the new SNI_ERROR_10 code from PR #3284.
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaigle mdaigle mdaigle approved these changes

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmedynski @mdaigle @apoorvdeshmukh @cheenamalhotra