Handle null socket when receiving packets of data #3270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmedynski
requested changes
Apr 11, 2025
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
commented
Apr 11, 2025
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
paulmedynski
approved these changes
Apr 11, 2025
mdaigle
approved these changes
Apr 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3270 +/- ##
==========================================
+ Coverage 72.81% 72.98% +0.17%
==========================================
Files 297 296 -1
Lines 59661 57257 -2404
==========================================
- Hits 43440 41791 -1649
+ Misses 16221 15466 -755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
pushed a commit
that referenced
this pull request
Apr 17, 2025
paulmedynski
pushed a commit
that referenced
this pull request
Apr 17, 2025
paulmedynski
pushed a commit
that referenced
this pull request
Apr 18, 2025
paulmedynski
added a commit
that referenced
this pull request
Apr 19, 2025
paulmedynski
added a commit
that referenced
this pull request
Apr 19, 2025
paulmedynski
added a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will wrap null socket error in
SqlExceptionto prevent exception occurring in the finally block.