Fix | Minor fixes to support different test environments #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set correct condition on AE tests that require an available key store (Cert Store on Windows, else AKV) - ServerSPN test should get FQDN of target, not local machine - Instance name test shouldn't try to connect via IP if using integrated security in the context of a remote domain-based connection (Kerberos fails)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
- Coverage 70.97% 69.83% -1.15%
==========================================
Files 305 305
Lines 61807 61820 +13
==========================================
- Hits 43870 43172 -698
- Misses 17937 18648 +711
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
DavoudEshtehari
approved these changes
May 31, 2023
Kaur-Parminder
approved these changes
Jun 1, 2023
kant2002
pushed a commit
to kant2002/SqlClient
that referenced
this pull request
Jun 29, 2023
* Test Fixes: - Set correct condition on AE tests that require an available key store (Cert Store on Windows, else AKV) - ServerSPN test should get FQDN of target, not local machine - Instance name test shouldn't try to connect via IP if using integrated security in the context of a remote domain-based connection (Kerberos fails)
JRahnama
pushed a commit
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly test fixes with one managed SNI, SSRP failure case fix.
The single, minor bug fix in SSRP was around failure cases. An AggregateException itself generally shouldn't bubble up as an SSRP failure. Since we might be trying multiple IP addresses, some might be bad and some might be good. SocketException failures should result in the same "Error Locating Server/Instance Specified" error that empty SSRP responses result in.