[5.1.5] Fix | Minor fixes to support different test environments (#2045) #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test Fixes: - Set correct condition on AE tests that require an available key store (Cert Store on Windows, else AKV) - ServerSPN test should get FQDN of target, not local machine - Instance name test shouldn't try to connect via IP if using integrated security in the context of a remote domain-based connection (Kerberos fails)
David-Engel
approved these changes
Jan 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/5.1 #2325 +/- ##
==============================================
Coverage ? 71.05%
==============================================
Files ? 293
Lines ? 61562
Branches ? 0
==============================================
Hits ? 43741
Misses ? 17821
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backporting #2045 to 5.1.5