Skip to content

Conversation

domcross
Copy link
Owner

@domcross domcross commented Jan 5, 2020

Description

(Description of what the PR does, such as fixes # {issue number})

How to test

(Description of how to validate or test this PR)

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement

forslund and others added 24 commits November 27, 2019 11:24
- add .readthedocs file
- upgrade sphinx
- remove old python launch shebang
Change "https://https://" to "https://"
Fix typo in MycroftSkill documentation
* Replace integer values with enum values for clarity
* Simplify exception thrown on incompatible input
* Pythonify (and de-Chanceify) zero-output logic
The queue will store all settingsmeta upload calls and execute them
after pairing can be verified.

Starts settings download after upload has started. When settings meta upload
has started for all skills the skill download process is triggered.

This guarantees that the settingsmeta skill_gid has been populated
properly before skills try to figure out which part of the skills data
belongs to them.

Add docstrings to upload queue
Minor restructuring moving the enqueuing of settingsmeta upload to after
updating the skills manifest.
Skip the queue thread, do upload in series with skill load/reload.
If skill directory doesn't exist in current cache try to fetch a new
copy.
When skills are removed the skills manifest is updated using msm and
then sent to the backend.
- Use reload status directly instead of instance check
- Move manifest posting to start_upload method
$  if [ "$0" == "$BASH_SOURCE" ]; then echo "a"; fi
sh: 1: [: sh: unexpected operator
…-to-run-unittests

The command to run unittests was wrong documented
…atible-with-sh-and-zsh

Make venv-activate.sh compatible with sh and zsh
@domcross domcross merged commit d20cd4d into domcross:dev Jan 5, 2020
domcross pushed a commit that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants