This repository was archived by the owner on Sep 8, 2024. It is now read-only.
clean up nice_duration handler #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace integer values with enum values for clarity * Simplify exception thrown on incompatible input * Pythonify (and de-Chanceify) zero-output logic
|
Thanks chance, this looks very good. Merging now. (At some-point I should start de-forsludify core as well) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I left some nonsense behind the last time I touched these functions. This PR addresses the nonsense.
How to test
CI should cover it
Contributor license agreement signed?
CLA [ yes ]