Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

notdefine
Copy link

Description

Make venv-activate.sh compatible with sh and zsh

How to test

$ if [ "$0" == "$BASH_SOURCE" ]; then echo "a"; fi
Error: sh: 1: [: sh: unexpected operator

$ if [[ "$0" == "$BASH_SOURCE" ]]; then echo "a"; fi
Succed

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Dec 26, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @notdefine, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@forslund
Copy link
Collaborator

Hi, thanks for fixing this. Your change is absolutely correct. As soon as the CLA is received we can merge this. Let us know if there's any issues with the CLA process. (There may be until after new years before you get the CLA email since we're all away on holidays)

(Sort of irrelevant: I Think the body of the PR description might have come from the other PR)

@notdefine
Copy link
Author

The CLA is signed. greetings

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jan 3, 2020
@krisgesling
Copy link
Contributor

CLA received, thanks Thomas :)

@forslund forslund merged commit a508464 into MycroftAI:dev Jan 3, 2020
@forslund
Copy link
Collaborator

forslund commented Jan 3, 2020

Once again. a big thanks for fixing this.

@notdefine notdefine deleted the feature/fix-documentation-how-to-run-unittests branch January 3, 2020 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants