Enable FixIt to update existing initializer rather than always providing a new one #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
========================================
Coverage 99.91% 99.91%
========================================
Files 32 32
Lines 3461 3699 +238
========================================
+ Hits 3458 3696 +238
Misses 3 3
🚀 New features to boost your workflow:
|
NickEntin
approved these changes
Jun 1, 2025
| self.receivedA = receivedA | ||
| receivedB = ReceivedB() | ||
| } | ||
| init(forwardedA: ForwardedA, receivedA: ReceivedA, receivedB: ReceivedB, customizable: String = "") { |
There was a problem hiding this comment.
Should it also add public here?
There was a problem hiding this comment.
I guess will just do two passes on fix-its right now
There was a problem hiding this comment.
Ideally yes, but today we just do one fix at a time. There will be new fixit once the first fixit is applied.
dfed
added a commit
that referenced
this pull request
Jun 29, 2025
#164 introduced an issue where a fixit to add new parameters to an initializer would repeat any closure parameters in the list. This PR addresses that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
@Instantiabledoes not have a properly formattedinit, and one of the type'sinitmethods only is missing arguments or has incorrect/missing accessibility modifiers, our FixIt now updates an existinginitmethod rather than creating a new one.