Initializer fixit should not re-add conforming closure parameter #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Jun 29, 2025
| @@ -756,7 +756,7 @@ import Testing | |||
| public init(closure: @escaping @Sendable () -> Void) { | |||
| self.closure = closure | |||
| } | |||
| @Forwarded let closure: (() -> Void) | |||
There was a problem hiding this comment.
found a bug while simplifying this code!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 32 32
Lines 3763 3757 -6
==========================================
- Hits 3760 3754 -6
Misses 3 3
🚀 New features to boost your workflow:
|
This reverts commit 971d1d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#164 introduced an issue where a fixit to add new parameters to an initializer would repeat any closure parameters in the list. This PR addresses that issue.