Skip to content

backport: merge bitcoin#25286, #25989, #27719, #28078, #27071, #28077, #28692, #29813, #30085, #29833, partial bitcoin#24356 (networking backports: part 11) #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 22, 2025
Merged

backport: merge bitcoin#25286, #25989, #27719, #28078, #27071, #28077, #28692, #29813, #30085, #29833, partial bitcoin#24356 (networking backports: part 11) #6630

merged 12 commits into from
Apr 22, 2025

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Apr 14, 2025 •
edited
Loading

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg added 12 commits April 14, 2025 09:57
@kwvg
merge bitcoin#25286: remove duplicate categories from LogPrint output
1a64e8d
@kwvg
partial bitcoin#24356: replace CConnman::SocketEvents() with mockable…
8b23bfb 
… Sock::WaitMany()

includes:
- cc74459
@kwvg
merge bitcoin#25989: abort if i2p/cjdns are chosen via -onlynet but a…
378ad01 
…re unreachable
@kwvg
merge bitcoin#27719: remove Tor link & generalize onion getnodeaddres…
481175f 
…ses RPC
@kwvg
refactor: replace external ::GetLocal() usage
d051929 
`GetLocal()` will no longer be exposed through the header in
the next commit, replace it with `GetLocalAddress()`
@kwvg
merge bitcoin#28078: remove unneeded exports, use helpers over low-le…
821c11f 
…vel code, use optional
@kwvg
merge bitcoin#27071: Handle CJDNS from LookupSubNet()
0c42410
@kwvg
merge bitcoin#28077: also sleep after errors in Accept() & destroy th…
7b01e8b 
…e session if we get an unexpected error
@kwvg
merge bitcoin#28692: Delete i2p fuzz test
5045fa3
@kwvg
merge bitcoin#29813: improve -i2pacceptincoming mention
9d959d7
@kwvg
merge bitcoin#30085: detect addnode cjdns peers in GetAddedNodeInfo()
95a1853
@kwvg
merge bitcoin#29833: fix and improve logs
5699158
@kwvg kwvg added this to the 23 milestone Apr 14, 2025
@kwvg kwvg marked this pull request as ready for review April 14, 2025 18:11
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 14, 2025

Walkthrough

This pull request encompasses updates across documentation, network handling, logging, error management, and testing. The documentation for CJDNS, I2P, and Tor has been revised to generalize the use of the getnodeaddresses RPC and clarify command-line instructions. On the implementation side, modifications include wrapping peer address lookups with a conversion function to potentially transform IPv6 addresses into CJDNS format, restructuring I2P session handling and logging, and refactoring network reachability logic to use a global, thread-safe g_reachable_nets object instead of individual function calls. Several methods related to network address validation have been updated or removed in favor of inline definitions and new constants, and error checks in socket operations have been enhanced. In testing, outdated fuzz targets were removed, new test cases were added for network parameter validations, and adjustments were made for logging and socket handling within the test suites.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

UdjinM6
UdjinM6 approved these changes Apr 15, 2025
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5699158

@kwvg kwvg mentioned this pull request Apr 19, 2025
Merged
5 tasks
PastaPastaPasta
PastaPastaPasta approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5699158

@PastaPastaPasta PastaPastaPasta merged commit 272c951 into dashpay:develop Apr 22, 2025
34 checks passed
PastaPastaPasta added a commit that referenced this pull request Apr 25, 2025
@PastaPastaPasta
Merge #6634: backport: merge bitcoin#22087, bitcoin#28695, bitcoin#27375
713f90e 
, bitcoin#29649, bitcoin#27679, bitcoin#29968, partial bitcoin#26312 (UNIX domain sockets support)

10c7c1d merge bitcoin#29968: Avoid unused-variable warning in init.cpp (Kittywhiskers Van Gogh)
82a0fb2 merge bitcoin#27679: Support UNIX domain sockets (Kittywhiskers Van Gogh)
a23d651 merge bitcoin#29649: remove unnecessary log message (Kittywhiskers Van Gogh)
343bf83 merge bitcoin#27375: support unix domain sockets for -proxy and -onion (Kittywhiskers Van Gogh)
0fd83f3 merge bitcoin#28695: Sanity check private keys received from SAM proxy (Kittywhiskers Van Gogh)
6e55ab5 partial bitcoin#26312: Remove Sock::Get() and Sock::Sock() (Kittywhiskers Van Gogh)
859da12 merge bitcoin#22087: Validate port-options (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Depends on #6630

  ## Breaking Changes

  None expected.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 10c7c1d

Tree-SHA512: cf3bb84a34315fd188bf1427f59e8b050a04f26d2d4a152a8477c50daef154b35e0f29e49787ac8b585078e985d7192bc39bde27ea39a3b547c297cb2fc3a2ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @UdjinM6 @PastaPastaPasta