The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29432 (Stratum v2 Template Provider (take 3) by Sjors)
• #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake Can you cherry-pick this into your pull, to confirm that it also works for you? (I only tested it locally)

Pulled it in

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin/bitcoin/runs/24297453221}

Could be:

diff --git a/src/init.cpp b/src/init.cpp
index 4d7638cd6e..ebfcb9cf8e 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -1312,7 +1312,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
         {"-zmqpubsequence",         true}
     }) {
         const std::string arg{port_option.first};
-        const bool unix{port_option.second};
+        [[maybe_unused]] const bool unix{port_option.second};
         for (const std::string& socket_addr : args.GetArgs(arg)) {
             std::string host_out;
             uint16_t port_out{0};

Avoids the worry about future compilers, and (void)blah which isn't explanatory

Avoids the worry about future compilers, and (void)blah which isn't explanatory

I think (void)blah; is well understood to mean this (to both code readers and compilers), but [[maybe_unused]] seems fine as well. Switched to that.