Skip to content

Conversation

MarnixCroes
Copy link
Contributor

@MarnixCroes MarnixCroes commented May 22, 2023

  • remove broken link about how to properly configure tor
  • generalize getnodeaddresses RPC in doc

@DrahtBot
Copy link
Contributor

DrahtBot commented May 22, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake
Concept ACK jonatack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label May 22, 2023
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@MarnixCroes
Copy link
Contributor Author

@jonatack thank you! I've applied your suggestions

- unify bitcoin-cli getnodeaddresses for CJDNS, I2P and Tor
- remove outdated link to Tor project
@fanquake fanquake changed the title doc: Tor: fix link & generalize onion getnodeaddresses RPC doc: remove Tor link & generalize onion getnodeaddresses RPC Jun 1, 2023
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6fce5dd

@fanquake fanquake merged commit 9e54dde into bitcoin:master Jun 1, 2023
@MarnixCroes MarnixCroes deleted the doc-tor branch June 1, 2023 14:25
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 1, 2023
…ddresses RPC

6fce5dd doc: update getnodeaddresses for CJDNS, I2P and Tor and rm link (Marnix)

Pull request description:

  - remove broken link about how to properly configure tor
  - generalize getnodeaddresses RPC in doc

ACKs for top commit:
  fanquake:
    ACK 6fce5dd

Tree-SHA512: 3a077a0724c57a5c6182d40fbf34a84d2515bf1bf06ea0ce717174d0a27f5b19b9521c1ed1995adfdf4d43c2ce978a81e2ec9e3c8faf83f5188571fa75ea5314
@bitcoin bitcoin locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants