Skip to content

Feature 2390 ctp hum index #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Jun 30, 2025
Merged

Feature 2390 ctp hum index #2981

merged 58 commits into from
Jun 30, 2025

Conversation

DanielAdriaansen
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen commented May 16, 2025 •
edited
Loading

Closes #2390

  • Describe testing already performed for these changes:

    Ran on Seneca and verified use case runs with no errors.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  1. Review documentation here: https://metplus.readthedocs.io/en/feature_2390_ctp_humindex/generated/model_applications/land_surface/PointStat_fcstUFS_obsGDAS_CTP_HI.html#expected-output
  2. Run use case and verify it works and produces no errors

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    There is new sample data for this use case.

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe:
    It is reporting that there is 26% duplicate code.

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@DanielAdriaansen
Initial Python embedding script for computing CTP from GDAS prepbufr …
85775f3 
…radiosondes (obs).
@DanielAdriaansen
Cleanup of extra debugging and development blocks.
5974dd9
@DanielAdriaansen
Initial Python embedding script for computing HI from GDAS prepbufr r…
bf1b922 
…adiosondes (obs).
@DanielAdriaansen
Minor changes to print statements.
d6a62c3
@DanielAdriaansen
Major cleanup.
4b0bfd2
@DanielAdriaansen
Removes check for highest pressure since that could vary. Check was m…
5fc0256 
…oved to function in METcalcpy.
@DanielAdriaansen
Conf file for this use case.
edf5728
@DanielAdriaansen
Python embedding script for FCST for CTP.
289d261
@DanielAdriaansen
Changes for UserScript and GenVxMask.
aee457a
@DanielAdriaansen
Merge branch 'develop' into feature_2390_CTP_HumIndex
15ed82f
@DanielAdriaansen
Changes for function signature to take a station_id argument.
7d2c615
@DanielAdriaansen
Python embedding script to compute Humidity Index from UFS/HR1 foreca…
60a15ff 
…st data.
@DanielAdriaansen
Script to create a lat/lon text file for GenVxMask to read and create…
165c166 
… a gridded mask file to use, based on radiosonde station locations in a GDAS prepBUFR file.
@DanielAdriaansen
Updates to account for new station_id argument by calc_ctp function i…
fc07382 
…n METcalcpy.
@DanielAdriaansen
Major changes to workflow using multiprocessing for computing CTP fro…
e56cf2c 
…m UFS/HR1 forecast data.
@DanielAdriaansen
Removes erroneous code from script that this script was copied from.
807c49e
@DanielAdriaansen
Removes unused code from development and print statements from develo…
2c9ec0b 
…pment.
@DanielAdriaansen
Removes print statements used during development.
6f8cc5b
@DanielAdriaansen
Removes unused code from development and print statements from develo…
98adc3d 
…pment.
@DanielAdriaansen
Updated use case configuration file including config sections for eac…
6e433fe 
…h metric, GenVxMask options, and UserScript options.
@DanielAdriaansen
Merge branch 'develop' into feature_2390_CTP_HumIndex
77a3b35
@DanielAdriaansen
Turns down verbosity for PointStat.
be55470
@DanielAdriaansen
Adds print statement that the Python embedding script is starting for…
f7b06de 
… log purposes.
@DanielAdriaansen
Adds print statement to log when it is starting to each Python embedd…
68ff636 
…ing script, and also removes the interp argument from calc_humidity_index for obs to use the default value in METcalcpy.
@DanielAdriaansen
Adds debug message for printing the station being processed, with the…
97d2876 
… default turned off.
@DanielAdriaansen
Merge branch 'develop' into feature_2390_CTP_HumIndex
fee0bfb
@DanielAdriaansen
Major updates to documentation file for use case.
487889b
@DanielAdriaansen
Updates to the UserScript to allow a user to control which sites are …
63d7dd2 
…included in the mask file for GenVxMask.
@DanielAdriaansen
Cleanup of use case config gile to remove unused items.
2786e4f
@DanielAdriaansen
Switches to F strings, wraps some print statements in DEBUG, and swit…
73d0388 
…ches to NumPy max/min.
@DanielAdriaansen DanielAdriaansen linked an issue May 16, 2025 that may be closed by this pull request
New Use Case: Convective Triggering Potential - Humidity Index #2390
Closed
26 tasks
@DanielAdriaansen DanielAdriaansen added this to the METplus-6.1.0 milestone May 16, 2025
@DanielAdriaansen DanielAdriaansen moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development May 16, 2025
@DanielAdriaansen
Copy link
Contributor Author

@anewman89 as discussed here: #2390 (comment), just waiting on the "scientific objective" language for the documentation and also a clarification on how to refer to the model data used here.

If you're not comfortable running the use case, we may want to add another reviewer who can run the use case. Maybe Bri?

@anewman89
Copy link

Thanks @DanielAdriaansen ! Yes, could you add Bri and have her run the case as a test for this PR?

@anewman89
Copy link

Regarding scientific reasoning, I've added text to our internal notes document. The model could be referred to as a UFS global (GFSv17) pre-release test configuration or something along those lines. @KathrynNewman any suggested changes to that?

@KathrynNewman
Copy link

Regarding scientific reasoning, I've added text to our internal notes document. The model could be referred to as a UFS global (GFSv17) pre-release test configuration or something along those lines. @KathrynNewman any suggested changes to that?

I'd call it either an experimental version of GFSv17 or GFSv17 prototype configuration.

@DanielAdriaansen DanielAdriaansen requested a review from briannen May 28, 2025 21:59
@DanielAdriaansen
Copy link
Contributor Author

@briannen can you review this new use case?

We'd like you to:

  1. Read the documentation which you can view here: https://metplus.readthedocs.io/en/feature_2390_ctp_humindex/generated/model_applications/land_surface/PointStat_fcstUFS_obsGDAS_CTP_HI.html#sphx-glr-generated-model-applications-land-surface-pointstat-fcstufs-obsgdas-ctp-hi-py
  2. Run the use case and verify the output you receive is the same as the output files listed in the documentation. Check the graphic that is generated and compare with the use case gallery image here: https://github.com/dtcenter/METplus/blob/c7ba9a4c40538c3b9662863f2419b8ca5d2c908b/docs/_static/land_surface-PointStat_fcstUFS_obsGDAS_CTP_HI.png and make sure yours is the same.
  3. If you encounter issues or have questions reply here so we can assist or make changes if there are problems with the use case.

@anewman89 anything to add for Bri?

@DanielAdriaansen
Removes extra #.
10991d7
@DanielAdriaansen
Removes uneccesary imports in user script.
810132d
@DanielAdriaansen
Adds more clarity that METcalcpy is a required Python package for Pyt…
95e7d3e 
…hon embedding.
@DanielAdriaansen
Moves the setting of MET_PYTHON_EXE into the configuration file, as t…
9945e68 
…he user should ensure the version of Python in their environment at the time of running the use case meets the requirements for both Python embedding and Python UserScripts.
@DanielAdriaansen
Removes MET_PYTHON_EXE since it will not be needed if a user has comp…
8f4e774 
…iled MET against a version of Python that has the requirements for Python embedding. MET_PYTHON_EXE should be set in the users' local conf file, and as described in the documentation, simply be set to python3.
@DanielAdriaansen
Adds updated note for users in the Running METplus section that provi…
ee65c0e 
…des guidance on how to ensure the correct Python is used for the various components (Python embedding, Python UserScripts).
@DanielAdriaansen
Merge branch 'feature_2390_CTP_HumIndex' of github.com:dtcenter/METpl…
304f7de 
…us into feature_2390_CTP_HumIndex
briannen
briannen approved these changes Jun 30, 2025
View reviewed changes
Copy link

@briannen briannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output looks correct and documentation is good.

@DanielAdriaansen DanielAdriaansen merged commit 3015057 into develop Jun 30, 2025
73 of 75 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Jun 30, 2025
@DanielAdriaansen DanielAdriaansen deleted the feature_2390_CTP_HumIndex branch June 30, 2025 17:12
@DanielAdriaansen DanielAdriaansen mentioned this pull request Jun 30, 2025
Closed
26 tasks
metplus-bot added a commit that referenced this pull request Jun 30, 2025
@metplus-bot
added entry to update truth change log: develop #2981, #3020, #3030
5229dd2
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
georgemccabe pushed a commit that referenced this pull request Jun 30, 2025
@github-actions
Update develop-ref after #2981, #3020, #3030 (#3038)
a5f9e4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briannen briannen briannen approved these changes

@anewman89 anewman89 Awaiting requested review from anewman89

Assignees

@DanielAdriaansen DanielAdriaansen

Labels
METplus: Land Surface type: new use case Add a new use case
Projects
No open projects
METplus-6.1 Development
Status: 🏁 Done
Milestone
METplus-6.1.0
Development

Successfully merging this pull request may close these issues.

New Use Case: Convective Triggering Potential - Humidity Index
4 participants
@DanielAdriaansen @anewman89 @KathrynNewman @briannen