[libprotobuf-mutator] Compatible with Conan 2.x #24163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
…protobuf-mutator/1.3
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
The upstream uses EXCLUDE_FROM_ALL CMake feature to avoid building examples by default, however, CMake still parses the example cmake file and requires more external dependencies like expat. Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
The project does not expose symbols in .lib when building Windows + shared=True. Dropped shared option when building with MSVC. I'll send a PR to upstream trying to fix it. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
valgur
approved these changes
May 30, 2024
jcar87
approved these changes
May 30, 2024
phbasler
pushed a commit
to phbasler/conan-center-index
that referenced
this pull request
Jun 3, 2024
* Protobug mutator compatible with Conan 2.x Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add version 1.3 Signed-off-by: Uilian Ries <uilianries@gmail.com> * Enforce protobuf link Signed-off-by: Uilian Ries <uilianries@gmail.com> * update abseil usage Signed-off-by: Uilian Ries <uilianries@gmail.com> * consume all libs in tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * define cxx language in cmakelists Signed-off-by: Uilian Ries <uilianries@gmail.com> * static-library on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> * Exclude examples from CMakeLists.txt The upstream uses EXCLUDE_FROM_ALL CMake feature to avoid building examples by default, however, CMake still parses the example cmake file and requires more external dependencies like expat. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Do not build shared on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
jcar87
pushed a commit
that referenced
this pull request
Jul 9, 2025
* (#24165) remove ericLemanissier from the authorized_users and reviewers * (#24163) [libprotobuf-mutator] Compatible with Conan 2.x * Protobug mutator compatible with Conan 2.x Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add version 1.3 Signed-off-by: Uilian Ries <uilianries@gmail.com> * Enforce protobuf link Signed-off-by: Uilian Ries <uilianries@gmail.com> * update abseil usage Signed-off-by: Uilian Ries <uilianries@gmail.com> * consume all libs in tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * define cxx language in cmakelists Signed-off-by: Uilian Ries <uilianries@gmail.com> * static-library on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> * Exclude examples from CMakeLists.txt The upstream uses EXCLUDE_FROM_ALL CMake feature to avoid building examples by default, however, CMake still parses the example cmake file and requires more external dependencies like expat. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Do not build shared on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> * (#24060) elfutils: Bump gettext to version 0.22.5 to support GCC 14 * (#24176) [sioclient] Build static libraries in Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> * (#24174) meson: add version 1.4.1 * (#24175) ada: add version 2.8.0 * (#24057) add extra-cmake-modules 6.2.0 * add cmaes * Update config.yml * Remove trailing whitespace * Apply linter comments * undo copy paste error * Remove unused imports * change name * add line break * Set layout src_folder arg * Adjust hook warnings and fix find_package * fix missing requirement * Set minimum conan version to 2 * Undo conan minimum requirement * Add patch to remove pc and exports * Remove patch, remove cmake and pc through conanfile * only get openmp on mac and linux * disable openmp on windows for now * Add test workflow * Revert "Add test workflow" This reverts commit eb34bdc. * Add patch for eigen and for windows compile options * Revert "Add patch for eigen and for windows compile options" This reverts commit ebc0e0b. * Apply patch to fix windows build * Add empty new line at the end * Set c++ standard to 11 in test_package * Add second example and validate profile to have at least c++11 * Apply openmp settings from #24577 * Add eigen to requires array * Add is_msvc to imports * Undo openmp suggestions * Cleanup * Simplify test_package * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Simplify, remove Windows support * Use libcmaesConfig.cmake as cmake file name * Update recipes/cmaes/all/conanfile.py * Update recipes/cmaes/all/test_package/CMakeLists.txt --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Jordan Williams <jordan@jwillikers.com> Co-authored-by: toge <toge.mail@gmail.com> Co-authored-by: Gary Wang <git@blumia.net> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> Co-authored-by: Abril Rincón Blanco <abrilrb@jfrog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libprotobuf-mutator/1.3
The libprotobuf-mutator has now official tags, which means we can drop the old custom version in CCI.
This PR is a follow-up of PR #24159. Between 1.1 and 1.3 some things changed and required more attention, including:
Notes about this PR in concrete:
TODO: Send a PR to the upstream fixing not only abseil usage, but cxx standard too.