cmaes: Add 0.10.0 #24202

phbasler · 2024-06-03T05:53:47Z

Specify library name and version: cmaes/0.10.0

Add new package cmaes according to issue #24201
Fixes #24201

I am not the author of cmaes, but according to the authors in CMA-ES/libcmaes#233 I can provide this recipe.

Maintainers changes

Dropped MSVC support. Upstream still has not accepted the patch. Originally, the project did not support MSVC and is delaying this PR. In case of accepting and merging, we can have a new PR in the future.
Fixed both the generated CMake file and pkgconf (.pc) file name to follow libcmaes.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

… reviewers

* Protobug mutator compatible with Conan 2.x Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add version 1.3 Signed-off-by: Uilian Ries <uilianries@gmail.com> * Enforce protobuf link Signed-off-by: Uilian Ries <uilianries@gmail.com> * update abseil usage Signed-off-by: Uilian Ries <uilianries@gmail.com> * consume all libs in tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * define cxx language in cmakelists Signed-off-by: Uilian Ries <uilianries@gmail.com> * static-library on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> * Exclude examples from CMakeLists.txt The upstream uses EXCLUDE_FROM_ALL CMake feature to avoid building examples by default, however, CMake still parses the example cmake file and requires more external dependencies like expat. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Do not build shared on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>

…GCC 14

Signed-off-by: Uilian Ries <uilianries@gmail.com>

CLAassistant · 2024-06-03T05:53:53Z

All committers have signed the CLA.

uilianries · 2024-06-03T07:29:44Z

@phbasler Thank you for your PR! Please, take a look in you emails/accounts used in this PR: #24202 (comment)

The CLA bot listed 2 emails and it will not approve if both agrees to the CLA.

phbasler · 2024-06-03T07:35:49Z

@uilianries
Thanks.
The first commit was signed with an old e-mail adress which is not valid any longer.
I will have a look at it on how to change the assigned e-mail adress. Otherwise I will just redo the PR with the correct e-mail

…nter-index into packages/cmaes

conan-center-bot · 2024-07-26T05:34:54Z

Conan v1 pipeline ✔️

All green in build 29 (1434ba5995303bf9f13c109c6553277451cc2830):

cmaes/0.10.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 29 (1434ba5995303bf9f13c109c6553277451cc2830):

cmaes/0.10.0:
All packages built successfully! (All logs)

phbasler · 2024-11-22T11:55:21Z

@AbrilRBS why did you remove the openmp option? Should the package not be used anymore?

AbrilRBS

Hi! Thanks for taking the time to create the PR, sorry that we didn't get back to you on a timely manner. I've left some comments on the PR, and made a cleanup now that Conan 1 support is no longer needed :)

recipes/cmaes/all/conanfile.py

AbrilRBS · 2024-11-22T11:52:36Z

recipes/cmaes/all/patches/CompilerOptionsEigen.patch

+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 4a38212..dccfea4 100644
+--- a/CMakeLists.txt
+++ b/CMakeLists.txt


I see this comes from CMA-ES/libcmaes#234, do you have any insight into wether it will be merged eventually?

I hope so. I will trigger @beniz again. If there is a new version with the PR, then I can adjust the conanfile here to not include this patch for the new version

recipes/cmaes/all/patches/CompilerOptionsEigen.patch

recipes/cmaes/all/test_package/src/example.cpp

AbrilRBS · 2024-11-22T12:37:55Z

@AbrilRBS why did you remove the openmp option? Should the package not be used anymore?

Not that is should not be used per-se, it's more that its funcionality currently does not align with our expectations on CCI

phbasler · 2024-12-08T09:43:54Z

@AbrilRBS Just a little bump. Do you need anything for the last two points?

phbasler · 2025-05-13T15:43:55Z

@AbrilRBS @danimtb Anything to help with the review process?

uilianries

@phbasler Thank you for your time and effort in pushing this PR 😄

Just like @AbrilRBS, I'm concerned about these patches listed in this PR: We try to keep as close as possible to the upstream in terms of code to reflect the exact same behavior from there. We can accept patches, but usually as a last resort, we prefer to push a newer version with those fixes instead, so we do not need to "maintain" patches in the repository. You can obtain more information in policy about patching section. Also, when patching, please keep it as minimal as possible and well referenced from where it came, including using patch_source in the conandata.yml if possible, it helps all the community in terms of security and reliability.

I also would keep this recipe as simple as possible, avoiding the option surrog. First, because the CI will not validate that option as False, so we need to build locally to check it. Second, because it can be configured via the Conan config tools.cmake.cmaketoolchain:extra_variables when needed from consumer side.

recipes/cmaes/all/patches/CompilerOptionsEigen.patch

recipes/cmaes/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

recipes/cmaes/all/conanfile.py

recipes/cmaes/all/test_package/CMakeLists.txt

uilianries

LGTM.

The linter accuses of using a bad URL for downloading, because it's a tag, not a proper release package. However, the upstream has no distributed release: https://github.com/CMA-ES/libcmaes/releases

phbasler · 2025-07-01T05:10:12Z

@uilianries Thanks for adjusting this.
I will open a new PR once the PR on upstream is done.

ericLemanissier and others added 7 commits May 30, 2024 16:21

(conan-io#24165) remove ericLemanissier from the authorized_users and…

80515f3

… reviewers

(conan-io#24060) elfutils: Bump gettext to version 0.22.5 to support …

0198bb0

…GCC 14

(conan-io#24176) [sioclient] Build static libraries in Windows

ab5c602

Signed-off-by: Uilian Ries <uilianries@gmail.com>

(conan-io#24174) meson: add version 1.4.1

79f3dda

(conan-io#24175) ada: add version 2.8.0

91724e6

(conan-io#24057) add extra-cmake-modules 6.2.0

bb9710d

conan-center-bot added the User-approval pending label Jun 3, 2024

This comment has been minimized.

Sign in to view

phbasler added 3 commits June 3, 2024 21:45

add cmaes

70c7b7b

Update config.yml

62b1cea

Remove trailing whitespace

e45bbab

phbasler force-pushed the packages/cmaes branch from 4baf1b5 to e45bbab Compare June 3, 2024 19:46

Merge branch 'master' into packages/cmaes

a8f1be6

conan-center-bot added Failed and removed User-approval pending labels Jun 3, 2024

This comment has been minimized.

Sign in to view

phbasler added 3 commits June 3, 2024 21:49

Apply linter comments

2c1c3ab

Merge branch 'packages/cmaes' of https://github.com/phbasler/conan-ce…

aef42b4

…nter-index into packages/cmaes

undo copy paste error

7f4c46b

This comment has been minimized.

Sign in to view

phbasler added 4 commits June 3, 2024 21:53

Remove unused imports

6dd4404

change name

cff6a8b

add line break

1cc89e8

Set layout src_folder arg

171eccc

conan-center-bot requested a review from AbrilRBS August 5, 2024 11:39

conan-center-bot requested a review from danimtb September 19, 2024 11:39

phbasler and others added 2 commits November 15, 2024 20:32

Merge branch 'conan-io:master' into packages/cmaes

6d1b59b

Cleanup

b3bee09

AbrilRBS reviewed Nov 22, 2024

View reviewed changes

Simplify test_package

ea4493f

phbasler requested a review from AbrilRBS January 13, 2025 21:34

uilianries reviewed May 16, 2025

View reviewed changes

Apply suggestions from code review

346bd23

Co-authored-by: Uilian Ries <uilianries@gmail.com>

AbrilRBS added the blocked Affected by an external issue and waiting until it is solved label Jun 18, 2025

Simplify, remove Windows support

c4426e2

AbrilRBS removed the blocked Affected by an external issue and waiting until it is solved label Jun 24, 2025

AbrilRBS requested a review from uilianries June 24, 2025 16:22

uilianries reviewed Jun 25, 2025

View reviewed changes

recipes/cmaes/all/conanfile.py Show resolved Hide resolved

Use libcmaesConfig.cmake as cmake file name

d1ac0ee

uilianries reviewed Jun 25, 2025

View reviewed changes

recipes/cmaes/all/conanfile.py Show resolved Hide resolved

Update recipes/cmaes/all/conanfile.py

30044ee

uilianries reviewed Jun 25, 2025

View reviewed changes

recipes/cmaes/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

Update recipes/cmaes/all/test_package/CMakeLists.txt

4d97188

uilianries approved these changes Jun 25, 2025

View reviewed changes

AbrilRBS approved these changes Jun 25, 2025

View reviewed changes

jcar87 merged commit 6c4ac8a into conan-io:master Jul 9, 2025
8 checks passed

phbasler deleted the packages/cmaes branch July 29, 2025 21:16

phbasler mentioned this pull request Jul 29, 2025

Update: cmaes 0.10.2 #27965

Merged

3 tasks

cmaes: Add 0.10.0 #24202

cmaes: Add 0.10.0 #24202

Uh oh!

Conversation

phbasler commented Jun 3, 2024 • edited by uilianries Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Maintainers changes

Uh oh!

CLAassistant commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented Jun 3, 2024

Uh oh!

phbasler commented Jun 3, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Jul 26, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

Uh oh!

phbasler commented Nov 22, 2024

Uh oh!

AbrilRBS left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AbrilRBS Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

phbasler Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AbrilRBS commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phbasler commented Dec 8, 2024

Uh oh!

phbasler commented May 13, 2025

Uh oh!

uilianries left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uilianries left a comment

Choose a reason for hiding this comment

Uh oh!

phbasler commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

phbasler commented Jun 3, 2024 •

edited by uilianries

Loading

CLAassistant commented Jun 3, 2024 •

edited

Loading

AbrilRBS left a comment •

edited

Loading

AbrilRBS commented Nov 22, 2024 •

edited

Loading