Skip to content

add accents for nan-tw #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 6, 2025
Merged

add accents for nan-tw #4075

merged 8 commits into from
Jan 6, 2025

Conversation

irvin
Copy link
Member

@irvin irvin commented Jun 11, 2023 •
edited
Loading

Pull Request Form

Type of Pull Request

  • Bulk sentence upload
  • Related to a listed issue
  • Other

Acknowledging contributors

@irvin irvin requested a review from a team as a code owner June 11, 2023 02:59
@irvin irvin requested review from moz-dfeller and removed request for a team June 11, 2023 02:59
@irvin irvin mentioned this pull request Jul 3, 2023
Closed
@irvin irvin closed this Dec 3, 2024
@irvin irvin reopened this Dec 3, 2024
@irvin
Copy link
Member Author

irvin commented Dec 3, 2024

I had tried to simplify the whole PR according to change on #4697

@irvin
Copy link
Member Author

irvin commented Dec 31, 2024

had update the PR regards the latest refactor in #4732

@irvin irvin changed the title add migration intends to add accents for nan-tw add accents for nan-tw Dec 31, 2024
@moz-dfeller
Copy link
Contributor

Hey @irvin , thanks for updating the PR. That was quick! Just going to check the changes in the upcoming days and finally merge it 👍

@moz-dfeller moz-dfeller merged commit f6b97fa into common-voice:main Jan 6, 2025
2 checks passed
@irvin
Copy link
Member Author

irvin commented Feb 18, 2025

this had fixed #3708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moz-dfeller moz-dfeller Awaiting requested review from moz-dfeller moz-dfeller is a code owner automatically assigned from common-voice/cv-engineers

1 more reviewer

@mingtsay mingtsay mingtsay approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irvin @moz-dfeller @mingtsay