refactor: move variants into its own file and add accent handling on … #4732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 6.09 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We handle accents via migrations which causes problems when setting up the local development environment for the first time. Locales are loaded via Pontoon after the migrations have run, causing migrations that rely on the existence of specific locales to fail. Additionally we're extracting the variants and accents from the
import-locales.tsscript to hopefully enhance discoverability and make it more obvious on how to add more variants/accents to the lists.The new place to add accents and variants is here:
server/src/lib/model/db/language-data/accents.tsserver/src/lib/model/db/language-data/variants.ts