add accent options for nan-tw #3473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Heyhillary @ftyers what are the next steps for this pull-request? |
|
Hey @zaccolley , before we submit the merge - can we check-in with EM as there is going to be some follow up work with the accent capture write-ins to update the default accent lists. |
|
@Heyhillary got the go ahead from EM merging this. Thank you @irvin |
|
thanks! |
|
@zaccolley hi, this still not showing up in the accent dropdown menu. Has it been deployed to the production site? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
Add accents data for nan-tw. We use the same list at zh-tw which are the birthplaces (city) as the default options.
This is the suggest options from local linguistic researchers, the reason is that people often don't know the formal name or correct accents (or in Mandarin cases, people don't know there are accents and differences within Taiwan Mandarin), so the researchers use birthplace to distinguish and do analysis.
Acknowledging contributors