Skip to content

Custom images feature #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 19, 2025
Merged

Custom images feature #530

merged 8 commits into from
Apr 19, 2025

Conversation

uzaxirr
Copy link
Contributor

@uzaxirr uzaxirr commented Apr 15, 2025

Depends on: civo/civogo#244

@uzaxirr uzaxirr requested a review from Copilot April 15, 2025 17:45
@uzaxirr uzaxirr self-assigned this Apr 15, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

cmd/diskimage/disk_image_find.go:13

  • [nitpick] The primary command is changed to 'show' while retaining 'find' as an alias. Consider whether both are necessary or if consolidating to a single name would improve clarity.
Use:     "show",

cmd/diskimage/disk_image_delete.go:27

  • The error message here is not very descriptive. Consider providing a more detailed message such as "Failed to find disk image: %s" to better inform the user of the failure context.
utility.Error("Disk Image %s", err)

@uzaxirr uzaxirr marked this pull request as draft April 16, 2025 09:51
@uzaxirr uzaxirr marked this pull request as ready for review April 16, 2025 12:24
@uzaxirr uzaxirr merged commit c5e2df4 into master Apr 19, 2025
1 check passed
@uzaxirr uzaxirr deleted the custom-img branch April 19, 2025 20:45
uzaxirr added a commit that referenced this pull request Apr 30, 2025
* feat(diskimage): add support for custom disk images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants