llvm: Switch from git clone to archive curl #370
Conversation
8a08ec1 to
e3f4d3b
Compare
|
@gentoo-root Do you think it makes sense to have renovate manage the llvm version? AFAIU this has been somewhat of a manual process intentionally, so I'm wondering if automated updates just create additional review overhead. |
|
The process is pretty much described in this issue: cilium/cilium#32801. I actually wanted to make this checklist a template. It indeed involves manual steps: we normally have to fix code that relied on implicit assumptions (and doesn't compile anymore), and we need to check how the complexity changes. So, I don't think that blindly automating it is a good idea. If we do automate some steps, we still need to make sure that manual fixes and steps are done. |
There was a problem hiding this comment.
@HadrienPatte I think we should keeo managing the llvm version manually for now, otherwise the changes LGTM
e3f4d3b to
856c1af
Compare
|
Thanks! updated the PR to remove the renovate comment |
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
856c1af to
558ada3
Compare
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267.
This improves image build time as a full clone of
llvm/llvm-projecttakes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain).Note: also add a renovate comment to manage the LLVM version, see #349