Upgrade to LLVM 18.1.8 #32801
Description
- Build new LLVM images.
- Open a pull request to https://github.com/cilium/image-tools changing the image version (example).
- Make sure that CI passes, get the reviews and merge it.
- Wait for the workflow to push the image: https://github.com/cilium/image-tools/actions/workflows/images.yaml
- Find the new tag for the next step here: https://quay.io/repository/cilium/cilium-llvm?tab=tags
- Update LLVM version in https://github.com/cilium/cilium (example).
- Update CILIUM_LLVM_IMAGE in images/builder/Dockerfile and images/runtime/Dockerfile.
- Update LLVM versions in GitHub workflows (to be deprecated at some point).
- Follow the instruction to update Docker images.
-
git switch -c "pr/$USER/upgrade-llvm-X-Y-Z" -
git commit -asm 'images: Update LLVM to X.Y.Z' -
git commit --amen— addFixes: #NNNNNwith this issue number. -
git push -u origin "pr/$USER/upgrade-llvm-X-Y-Z"and open a pull request — the pull request should not be created from a fork. Label it withrelease-note/misc. - Have a member of team/build approve the build here.
- The build should push a commit named
images: update cilium-{runtime,builder}to your branch automatically (example).Base Image Lintwill fail before that commit is pushed. It's expected.
- Have a member of team/build approve the build here again.
- Post
/testto the pull request.
-
- Analyze the CI results.
- If there are failures due to the LLVM upgrade, such as compilation errors, verifier errors, or other errors that could be caused by the upgrade of LLVM, fix those.
- The CI checks that all commits are buildable. It means you can't have fixups after the upgrade commit, and it also means that the fixups that come before the upgrade commit have to work with the previous LLVM.
- Therefore, it's suggested to push the fixes via a separate pull request that will be merged before the upgrade. It also ensures that they run through the CI both on the old and the new LLVM versions.
- If it's impossible to create a fix that works for both LLVM versions, show your ingenuity, for example, use
__clang_major__,__clang_minor__and__clang_patchlevel__macros, although it's very undesirable and pretty unlikely to be needed.
- Repeat the Docker images update if need be.
- If fixing the new errors takes some time, it's likely that new cilium-builder and cilium-runtime images will have to be generated due to conflicts with other components.
- If there are failures due to the LLVM upgrade, such as compilation errors, verifier errors, or other errors that could be caused by the upgrade of LLVM, fix those.
- Make sure that CI passes, get the reviews and merge the pull request. That's it for the actual upgrade.
- Update the system requirements in the docs.