Skip to content

Conversation

meowgorithm
Copy link
Member

Note that we still need to fix the tests.

@meowgorithm meowgorithm requested a review from caarlos0 as a code owner June 8, 2025 21:40
@meowgorithm meowgorithm requested a review from Copilot June 8, 2025 21:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the module and package from “serpentine” to “fang” and applies several minor edits to themes, help output formatting, examples, and documentation.

  • Renamed module and package identifiers from serpentine to fang
  • Updated default light theme title color and removed extra blank lines in help sections
  • Adjusted example code, tests, and README to reflect the new module name

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
theme.go Package rename and changed DefaultThemeLight.Title color value
help.go Package rename and removed blank lines before help sections
go.mod Module path updated to github.com/charmbracelet/fang
fang_test.go Package and import path updates; updated test signatures
fang.go Package rename and updated doc comments for Option and Execute
example/main.go Package import rename and updated example messages
README.md Updated project name, usage instructions, and import paths
Comments suppressed due to low confidence (4)

README.md:34

  • The README references fang.Setup, but there is no Setup function in the code. Consider updating this to use fang.Execute or adding a Setup helper if intended.
To use it, invoke `fang.Setup` passing your root `*cobra.Command` as

help.go:43

  • [nitpick] The blank line before the commands section was removed, which may cause help sections to run together. Reintroduce a separator or adjust formatting for clarity.
    if len(cmds) > 0 {

help.go:55

  • [nitpick] The blank line before the flags section was removed, potentially reducing readability. Consider keeping a blank line or other visual separator.
    if len(flags) > 0 {

theme.go:54

  • The default light theme title color was changed from charmtone.Malibu to charmtone.Charple. Please confirm this color update is intentional or revert if it was a typo.
    Title:        charmtone.Charple,

@caarlos0 caarlos0 merged commit 05fa030 into colors Jun 8, 2025
6 of 18 checks passed
@caarlos0 caarlos0 deleted the name branch June 8, 2025 22:08
caarlos0 added a commit that referenced this pull request Jun 8, 2025
* feat: colors

* feat: new colorsscheme

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: update

* Update package name + various minor edits (#20)

* chore: rename package to fang

* fix: trim extra lines above commands and flags headers

* chore: capitalize README.md file

* chore: use Charple for light theme headers

* chore: example copy edits

* docs: update examples

* test: update golden files

* chore: lint

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: comments

* fix: improve theme

* docs: update

* fix: comment

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Christian Rocha <christian@rocha.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants