Skip to content

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 6, 2025

No description provided.

caarlos0 added 2 commits June 6, 2025 16:27
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 requested review from meowgorithm and Copilot June 6, 2025 19:43
@caarlos0 caarlos0 self-assigned this Jun 6, 2025
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new color scheme feature by extending the theme structure with new color fields and redefining default themes for dark and light modes. The changes include updates to the Theme struct (adding fields like Program, Command, and QuotedString), adjustments in theme handling in the settings, and updates to style rendering for command and quoted string display.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
theme.go Adds new color fields to Theme and defines DefaultThemeDark and DefaultThemeLight (with a minor comment mislabel).
serpentine.go Updates the settings to use a pointer for theme and adds a nil check for theme assignment.
help.go Adjusts style rendering in usage and error output, including handling for quoted strings.
go.mod Adds a new dependency for the charmtone package.
example/main.go Provides usage examples including quoted-string examples.
Comments suppressed due to low confidence (1)

theme.go:51

  • The comment on line 51 appears to be mislabelled as it precedes the definition of DefaultThemeLight. Please update it to correctly describe the default light theme.
// DefaultThemeDark is the default colorscheme.

Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some small edits in another PR, so let's merge that one first. I'll update images separately.

meowgorithm and others added 8 commits June 8, 2025 19:08
* chore: rename package to fang

* fix: trim extra lines above commands and flags headers

* chore: capitalize README.md file

* chore: use Charple for light theme headers

* chore: example copy edits
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit b8d999a into main Jun 8, 2025
18 checks passed
@caarlos0 caarlos0 deleted the colors branch June 8, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants