-
Notifications
You must be signed in to change notification settings - Fork 27
feat: new color scheme #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new color scheme feature by extending the theme structure with new color fields and redefining default themes for dark and light modes. The changes include updates to the Theme struct (adding fields like Program, Command, and QuotedString), adjustments in theme handling in the settings, and updates to style rendering for command and quoted string display.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
theme.go | Adds new color fields to Theme and defines DefaultThemeDark and DefaultThemeLight (with a minor comment mislabel). |
serpentine.go | Updates the settings to use a pointer for theme and adds a nil check for theme assignment. |
help.go | Adjusts style rendering in usage and error output, including handling for quoted strings. |
go.mod | Adds a new dependency for the charmtone package. |
example/main.go | Provides usage examples including quoted-string examples. |
Comments suppressed due to low confidence (1)
theme.go:51
- The comment on line 51 appears to be mislabelled as it precedes the definition of DefaultThemeLight. Please update it to correctly describe the default light theme.
// DefaultThemeDark is the default colorscheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have some small edits in another PR, so let's merge that one first. I'll update images separately.
* chore: rename package to fang * fix: trim extra lines above commands and flags headers * chore: capitalize README.md file * chore: use Charple for light theme headers * chore: example copy edits
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
No description provided.