Fix missing <tuple> include for std::tie in network_interface_info.h #4009
Conversation
|
Hi @rshrj, thanks for the contribution! I see that the linter is complaining about the include order. Could you make the suggested change? Thanks! |
328b896 to
a444b47
Compare
|
Hi @rshrj, since this PR is coming from an external fork, some of the CI steps could not be run for security reasons. Would you mind if I open a pull request including both of your PRs? I'll just carry your commits as-is; the only difference would be the PR is coming from a main repository branch, not a fork. |
Hi @xmkg. That explains it! Sure, I don't mind. Are you not supposed to fork this repository for contributions or are there different steps involved? |
Hi @rshrj, thanks for the confirmation :) It's absolutely fine to fork the repo, and it's the way how it's supposed to work with external contributors, but there are some obstacles on the CI side regarding how the configuration is being handled. There are some changes we need to make to accommodate the PR's coming from forks. It's in our roadmap, so hopefully we won't have to use workarounds in the future and make it easier for the contributors. |
ab399ad
This PR adds a missing
#include <tuple>tonetwork_interface_info.h, which is required for the use ofstd::tie.Without this include, builds fail on compilers/environments that do not implicitly include
<tuple>via transitive headers. For example, GCC on Debian 12 produces:Tested by successfully building the project in a clean Debian 12 dev container with GCC. No other changes.