Fix invalid macro definition in CMakeLists.txt #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rshrj, thanks for the contribution! Good catch, I wonder why it hasn't caused any trouble before. |
Seems like |
Actually, it's the opposite: journald is the default logger for Linux. According to the CMake documentation for add_compile_definitions, the command is supposed to strip the leading "-D" from the input, which is not happening in your case. I see that CMake 3.25.1 is the latest CMake version for the bookworm, so that figures. It's a nice addition (or should I say removal) regardless :) |
This was referenced Mar 27, 2025
ricab
approved these changes
Mar 27, 2025
ab399ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
src/platform/CMakeLists.txtwhereadd_compile_definitions()is used with a-Dprefix:This results in a malformed macro definition
-D-DMULTIPASS_JOURNALD_ENABLED, which causes a compiler error:The fix is to pass only the macro name, as
add_compile_definitions()automatically adds the-Dprefix:Tested in a clean Debian 12 environment using Make, where this issue was originally triggered.