Skip to content

[Backport stable/8.6] [Backport stable/8.7] fix: always take a snapshot after update, even without any migrations #36880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 15, 2025
Merged

[Backport stable/8.6] [Backport stable/8.7] fix: always take a snapshot after update, even without any migrations #36880

merged 8 commits into from
Aug 15, 2025

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #36847 to stable/8.6.

relates to

@lenaschoenburg @github-actions
fix: always take a snapshot after update, even without any migrations
8712468 
We shouldn't rely on the number of migrations, even if we only just
updated the version number, we must take a new snapshot.

(cherry picked from commit 81b7d07)
(cherry picked from commit 5c1d3cd)
@lenaschoenburg @github-actions
fix: allow snapshots without any processing
eaef27b 
Required so we can take an initial snapshot on startup when there's
nothing to process.

(cherry picked from commit 51a9883)
(cherry picked from commit b8077f2)
@lenaschoenburg @github-actions
fix: snapshot falls back to index and term 0 when nothing is processed
a694743 
(cherry picked from commit 0aa3d73)
@lenaschoenburg @github-actions
test: update succeeds without prior snapshot but may have one afterwards
7d709d2 
Now that we always take a snapshot after update, we can no longer
assert that we don't have one. We can still test that we can update
when we didn't have a snapshot before the update though.

(cherry picked from commit e935c20)
(cherry picked from commit 486ef14)
@lenaschoenburg @github-actions
test: don't assert that follower didn't take a snapshot
33b08c2 
(cherry picked from commit 070b783)
(cherry picked from commit 3f7ec36)
@lenaschoenburg @github-actions
test: expect a snapshot id
b59e5f5 
(cherry picked from commit fc54f3e)
(cherry picked from commit 3374825)
@lenaschoenburg @github-actions
test: only assert that a new snapshot is available after dataloss
7dff609 
We can't assert that a specific snapshot is present, the broker with
dataloss can take it's own snapshot after receiving one.

(cherry picked from commit 105e83a)
(cherry picked from commit 85bfbc0)
@lenaschoenburg @github-actions
fix: create some internal load to allow snapshots
b60f44f 
(cherry picked from commit ea88dcf)
@backport-action backport-action mentioned this pull request Aug 15, 2025
Merged
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label Aug 15, 2025
@camundait camundait enabled auto-merge August 15, 2025 19:16
@camundait camundait added this pull request to the merge queue Aug 15, 2025
Merged via the queue into stable/8.6 with commit fa10491 Aug 15, 2025
45 checks passed
@camundait camundait deleted the backport-36847-to-stable/8.6 branch August 15, 2025 19:32
houssain-barouni added a commit that referenced this pull request Aug 21, 2025
@houssain-barouni
Revert "[Backport stable/8.6] [Backport stable/8.7] fix: always take …
8d829a5 
…a snapshot after update, even without any migrations (#36880)"

This reverts commit fa10491, reversing
changes made to 93fdfa8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camundait camundait camundait approved these changes

Assignees

@lenaschoenburg lenaschoenburg

Labels
component/zeebe Related to the Zeebe component/team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@backport-action @camundait @lenaschoenburg