[Backport stable/8.7] fix: always take a snapshot after update, even without any migrations #36847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't rely on the number of migrations, even if we only just updated the version number, we must take a new snapshot. (cherry picked from commit 81b7d07)
npepinpe
approved these changes
Aug 15, 2025
Required so we can take an initial snapshot on startup when there's nothing to process. (cherry picked from commit 51a9883)
Now that we always take a snapshot after update, we can no longer assert that we don't have one. We can still test that we can update when we didn't have a snapshot before the update though. (cherry picked from commit e935c20)
(cherry picked from commit 070b783)
npepinpe
approved these changes
Aug 15, 2025
d69b242 to
075180b
Compare
075180b to
85bfbc0
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't rely on the number of migrations, even if we only just updated the version number, we must take a new snapshot.
(cherry picked from commit 81b7d07)
I also had to several other commits that adjusted tests.
The only new commit is 0aa3d73, somehow that wasn't necessary on main.