Fix wx-config usage #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Change CFLAGS to CXXFLAGS 3. Add binaries to clean target 4. Generate wxWidgets includes/ldflags/etc from wx-config
…ng included twice).
Also changed wx-config --cppflags to --cxxflags. I am not sure what the
difference is supposed to be, but --cppflags does not include -pthread.
…iles.
Moved it out of CXXFLAGS and into the command-line for the GUI objects.
It will no longer be invoked for non-GUI and crypto object files.
…lled.
WXINCLUDEPATHS and WXLIBS now assigned with '=' instead of ':='.
This means they are only evaluated on-demand, and they will never be
requested by 'make bitcoind', so it won't try to call wx-config.
glv2
referenced
this pull request
in glv2/peercoin
Apr 15, 2014
Relay OP_RETURN data TxOut implementation for Peershares
rdponticelli
pushed a commit
to Criptomonedas/bitcoin
that referenced
this pull request
Nov 26, 2014
dexX7
added a commit
to dexX7/bitcoin
that referenced
this pull request
Jun 25, 2015
5c34c70 UI: Fix bugs related to reinit'ing UI views on reorg (zathras-crypto) f62f8f8 UI: Reinit UI views when there is a reorg (zathras-crypto) 7183cf9 Undo example changes to listtransactions_MP to show walletTXIDCache PoC NOTE: @dexX7's changes to SP serialization do a much better job of improving listtransactions_MP performance. WalletTXIDCache is still early proof of concept, not ready for use as a source of truth for RPC data. (zathras-crypto) bec0f22 UI: Revert usage of walletTXIDCache in tx history NOTE: walletTXIDCache still proof of concept and not yet ready for usage as source of truth for UI data. (zathras-crypto) 2fd2045 UI: tradehistory - interpret_Transaction is bool (zathras-crypto) 6091aaf UI: Remove extra = in tradehistorydialog (thanks @dexX7) (zathras-crypto) c69c31f UI: Hide amount for trade cancel in overview recent (zathras-crypto) f54c1a5 UI: Clicking a recent Omni tx will take you to the transaction in history (zathras-crypto) b0f745f UI: Use struct instead of string for overview recent cache (thanks @dexX7) (zathras-crypto) 3735675 UI: Allow hiding of inactive trades in tradehistorydialog (zathras-crypto) c24e64a UI: Add 'hide inactive trades' checkbox to tradehistory form (zathras-crypto) 7b8526a PENDING: Don't add pending tx to the wallet cache until confirmed (zathras-crypto) 26c3e10 UI: Improve trade history invalid tx handling (zathras-crypto) eae65af UI: Give CheckWalletUpdate a force option & use it in pending (zathras-crypto) eb01d08 UI: MetaDEx cancel support in transaction history (zathras-crypto) b06db65 UI: Fix sendmpdialog global wallet balance (zathras-crypto) fbb9e6f UI: Add a pending transaction when sending a cancellation (zathras-crypto) 3648cc8 PENDING: Better support for metadex cancels (zathras-crypto) 29542e0 PENDING: Allow pending support for trade cancel txs (zathras-crypto) cb37c1a UI: Remove bits for listing cancel trades in trade history NOTE: Cancel transactions will not be listed as trades in trade history. To see what trades a cancel affected look at the cancel tx in transaction history. (zathras-crypto) 6a5f3f4 UI: Remove leftover printfs/test bypass of part cancel (zathras-crypto) 78cdcaf UI: Disable sorting while table data is updated (zathras-crypto) 45c4ab6 UI: Fix bad data update on part cancels (zathras-crypto) 4e8253e Don't notify about Omni events, while waiting (dexX7) bbb537c UI: Revert STO modification to txhistory (zathras-crypto) dc61e0c UI: Use wallet txid cache for history population (zathras-crypto) a3dc036 RPC: Revert STO changes to listtransactions_MP (zathras-crypto) a2cba93 WALLETCACHE: Remove STO receipts, not wallet transactions (zathras-crypto) 4838ddd RPC: Example usage of new cache with listtransactions_MP (zathras-crypto) 93ba3ca WALLETCACHE: Cache wallet txids for Omni transactions (zathras-crypto) 442e2ea UI: Fix cancelled w/partial matches appear as active trades in tradehistorydialog (zathras-crypto) 846839e UI: Create new objects to replace cells when updating data in tradehistorydialog NOTE: fixes "cannot insert an item that is already owned by another QTableWidget" error (zathras-crypto) a55290a UI: Fix MetaDEx dialog missed updates due to signalling changes (zathras-crypto) 880f5e6 UI: Add caching to overview recent transactions NOTE: Resizing window can result in a significant number of repaint actions, causing the same recent transactions to be repeatedly parsed. This commit ensures transactions are only parsed one and then added to a temporary cache. (zathras-crypto) c15999e UI: Overview page replace step with interpret_Transaction (zathras-crypto) 7f73c10 UI: Fix issue where alerts would be missed after signalling changes (zathras-crypto) 44b9022 UI: tidy up overview changes (zathras-crypto) 43d2466 UI: Override bitcoin transaction record for Omni transactions (zathras-crypto) c9d70e0 UI: Standardize invalid icon for recent transactions on overview (zathras-crypto) 9858f3b UI: Improve recent icon handling to display direction (zathras-crypto) ab71af2 UI: New icons for recent transactions on overview page (zathras-crypto) 2d46660 UI: missing icon (zathras-crypto) 09fbf96 UI: Support Omni transactions in overview recent NOTE: Very much a WIP (zathras-crypto) 0f04467 UI: Split metadex balance and order updates (zathras-crypto) a02bb8e UI: Add missing locks (thanks @dexX7) (zathras-crypto) 5a0b5b7 UI: Remove duplicate state signal (thanks @dexX7) (zathras-crypto) 958c385 PENDING: Only signal if pending was successful (zathras-crypto) 0c7708a UI: Add locks (thanks @dexX7) (zathras-crypto) 0df4c94 UI: MetaDEx dialog refresh can be state or balance triggered (zathras-crypto) 4451be7 UI: Minimize scope of updates to UI (zathras-crypto) bceb2a5 Move global_metadex_market into metadexdialog (dexX7) d2c08a4 UI: balancesDialog - use tally directly (thanks @dexX7) (zathras-crypto) 611f3e9 UI: Optimize balances updatePropSelector() (zathras-crypto) cb9320c Don't clear wallet property list each run of set_wallet_totals (zathras-crypto) 24004e0 UI: Add notification to status bar for transactions in pending map NOTE: this is for the pending map, so currently outbound transactions (zathras-crypto) bfd78d6 UI: Remove MetaDEx specific pending warning (zathras-crypto) ebf96ca UI: Add new icon for pending Omni transactions (zathras-crypto) 52160c2 UI: remove reliance on walletModel, no longer needed NOTE: It is no longer needed to hook into BTC balance change signals to indicate something might have changed on the Omni side. (zathras-crypto) 1418457 UI: Fix outbound transactions do not always reduce available balances (zathras-crypto) 2e2d954 UI: Wait for wallet to be loaded before initial set_wallet_totals call (zathras-crypto) f9bff48 UI: move alert check to the right place in overview page NOTE: oversight, setBalance hasn't been called per block for a long time (zathras-crypto) 325780b UI: Update wallet totals in block handler instead of multiple UI spots (zathras-crypto) 7d54ae4 UI: Cap scope of recent wallet txs at 500 by default (zathras-crypto) a0f3a14 UI: replace vector with set for wallet property list (thanks @dexX7) (zathras-crypto) 165ec4e UI: Use new feeCheck in send & metadex dialogs (zathras-crypto) 9942bce UI: fix missing change in omnicore.h for feecheck (zathras-crypto) 96a92c1 UI: add widgets for insufficient fee warnings on metadex dialog (zathras-crypto) 9049935 UI: redo feeCheck (zathras-crypto) 653b4fa UI: Remove commented code from IsMyAddress (zathras-crypto) 1117743 UI: Consolidate IsMyAddress & IsMyAddressSpendable NOTE: Avoids checking keystore twice per address (zathras-crypto) 3ee91fa UI: sort the global wallet property list after populating (zathras-crypto) f98db85 UI: missed one :) (zathras-crypto) 96c5725 UI: Fix a couple of nits based on @dexX7's feedback (with thanks!) (zathras-crypto) 890c24b UI: merge main & test eco global balance maps (zathras-crypto) c921513 UI: rewrite balancesdialog to better handle watch-only NOTE: wallet "totals" will no longer include watch-only balances, however watch-only balances will still be visible in the balances tab for a particular property and will be suffixed with "(watch-only)" (zathras-crypto) ac16c3c UI: fix bad duplicate check in set_wallet_totals (zathras-crypto) 7a15e8a UI: extern the new wallet property list (zathras-crypto) 96b2632 UI: Further optimize set_wallet_totals NOTE: It is not required to check the balance for each tally type for every property that exists in the state for each address. Using the tally itself is more efficient. (zathras-crypto) 4307c45 UI: Clean up set_wallet_totals NOTE: This has been changed to exclude watched addresses from the "Wallet Total" values shown. (zathras-crypto) c7b2618 Add IsMyAddressSpendable function and use it for send dialogs (zathras-crypto) 010457c UI: Add clientModel to MetaDEx dialog (subscribe to refreshOmniState signal) (zathras-crypto) 5c14761 UI: Add client model to trade history (fix lack of update on state change) (zathras-crypto) eb94cac UI: Fix broken error reporting on failed send (zathras-crypto)
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Sep 6, 2016
Fix compile error when --disable-wallet
8bitcoder
pushed a commit
to myriadcoin/myriadcoin
that referenced
this pull request
Jan 30, 2018
Update signverifymessagedialog.ui
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Feb 23, 2019
Update Japanese translation to upstream (1)
cryptapus
pushed a commit
to cryptapus/bitcoin
that referenced
this pull request
May 3, 2021
…ecoin Make release process docs refer to Namecoin
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a response to the other pull request by ojab. I didn't want to make a new pull request but I couldn't find another way to do it.
The last comment by tcatm was "This patch works ... outputs annoying errors (wx-config not found) when building bitcoind. Can you fix that?"
I have fixed it in this branch (it no longer tries to include wx at all for any non-GUI files), and updated the readme to say it's OK to use wx 2.9.1 now. It now builds bitcoind just fine even if your system has no trace of wxWidgets.