Use wx-config for INCLUDEPATHS/WXLIBS #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should use $(...) instead of `` (like it's done in makefile.osx), also see http://www.electric-cloud.com/blog/2009/03/23/makefile-performance-shell/ |
2. Change CFLAGS to CXXFLAGS 3. Add binaries to clean target 4. Generate wxWidgets includes/ldflags/etc from wx-config
|
Ok, rewrited. |
|
This patch works great for GUI builds but outputs annoying errors (wx-config not found) when building bitcoind. Can you fix that? |
|
The problem is that the makefile is using ":=" instead of "=" to assign those WXINCLUDEPATHS/WXLIBS variables. This calls wx-config whether it uses it or not. But even fixing that is insufficient. I have put up a new pull request which fixes this issue. |
FuzzyBearBTC
referenced
this pull request
in FuzzyBearBTC/peercoin
Mar 30, 2014
Update main.cpp decrease PoW difficulty
kac-
pushed a commit
to kac-/peercoin-ce
that referenced
this pull request
Jun 10, 2014
pb invoice 20140515
dexX7
pushed a commit
to dexX7/bitcoin
that referenced
this pull request
May 22, 2015
…tusCleanup METADEX: Remove duplicate function for determining if metadex trade open
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
fix dseg logging
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Jul 22, 2016
Fix for rare data.size() assertion
classesjack
pushed a commit
to classesjack/bitcoin
that referenced
this pull request
Jan 2, 2018
Fix witness merkleroot (issue 50)
CryptAxe
pushed a commit
to CryptAxe/bitcoin
that referenced
this pull request
Mar 11, 2018
Updated VoteView, and allow voting with Bitcoins on the testnet.
CryptAxe
added a commit
to CryptAxe/bitcoin
that referenced
this pull request
Mar 11, 2018
Merge pull request bitcoin#52 from CryptAxe/master
effectsToCause
added a commit
to vericoin/vericoin
that referenced
this pull request
Jun 22, 2018
Merge pull request bitcoin#55 from vericoin/master
velesnetwork
referenced
this pull request
in velescore/veles
Jan 12, 2020
Losangelosgenetics
pushed a commit
to Losangelosgenetics/bitcoin
that referenced
this pull request
Mar 12, 2020
Update compatibility list
satindergrewal
pushed a commit
to chips-blockchain/chipschain
that referenced
this pull request
Jun 22, 2021
Fixing windows x64 cross-compilation bitcoin#52 as suggested by DeckerSU
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
Just separating out the two white papers. Make it clearer.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes bitcoin buildable with non-debug/shared/etc wxWidgets without makefile changes.