Skip to content

Conversation

theStack
Copy link
Contributor

This PR is a follow-up to #30856, as suggested in comment #30856 (comment). With the scripted diff, review should be fairly trivial, but it could still be seen as controversial due to the large number of files (78 in total) being touched.

@DrahtBot
Copy link
Contributor

DrahtBot commented Sep 20, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake
Stale ACK hebasto, theuni, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30860 (test: autogenerate bash completion by BrandonOdiwuor)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@theStack theStack changed the title scripted-diff: drop config/ subdir for bitcoin-config.h build: scripted-diff: drop config/ subdir for bitcoin-config.h Sep 20, 2024
@hebasto
Copy link
Member

hebasto commented Sep 23, 2024

Concept ACK, given the early stage of the current release cycle and the presence of only a single conflicting PR.

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 33adc75
(master)
commit 6fbeea9
(master and this pull)
SHA256SUMS.part 89575c9e7a506f16... 7d9eb64ae40835ea...
*-aarch64-linux-gnu-debug.tar.gz 83ab33a38bceb4ee... 41bc30119e8bc20b...
*-aarch64-linux-gnu.tar.gz a232fbbe572e68ac... 614efa1d09263812...
*-arm-linux-gnueabihf-debug.tar.gz a84d1b299dbf3220... e4507ed5811fcdca...
*-arm-linux-gnueabihf.tar.gz 652caee91e88f2d5... 9a31cde0c8b9e7d5...
*-arm64-apple-darwin-unsigned.tar.gz 27cc00b2fdbc1374... 5e705ebce9c06c56...
*-arm64-apple-darwin-unsigned.zip eddb4c85626a1831... 840d26cd3693c7f4...
*-arm64-apple-darwin.tar.gz 715c86a8f85d1d53... 4d64b0740d685f52...
*-powerpc64-linux-gnu-debug.tar.gz 55377f5b1dc78cf2... 0f9a98213352e252...
*-powerpc64-linux-gnu.tar.gz 120675f298ddd59f... 57ad0789c19df2be...
*-riscv64-linux-gnu-debug.tar.gz 57a64f32ea69220f... 4b40f2c8a64eb511...
*-riscv64-linux-gnu.tar.gz a3a52fd585611a4d... 6dd7f9f8ef783a46...
*-x86_64-apple-darwin-unsigned.tar.gz 4d86d57f70cd9645... 1da632e8e3f95017...
*-x86_64-apple-darwin-unsigned.zip d71ea11af306a495... 1fd0de4ac63ce56f...
*-x86_64-apple-darwin.tar.gz e8792a381d01b322... 805a46c5e705a00f...
*-x86_64-linux-gnu-debug.tar.gz e3f5849a37744ea5... 6be83655793a7da6...
*-x86_64-linux-gnu.tar.gz 8a648bbea3d3cf2a... 23e1ce0b57def6da...
*.tar.gz 30492a8d47e39455... 9d87da8057c0911a...
guix_build.log a1cc625d9bfe4c01... bc87f4ce5784f4d4...
guix_build.log.diff 9f924f275b69d8bb...

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, and scripted-diff lgtm ACK.

Bikeshed: How about bitcoin-build-config.h for symmetry with bitcoin-build-info.h?

@theStack theStack force-pushed the 202409-build-drop_config_subdir branch from ed260c3 to 09b0161 Compare September 23, 2024 22:49
@theStack
Copy link
Contributor Author

theStack commented Sep 23, 2024

Bikeshed: How about bitcoin-build-config.h for symmetry with bitcoin-build-info.h?

Sounds good to me, done. Both the scripted diff and the patch are now a bit larger, as also some comments/strings have to be adapted, and the .h.in file needs to be renamed as well, but review should still be simple.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 09b0161.

@DrahtBot DrahtBot requested a review from theuni September 24, 2024 10:27
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 09b0161

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 09b0161

@fanquake
Copy link
Member

Guix Build

a78d6d030a78972bf2ebab6d3599a3ce8b325e5422e192ab97d65966f3ee0ae4  guix-build-09b0161c4a25/output/aarch64-linux-gnu/SHA256SUMS.part
a3ff2330715466bef18e536f5ef4c6c00c9a359e11f896b3afade7364b4e40eb  guix-build-09b0161c4a25/output/aarch64-linux-gnu/bitcoin-09b0161c4a25-aarch64-linux-gnu-debug.tar.gz
dcedb6cea8f7799d34d64b9a73deda40452887898a44e6b5a2048b7ebf304924  guix-build-09b0161c4a25/output/aarch64-linux-gnu/bitcoin-09b0161c4a25-aarch64-linux-gnu.tar.gz
aa2b1c6e8fc747872bdb1c2cbbf5622c96736781a98cc5e6209460d8c0454891  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/SHA256SUMS.part
1964e1c6a54a7dfe462a2f28bf7e4d05e66baf32b1193d8b3314989e5de129de  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/bitcoin-09b0161c4a25-arm-linux-gnueabihf-debug.tar.gz
d2922f38049d5907ecc5120305673e0f4e3cd23b6a129bc5fd29b420e0f7e5aa  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/bitcoin-09b0161c4a25-arm-linux-gnueabihf.tar.gz
05d473e74b2707834f0147f3e42a8e328f40fe8ba0a2df31d3d3e36656a07296  guix-build-09b0161c4a25/output/arm64-apple-darwin/SHA256SUMS.part
ddeb1a9ef5ea95481aedf6eb6f3fda7829711cac5f4c0e36f8e977fc3391cda4  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin-unsigned.tar.gz
e502cee115489c03e0c38f76fde5dfeba72266046eb35bc9b1a0fbe72670fd51  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin-unsigned.zip
66ab20ebf87a11b41149844ae1fc0c148d60059027917ee835547d853bb58b53  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin.tar.gz
b7dad4ad285c4eecb11dab43e01435da206aeb3dbbd264a51575d0300b5bec6d  guix-build-09b0161c4a25/output/dist-archive/bitcoin-09b0161c4a25.tar.gz
ad7c3270dfe8955b9a518b081d6c4c45322f8627742be111d95c1c7891aa34de  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/SHA256SUMS.part
434208f50ae66ce5eb9df81337586f4e69f39228fd620a8570390506eccacb45  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/bitcoin-09b0161c4a25-powerpc64-linux-gnu-debug.tar.gz
45fba4d2324a8bbe543e062802652aa2518475ae92a62bb053e94506231dc268  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/bitcoin-09b0161c4a25-powerpc64-linux-gnu.tar.gz
d09cddd15788c640c018c82d066386ed41b3a79f22b311ef5fab210afe06ca8a  guix-build-09b0161c4a25/output/riscv64-linux-gnu/SHA256SUMS.part
3f68083240793dc897c25a303748af989e87b99e3bae7cf6370339a42b2ff4b0  guix-build-09b0161c4a25/output/riscv64-linux-gnu/bitcoin-09b0161c4a25-riscv64-linux-gnu-debug.tar.gz
c1c66255621ffe348113c7b57ff0432cd420a10dd008c3dfcc6c0caf787b7618  guix-build-09b0161c4a25/output/riscv64-linux-gnu/bitcoin-09b0161c4a25-riscv64-linux-gnu.tar.gz
99988b30ae435a6e5155631f683f1934ee5f3e3e2d7655fb4034c9bea2537fd5  guix-build-09b0161c4a25/output/x86_64-apple-darwin/SHA256SUMS.part
5ce76d80d52e5b9c44599b7189276f81beda58137f0e232d9f22116e6a44289f  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin-unsigned.tar.gz
8c195e6ef2ef8a6073381d08e76746e9109b641041e7c7efd7f9843c88609160  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin-unsigned.zip
851914c98027dbd4219d94b81d337e34f3509ae986a3dd2499f6844615e4f284  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin.tar.gz
268ddadba8dd0e37e344e125ca2a37e6ee9945b5ab707968f65997031ce09990  guix-build-09b0161c4a25/output/x86_64-linux-gnu/SHA256SUMS.part
1e90e024edf115c25795d73ab1fd328bc4e65f32240ca3ac3a1f0b3299bb7960  guix-build-09b0161c4a25/output/x86_64-linux-gnu/bitcoin-09b0161c4a25-x86_64-linux-gnu-debug.tar.gz
176429859b3f7cc295b7361a4692fe5f5927357f5762982c1cbb2bc412447cb4  guix-build-09b0161c4a25/output/x86_64-linux-gnu/bitcoin-09b0161c4a25-x86_64-linux-gnu.tar.gz
786f56a48dda53fa3a6387114d131018e36e1955fc771ee33e61f7c4c85ff480  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/SHA256SUMS.part
04eb6e213da49d1232ab6312e42c5b2f901dcad33f72d3cbc77e2310295cddbf  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-debug.zip
bc2a8d194cd12afd801f8bde5f0d384006b66806705b8fa74f474a8777a1cdc9  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-setup-unsigned.exe
af36eedcf415b94e8e6323fd897710d0ac51efdc6eddb580a85d38992abbced3  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-unsigned.tar.gz
930a85398e43ee9e9af1d1cdccb1f1c472114167995cc15a8be1e3961cfe01e4  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64.zip

@fanquake
Copy link
Member

bitcoin/src/common/netif.cpp:5:10: fatal error: 'config/bitcoin-config.h' file not found
    5 | #include <config/bitcoin-config.h> // IWYU pragma: keep
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed.
Debug: https://github.com/bitcoin/bitcoin/runs/30553100469

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

  • Possibly due to a silent merge conflict (the changes in this pull request being
    incompatible with the current code in the target branch). If so, make sure to rebase on the latest
    commit of the target branch.

  • A sanitizer issue, which can only be found by compiling with the sanitizer and running the
    affected test.

  • An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

…tcoin-build-config.h

Follow-up for PR bitcoin#30856, commit 0dd6625.

-BEGIN VERIFY SCRIPT-
sed -i "s|config/bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l config/bitcoin-config\.h)
sed -i "s|bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l "bitcoin-config\.h" ./src ./test ./cmake)
git mv ./cmake/bitcoin-config.h.in ./cmake/bitcoin-build-config.h.in
-END VERIFY SCRIPT-
@theStack theStack force-pushed the 202409-build-drop_config_subdir branch from 09b0161 to 882f736 Compare October 10, 2024 10:40
@theStack
Copy link
Contributor Author

Rebased on master and added another commit fixing the outdated comment in the linter (#30937 (comment)).

@fanquake
Copy link
Member

Guix Build:

9cf65a99fa046a1a3acbee14d6dec658b9fe7f4e55a4b6f50d063ebb4029e3eb  guix-build-882f736d0a60/output/aarch64-linux-gnu/SHA256SUMS.part
46780332298b988bc9b4c2903d077f49978dc92250cf5221557ce4459383b18e  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu-debug.tar.gz
72362b6f0394f4b8b1e69e4520c892d5b3e9f3d86788c8f0ee59f2b0d9e51717  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu.tar.gz
c4b5294efed908afb3458d1af340c9d2f77be84e0a9db93f626bad4590fe3fbe  guix-build-882f736d0a60/output/arm-linux-gnueabihf/SHA256SUMS.part
e9d201fc4f74fa77b038ca165858efde284f82e8e004301290c3c0d61875f1c1  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf-debug.tar.gz
8cd166df49767e948a2f827e148ab16f57c6910a35fe6b39ff3373e9c46cb936  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf.tar.gz
f9ac382c47e7e17b4ed6a0e0666c894967dcda4289a139e9d41e88d78b4f8ee6  guix-build-882f736d0a60/output/arm64-apple-darwin/SHA256SUMS.part
cdfd080d9b6a2e8f9f83a6f51c8f7db0e77d97a3f3ed4ecd1aab6293805db664  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.tar.gz
80f1a45978a17e72042e9e9cd02972ceb5eabfaa04b4a1dbbb83a8710cff64a0  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.zip
7f11308b9981b417be87029eb0a04aad36335874f0c1e7e5101a2161f3d62d7c  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin.tar.gz
32ee2152bf29b81e8c40dbd7c5821b646c498447f63d51ca9fbe414dc485bec0  guix-build-882f736d0a60/output/dist-archive/bitcoin-882f736d0a60.tar.gz
530692b5ce8dd83150e838a6e2e4fa042662ee688db79d874e50110de23987f2  guix-build-882f736d0a60/output/powerpc64-linux-gnu/SHA256SUMS.part
06810c70111b01ef998031a4fe1b5d661a7b89287f2f36e64e9991b38aac99e8  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu-debug.tar.gz
fbefb433c08ea43f0ba3095307ed0981bd47e2954799eca23eb9f7e7bb78cfab  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu.tar.gz
e605fcdfe071b4b504a9033c175f3d9651dffb3ef959fcc0f34082dd2815cc3d  guix-build-882f736d0a60/output/riscv64-linux-gnu/SHA256SUMS.part
1104a13281c11351b0672a8fee0384d9fd9b2becfe1adc168eda07c807edd5a8  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu-debug.tar.gz
ef1c20cf3b798b9cd6d05a7ade98f4c3b8f0e7afb9a139e5975d204f8aa58985  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu.tar.gz
9eeb7155477ec4db1abd308a9a036945c442f11f7ed6aa52ea9a1b825babe57b  guix-build-882f736d0a60/output/x86_64-apple-darwin/SHA256SUMS.part
c78b42f3aa52bb424e7e8aad650343e582a36ab00b5dc84c3e922c99470be7f7  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.tar.gz
04f78c2e0674e9ff6a1358b4322b045489940925c37c504503c8a765b19a1603  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.zip
66d5a64c486eefd899e37a29a1aabc53fb8ba33f46bb5cb83399db8135470ba9  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin.tar.gz
f4d169df64d85d835b0baa46d12b2992dbf1a1bfdca5a136c94f7794b11df28a  guix-build-882f736d0a60/output/x86_64-linux-gnu/SHA256SUMS.part
60c34fcd5b5fa08afcc3a7ee65a8d820820a1af9f42f731ec8422e6db458d616  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu-debug.tar.gz
31135e0adbeb59f0abe78351a7c260aaf02d3206a40b26dfda4b20d8b6919627  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu.tar.gz
c8e17374b9e6395215e1b2fba46087c6e1b662f5cae3cd6a532cebc0810ffcf9  guix-build-882f736d0a60/output/x86_64-w64-mingw32/SHA256SUMS.part
ef9b885e8a28f02bf5fd904aaac1a6a855abe9a1c460f879d510e34e759bf18f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-debug.zip
f7f5d508293ab7981b32717285e34206acbf7d2aaac01460d6183f9ff767c877  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-setup-unsigned.exe
af63e56853250b509ab4cdc63b24b195d176d4a4e943ec8bb04b58ca559bf750  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-unsigned.tar.gz
0b4810fea2c99c2c23bc2edea341b06df19070e9b4e31d47aa8ddf22ca98018f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64.zip

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 882f736

@fanquake fanquake merged commit 9f45062 into bitcoin:master Oct 10, 2024
16 checks passed
@theStack theStack deleted the 202409-build-drop_config_subdir branch October 10, 2024 12:36
@TheCharlatan
Copy link
Contributor

Post-merge ACK 882f736

Guix build (aarch64):

9cf65a99fa046a1a3acbee14d6dec658b9fe7f4e55a4b6f50d063ebb4029e3eb  guix-build-882f736d0a60/output/aarch64-linux-gnu/SHA256SUMS.part
46780332298b988bc9b4c2903d077f49978dc92250cf5221557ce4459383b18e  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu-debug.tar.gz
72362b6f0394f4b8b1e69e4520c892d5b3e9f3d86788c8f0ee59f2b0d9e51717  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu.tar.gz
c4b5294efed908afb3458d1af340c9d2f77be84e0a9db93f626bad4590fe3fbe  guix-build-882f736d0a60/output/arm-linux-gnueabihf/SHA256SUMS.part
e9d201fc4f74fa77b038ca165858efde284f82e8e004301290c3c0d61875f1c1  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf-debug.tar.gz
8cd166df49767e948a2f827e148ab16f57c6910a35fe6b39ff3373e9c46cb936  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf.tar.gz
f9ac382c47e7e17b4ed6a0e0666c894967dcda4289a139e9d41e88d78b4f8ee6  guix-build-882f736d0a60/output/arm64-apple-darwin/SHA256SUMS.part
cdfd080d9b6a2e8f9f83a6f51c8f7db0e77d97a3f3ed4ecd1aab6293805db664  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.tar.gz
80f1a45978a17e72042e9e9cd02972ceb5eabfaa04b4a1dbbb83a8710cff64a0  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.zip
7f11308b9981b417be87029eb0a04aad36335874f0c1e7e5101a2161f3d62d7c  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin.tar.gz
32ee2152bf29b81e8c40dbd7c5821b646c498447f63d51ca9fbe414dc485bec0  guix-build-882f736d0a60/output/dist-archive/bitcoin-882f736d0a60.tar.gz
530692b5ce8dd83150e838a6e2e4fa042662ee688db79d874e50110de23987f2  guix-build-882f736d0a60/output/powerpc64-linux-gnu/SHA256SUMS.part
06810c70111b01ef998031a4fe1b5d661a7b89287f2f36e64e9991b38aac99e8  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu-debug.tar.gz
fbefb433c08ea43f0ba3095307ed0981bd47e2954799eca23eb9f7e7bb78cfab  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu.tar.gz
e605fcdfe071b4b504a9033c175f3d9651dffb3ef959fcc0f34082dd2815cc3d  guix-build-882f736d0a60/output/riscv64-linux-gnu/SHA256SUMS.part
1104a13281c11351b0672a8fee0384d9fd9b2becfe1adc168eda07c807edd5a8  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu-debug.tar.gz
ef1c20cf3b798b9cd6d05a7ade98f4c3b8f0e7afb9a139e5975d204f8aa58985  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu.tar.gz
9eeb7155477ec4db1abd308a9a036945c442f11f7ed6aa52ea9a1b825babe57b  guix-build-882f736d0a60/output/x86_64-apple-darwin/SHA256SUMS.part
c78b42f3aa52bb424e7e8aad650343e582a36ab00b5dc84c3e922c99470be7f7  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.tar.gz
04f78c2e0674e9ff6a1358b4322b045489940925c37c504503c8a765b19a1603  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.zip
66d5a64c486eefd899e37a29a1aabc53fb8ba33f46bb5cb83399db8135470ba9  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin.tar.gz
f4d169df64d85d835b0baa46d12b2992dbf1a1bfdca5a136c94f7794b11df28a  guix-build-882f736d0a60/output/x86_64-linux-gnu/SHA256SUMS.part
60c34fcd5b5fa08afcc3a7ee65a8d820820a1af9f42f731ec8422e6db458d616  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu-debug.tar.gz
31135e0adbeb59f0abe78351a7c260aaf02d3206a40b26dfda4b20d8b6919627  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu.tar.gz
c8e17374b9e6395215e1b2fba46087c6e1b662f5cae3cd6a532cebc0810ffcf9  guix-build-882f736d0a60/output/x86_64-w64-mingw32/SHA256SUMS.part
ef9b885e8a28f02bf5fd904aaac1a6a855abe9a1c460f879d510e34e759bf18f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-debug.zip
f7f5d508293ab7981b32717285e34206acbf7d2aaac01460d6183f9ff767c877  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-setup-unsigned.exe
af63e56853250b509ab4cdc63b24b195d176d4a4e943ec8bb04b58ca559bf750  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-unsigned.tar.gz
0b4810fea2c99c2c23bc2edea341b06df19070e9b4e31d47aa8ddf22ca98018f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge ACK 882f736.

@Sjors Sjors mentioned this pull request Oct 16, 2024
Sjors added a commit to Sjors/bitcoin that referenced this pull request Oct 16, 2024
TheCharlatan added a commit to TheCharlatan/rust-bitcoinkernel that referenced this pull request Nov 2, 2024
…47757ea3b

1047757ea3b kernel: Add pure kernel bitcoin-chainstate
c568fdf75fd kernel: Add block index utility functions to C header
0f1da1dcba5 kernel: Add function to read block undo data from disk to C header
45af559c9f6 kernel: Add functions to read block from disk to C header
2a7f8a8240c kernel: Add function for copying  block data to C header
b19f5336c03 kernel: Add functions for the block validation state to C header
9c0ffa913f4 kernel: Add validation interface to C header
a93318c6152 kernel: Add interrupt function to C header
51053f33720 kernel: Add import blocks function to C header
6b0ada2af42 kernel: Add chainstate load options for in-memory dbs in C header
34427bfa9c7 kernel: Add options for reindexing in C header
ca57311c969 kernel: Add block validation to C header
44156d84838 Kernel: Add chainstate loading to kernel C header
2cee46cdcc1 kernel: Add chainstate manager object to C header
7102c7ae45e kernel: Add notifications context option to C header
ed628a2a3c4 kerenl: Add chain params context option to C header
27643297ff7 kernel: Add kernel library context object
2ba22cf3f90 kernel: Add logging to kernel library C header
873874c03e9 kernel: Introduce initial kernel C header API
d94adc7270b Merge bitcoin/bitcoin#29702: fees: Remove CLIENT_VERSION serialization
7290bc61c00 Merge bitcoin/bitcoin#31078: build: Fix kernel static lib component install
68f29b24907 Merge bitcoin/bitcoin#31141: doc: Make list of targets in depends README consistent
e9b95665eea Merge bitcoin/bitcoin#31046: init: Some small chainstate load improvements
b8c821cc1ea Merge bitcoin/bitcoin#30724: test: add test for specifying custom pidfile via `-pid`
a0c9595810c doc: Make list of targets in depends README consistent
fa1c5cc9df1 fees: Log non-fatal errors as [warning], instead of info-level
ffe4261cb06 Merge bitcoin/bitcoin#30935: ci: Approximate MAKEJOBS in image build phase
28ce159bc32 Merge bitcoin/bitcoin#30183: rpc: net: follow-ups for #30062
684873931b3 Merge bitcoin/bitcoin#26334: Add Signet and testnet4 launch shortcuts for Windows
9b0e2598089 Merge bitcoin/bitcoin#31121: guix: Enable CET for `glibc` package
d9f8dc64534 Merge bitcoin/bitcoin#31097: validation: Improve input script check error reporting
a16917fb598 rpc, net: improve `mapped_as` doc for getrawaddrman/getpeerinfo
563c4d29268 Merge bitcoin/bitcoin#31105: Update libmultiprocess library
0e9f20625a1 Merge bitcoin/bitcoin#31063: lint: commit-script-check.sh: echo to stderr
e8f72aefd20 Merge bitcoin/bitcoin#29877: tracing: explicitly cast block_connected duration to nanoseconds
86e2a6b749c [test] A non-standard transaction which is also consensus-invalid should return the consensus error
4d3da08d1b9 guix: Enable CET for `glibc` package
a38603456e9 Merge bitcoin/bitcoin#31100: doc: remove dependency install instructions from win docs
90b405516f7 Update libmultiprocess library
479715e9db0 Merge bitcoin/bitcoin#30996: doc: update signet documentation related to build directories
99e041f86fd Merge bitcoin/bitcoin#31099: doc: drop macOS LLVM install instructions
21e2f06a1cc Merge bitcoin/bitcoin#31067: test: Print CompletedProcess object on error
184f12c1542 doc: remove dependency install instructions from win docs
dea9fb9a8b8 Merge bitcoin/bitcoin#30093: optimization: reserve memory allocation for transaction inputs/outputs
79aa8280b2e doc: drop LLVM install instructions
2123c94448e Merge bitcoin/bitcoin#30527: Bump python minimum supported version to 3.10
538ccaed004 Merge bitcoin/bitcoin#31048: build: Bump minimum supported macOS to 13.0
f859ff8a4e9 [validation] Improve script check error reporting
ddddbac9c10 fees: Pin required version to 149900
fa5126adcb1 fees: Pin "version that wrote" to 0
0ca1d1bf69c Merge bitcoin/bitcoin#31092: doc: fuzz: remove Honggfuzz NetDriver instructions
d823ba6e20b doc: fuzz: remove Honggfuzz NetDriver instructions
15563d3388e Merge bitcoin/bitcoin#30859: doc: cmake: prepend "build" to functional/test_runner.py
2ac5ba24bf0 Merge bitcoin/bitcoin#31083: doc: add doxygen for m_args in tests
a0e089a71dc build: Bump minimum supported macOS to 13.0
1fe1b3ba8e9 doc: doxygen comment for m_args usage in tests
82e16e69832 cmake: Refactor install kernel dependencies
42e62779873 build: Add static libraries to Kernel install component
e64b2f1a16e doc: cmake: prepend and explain "build/" where needed
48cf3da6360 Merge bitcoin/bitcoin#30970: build: Add missing USDT header dependency to kernel
d8b835cf18c Merge bitcoin/bitcoin#31070: contrib: fix typos in check-deps.sh
da8824ba301 Fix typos in check-deps.sh
fa43c4f93ca test: Print CompletedProcess object on error
489e5aa3a29 Merge bitcoin/bitcoin#30857: cluster mempool: extend DepGraph functionality
9f45062b9b0 Merge bitcoin/bitcoin#30937: build: scripted-diff: drop config/ subdir for bitcoin-config.h
882f736d0a6 doc: lint: correct outdated comment (s/Makefile.am/CMakeLists.txt/)
1786be7b4a5 scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
0c2c3bb3f5c Merge bitcoin/bitcoin#30955: Mining interface: getCoinbaseMerklePath() and submitSolution()
9909a34d794 Merge bitcoin/bitcoin#30992: doc: update IBD requirements in doc/README.md
fac6cfe5ac0 lint: commit-script-check.sh: echo to stderr
5fb94550638 Merge bitcoin/bitcoin#31058: refactor: include the proper header rather than forward-declaring RemovalReasonToString
e569eb8d917 Merge bitcoin/bitcoin#30885: scripted-diff: Modernize nLocalServices naming
31cc5006c3d init: Return fatal failure on snapshot validation failure
8f1246e8338 init: Improve chainstate init db error messages
5837e3463fe Merge bitcoin/bitcoin#30967: refactor: Replace g_genesis_wait_cv with m_tip_block_cv
ca2e4ba352c refactor: include the proper header rather than forward-declaring RemovalReasonToString
a9f6a57b691 Merge bitcoin/bitcoin#30920: test: Remove 0.16.3 test from wallet_backwards_compatibility.py
fa71bedf860 ci: Approximate MAKEJOBS in image build phase
03696bb1bd5 Merge bitcoin/bitcoin#31045: ci: Add missing -DWERROR=ON to test-each-commit
56093565bbe Merge bitcoin/bitcoin#31018: test: Treat exclude list warning as failure in CI
bb47b5a6576 Merge bitcoin/bitcoin#31038: test: Fix copy-paste in wallet/test/db_tests ostream operator
3fecf36c7b3 Merge bitcoin/bitcoin#31056: ci: Double ctest timeout
3c4a9419dbe Merge bitcoin/bitcoin#31013: depends: For mingw cross compile use -gcc-posix to prevent library conflict
5d5cc021ce3 Merge bitcoin/bitcoin#31051: test: remove unused code from `script_tests`
caf44e500eb Merge bitcoin/bitcoin#31008: depends: Print ready-to-use `--toolchain` option for CMake invocation
fa5ebc99207 ci: Double ctest timeout
0b3ec8c59b2 clusterlin: remove Cluster type
1c24c625105 clusterlin: merge two DepGraph fuzz tests into simulation test
0606e66fdbb clusterlin: add DepGraph::RemoveTransactions and support for holes in DepGraph
75b5d42419e clusterlin: make DepGraph::AddDependency support multiple dependencies at once
abf50649d13 clusterlin: simplify DepGraphFormatter::Ser
eaab55ffc81 clusterlin: rework DepGraphFormatter::Unser
5901cf7100a clusterlin: abstract out DepGraph::GetReduced{Parents,Children}
e0287bc4b2d test: remove unused code from script_tests
62e45167221 Merge bitcoin/bitcoin#31026: ci: set a ctest test timeout of 1200 (20 minutes)
cd093049dda init: Remove incorrect comment about shutdown condition
635e9f85d76 init: Remove misleading log line when user chooses not to retry
fa1cffacae6 ci: Install missing nproc in macos task
faf7a2bccc7 ci: Add missing -DWERROR=ON to test-each-commit
56aad83307e ci: set a ctest timeout of 1200 (20 minutes)
1b707146717 Merge bitcoin-core/gui#840: qt6: Handle different signatures of `QANEF::nativeEventFilter`
720ce880a35 init: Improve comment describing chainstate load retry behaviour
baea842ff18 init: Remove unneeded argument for mempool_opts checks
ec58dfe8f74 Merge bitcoin/bitcoin#31010: cmake: Avoid hardcoding Qt's major version in Find module / variable names
5fe6878b5f7 Merge bitcoin-core/gui#836: Fix display issues for IPv6 proxy setup in Options Dialog  (UI only, no functionality impact)
f50557f5d36 test: Fix copy-paste in db_tests ostream operator
5ea335a97f8 Merge bitcoin/bitcoin#30793: rpc: add getorphantxs
76e2e8aabd8 Merge bitcoin/bitcoin#31035: doc: Archive 28.0 release notes
f019fcec412 doc: Archive 28.0 release notes
80761afced1 qt6: Handle different signatures of `QANEF::nativeEventFilter`
51c698161b5 Merge bitcoin-core/gui#837: qt6: Fix linking when configured with `-DENABLE_WALLET=OFF`
4be785b3e33 Merge bitcoin-core/gui#839: qt6, test: Handle deprecated code
f117f3f7473 Merge bitcoin-core/gui#838: qt6: Handle deprecated `QLocale::nativeCountryName`
5625840c11d qt6, test: Handle deprecated `QVERIFY_EXCEPTION_THROWN`
772928a13c2 Merge bitcoin/bitcoin#30982: docs: Add instructions on how to self-sign bitcoin-core binaries for macOS
27709f51ee0 docs: Add instructions on how to self-sign bitcoin-core binaries for macOS
cfb59da4b3b Merge bitcoin/bitcoin#30980: fuzz: fix bug in p2p_headers_presync harness
dda2613239b Merge bitcoin/bitcoin#30929: log: Enforce trailing newline
e0ae9c14c4e Merge bitcoin/bitcoin#31011: refactor: move util/pcp and util/netif to common/
98c1536852d test: add getorphantxs tests
93f48fceb7d test: add tx_in_orphanage()
34a9c10e8cd rpc: add getorphantxs
f511ff3654d refactor: move verbosity parsing to rpc/util
36a6d4b0078 doc: update IBD requirements in doc/README.md
fa6d14eacb2 test: Treat exclude list warning as failure in CI
6a370435526 Merge bitcoin/bitcoin#31007: doc: add testnet4 section header for config file
70910eb2ecb Merge bitcoin/bitcoin#31016: test: add missing sync to feature_fee_estimation.py
532491faf1a net: add GetOrphanTransactions() to PeerManager
91b65adff2a refactor: add OrphanTxBase for external use
a1576edab35 test: add missing sync to feature_fee_estimation.py
ae56b3230b2 depends: For mingw cross compile use -gcc-posix to prevent library conflict
fd38711217c ci: make CI job fail when check-deps.sh script fails
d51edecddcb common: move pcp.cpp and netif.cpp files from util to common library since they depend on netaddress.cpp
61cdb1c9d83 doc: add testnet4 section header for config file
deacf3c7cd6 cmake: Avoid hardcoding Qt's major version in Find module
605926da0ab depends: Print ready-to-use `--toolchain` option for CMake invocation
fa2b7d8d6b3 Remove redundant unterminated-logprintf tidy check
bbbb2e43ee9 log: Enforce trailing newline, Remove redundant m_started_new_line
fa22e5c430a refactor: Remove dead code that assumed tip == nullptr
fa2e4439652 refactor: Replace g_genesis_wait_cv with m_tip_block_cv
fa7f52af1a4 refactor: Use wait_for predicate to check for interrupt
5ca28ef28bc refactor: Split up NodeContext shutdown_signal and shutdown_request
fad8e7fba7b bugfix: Mark m_tip_block_cv as guarded by m_tip_block_mutex
fa18586c29d refactor: Add missing GUARDED_BY(m_tip_block_mutex)
fa4c0750331 doc: Clarify waitTipChanged docs
fc642c33ef2 Merge bitcoin/bitcoin#30718: test: switch MiniWallet padding unit from weight to vsize
d7f956a309e Merge bitcoin/bitcoin#30968: init: Remove retry for loop
c33eb2360e2 Merge bitcoin/bitcoin#30043: net: Replace libnatpmp with built-in PCP+NATPMP implementation
f3c74c4a7e1 Merge bitcoin/bitcoin#30989: guix: Drop no longer needed `PATH` modification
5c7cacf649a ci: Remove natpmp build option and libnatpmp dependency
7e7ec984da5 doc: Remove mention of natpmp build options
061c3e32a26 depends: Drop natpmp and associated option from depends
20a18bf6aa3 build: Drop libnatpmp from build system
7b04709862f qt: Changes for built-in PCP+NAT-PMP
52f8ef66c61 net: Replace libnatpmp with built-in NATPMP+PCP implementation in mapport
97c97177cdb net: Add PCP and NATPMP implementation
cb750b4b405 qt6, test: Use `qWarning()` instead of `QWARN()` macro
9123a286e97 qt6: Handle deprecated `QLocale::nativeCountryName`
940edd6ac24 test: refactor: introduce and use `TRUC_CHILD_MAX_VSIZE` constant
c16ae717689 test: switch MiniWallet padding unit from weight to vsize
a647d4400d5 doc: update signet documentation related to build directories
f1daa80521e guix: Drop no longer needed `PATH` modification
d812cf11896 Merge bitcoin/bitcoin#30879: test: re-bucket long-running tests
18d4c43cab4 Merge bitcoin/bitcoin#30921: test: generalize HasReason and use it in FailFmtWithError
d7fcc91416a Merge bitcoin/bitcoin#30974: ci: Inline PACKAGE_MANAGER_INSTALL
29d00a1cee1 Merge bitcoin/bitcoin#30940: depends: Fix build with `MULTIPROCESS=1` in Guix environment
89a8e9b732f Merge bitcoin/bitcoin#30979: contrib: Update asmap link in seeds readme
fafd1a0f648 ci: Inline PACKAGE_MANAGER_INSTALL
36ad9516dbd Merge bitcoin/bitcoin#30981: ci: add timestamps to cirrus jobs
fa7c2838a5f Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fill_mempool()
f951f1fab25 ci: add timestamps to cirrus jobs
f158993fd55 contrib: Update asmap link in seeds readme
d5af7d28f47 Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note about CMake
a7498cc7e26 Fix bug in p2p_headers_presync harness
4cf84b344de depends, doc: No need to specify general requirement
e13da501db9 Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example
513b7136c79 Merge bitcoin/bitcoin#30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fuzz job
286725168ae doc: fix loadtxoutset example
525e9dcba0b Add submitSolution to BlockTemplate interface
47b4875ef05 Add getCoinbaseMerklePath() to Mining interface
63d6ad7c89c Move BlockMerkleBranch back to merkle.{h,cpp}
65f6e7078b1 Merge bitcoin/bitcoin#30510: multiprocess: Add IPC wrapper for Mining interface
da612cea032 Merge bitcoin/bitcoin#30962: validation: Disable CheckForkWarningConditions for background chainstate
e9d60af9889 refactor: Replace init retry for loop with if statement
c1d8870ea41 refactor: Move most of init retry for loop to a function
ccd10fdb97f build: Add missing USDT header dependency to kernel
781c01f5806 init: Check mempool arguments in AppInitParameterInteractions
39219fe145e Merge bitcoin/bitcoin#30946: doc: correct the zmq automatic build info
06e7e836329 doc: correct the zmq automatic build info
a9773b6215e Merge bitcoin/bitcoin#30963: doc: Adjust links in OSS-Fuzz section
fa6c1946d23 doc: Adjust links in OSS-Fuzz section
c0a0c72b4d6 validation: Disable CheckForkWarningConditions for background chainstate
c1832584bfd ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job
393f323bd60 Merge bitcoin/bitcoin#30952: test: Use shell builtins in run_command test case
faf801515f8 test: Add missing sync_mempools() to fill_mempool()
fa48be6f023 test: Refactor fill_mempool to extract send_batch helper
1a332817665 doc: multiprocess documentation improvements
90a5786bba4 Merge bitcoin/bitcoin#30678: wallet: Write best block to disk before backup
d043950ba24 multiprocess: Add serialization code for BlockValidationState
33c2eee285e multiprocess: Add IPC wrapper for Mining interface
06882f84017 multiprocess: Add serialization code for vector<char>
095286f790a multiprocess: Add serialization code for CTransaction
69dfeb18761 multiprocess: update common-types.h to use C++20 concepts
206c6e78eec build: Make bitcoin_ipc_test depend on bitcoin_ipc
070e6a32d5f depends: Update libmultiprocess library for cmake headers target
dabc74e86c3 Merge bitcoin/bitcoin#30409: Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block
7bd3ee62f6d test: Use shell builtins in run_command test case
f5a2000579b test: re-bucket long-running tests
06b4c339e89 depends: Fix reproducibility when building with `MULTIPROCESS=1`
04e4d52420a test: add test for specifying custom pidfile via `-pid`
b832ffe0446 refactor: introduce default pid file name constant in tests
d8e3afc3352 depends: Fix build with `MULTIPROCESS=1` in Guix environment
f20fe33e94c test: Add basic balance coverage to wallet_assumeutxo.py
d72df63d169 net: Use GetLocalAddresses in Discover
e02030432b7 net: Add netif utility
754e4254388 crypto: Add missing WriteBE16 function
33adc7521cc Merge bitcoin/bitcoin#30765: refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors
0894748316c Merge bitcoin/bitcoin#30918: fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work
f57a6754ed6 Merge bitcoin/bitcoin#30826: fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target
48c20dbd86c Merge bitcoin/bitcoin#30794: interpreter: use int32_t instead of int type for risczero compile
4148e60909e Merge bitcoin/bitcoin#30679: fix: handle invalid `-rpcbind` port earlier
a8a2628b7a9 Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups
0d81b3ddedc Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
c985a34b9c3 Merge bitcoin/bitcoin#26990: cli: Improve error message on multiwallet cli-side commands
037b101e808 test: Add coverage for best block locator write in wallet_backup
31c0df03890 wallet: migration, write best locator before unloading wallet
7e3dbe4180c wallet: Write best block to disk before backup
79f20fa1b1e Merge bitcoin/bitcoin#30561: refactor: move `SignSignature` helpers to test utils
284bd17309a add check that chainwork doesn't exceed minimum work
9aa5d1c3fcd add clarification in comment
197aa249551 Merge bitcoin/bitcoin#30856: build: drop obj/ subdirectory for generated build.h
7025942687f build: drop superfluous `HAVE_BUILD_INFO` define
0dd662510c5 build: drop obj/ subdir for generated build.h, rename to bitcoin-build-info.h
84cd6478c42 Merge bitcoin/bitcoin#30927: Follow-up after AutoFile position caching: remove unused code
caac06f784c streams: reorder/document functions
67a3d590768 streams: remove unused code
2db926f49c8 Merge bitcoin/bitcoin#30889: log: Use ConstevalFormatString
fee4cba4847 gui: Fix proxy details display in Options Dialog
9ba56884f62 Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config more flexible
6c3c619b35c test: generalize HasReason and use it in FailFmtWithError
ab0b5706b25 Merge bitcoin/bitcoin#30875: doc: fixed inconsistencies in documentation between autotools to cmake change
fd08fded63a Merge bitcoin/bitcoin#30639: ci: Use clang-19 in msan tasks
5be34bacf6d qt: Fix linking when configured with `-DENABLE_WALLET=OFF`
a9964c04447 doc: Updating docs from autotools to cmake
fae44c83da9 test: Remove 0.16.3 test from wallet_backwards_compatibility.py
69409bc6e55 Merge bitcoin/bitcoin#30908: doc: remove Eclipser fuzzing documentation
6b97882ab53 Merge bitcoin/bitcoin#30915: ci: Use `ninja` to build in macOS native CI job
e6994efe08b fix: increase rpcbind check robustness
d38e3aed89e fix: handle invalid rpcbind port earlier
83b67f2e6d5 refactor: move host/port checking
73c243965ab test: add tests for invalid rpcbind ports
54227e681a4 rpc, cli: improve error message on multiwallet mode
735436df8ce Remove outdated Eclipser fuzzing documentation
ccccb67851b ci: Use clang-19 in msan tasks
facbcd4cef8 log: Use ConstevalFormatString
d01b85bfecb ci: Use `ninja` to build in macOS native CI job
6fc46927971 Merge bitcoin/bitcoin#29624: doc: update NeedsRedownload() and nStatus comment
2a0949f0977 Merge bitcoin/bitcoin#30888: build: optimize .h generation in GenerateHeaderFrom{Raw,Json}.cmake
bdbc90f29ac Merge bitcoin/bitcoin#30902: Remove Autotools packages from CI (and depends doc)
a95e742b692 Merge bitcoin/bitcoin#30913: ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0)
225718eda89 Merge bitcoin/bitcoin#30438: guix: (explicitly) build Linux GCC with `--enable-cet`
fab932b4211 ci: Remove incorrectly hardcoded HOST in mac_native task
af9f9878934 doc: update NeedsRedownload() comment
fa8f35d7865 ci: Use macos-14 GHA image
7942951e3fc Remove unused g_best_block
e3a560ca68d rpc: use waitTipChanged for longpoll
460687a09c2 Remove unused CRPCSignals
dca923150e3 Replace RPCNotifyBlockChange with waitTipChanged()
2a40ee11219 rpc: check for negative timeout arg in waitfor*
de7c855b3af rpc: recommend -rpcclienttimeout=0 for waitfor*
77ec072925a rpc: fix waitfornewblock description
285fe9fb51c rpc: add test for waitforblock and waitfornewblock
b94b27cf05c Add waitTipChanged to Mining interface
7eccdaf1608 node: Track last block that received a blockTip notification
ebb8215f236 Rename getTipHash() to getTip() and return BlockRef
89a8f74bbbb refactor: rename BlockKey to BlockRef
9f1aa88d4d9 Merge bitcoin/bitcoin#30884: streams: cache file position within AutoFile
06329eb1348 Merge bitcoin/bitcoin#29436: net: call `Select` with reachable networks in `ThreadOpenConnections`
e983ed41d9f Merge bitcoin/bitcoin#30410: rpc, rest: Improve block rpc error handling, check header before attempting to read block data.
fce9e065c16 Merge bitcoin/bitcoin#28358: Drop -dbcache limit
8d000b85dd4 Merge bitcoin/bitcoin#30868: refactor: add clang-tidy `modernize-use-starts-ends-with` check
3f66642820b Merge bitcoin/bitcoin#30440: Have createNewBlock() return a BlockTemplate interface
2bf721e76a5 Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p
c38e9993de7 Merge bitcoin/bitcoin#30286: cluster mempool: optimized candidate search
fa99e4521b6 ci: Allow CCACHE_DIR bind mount
37679b856ce Merge bitcoin/bitcoin#30899: qt: Translations update
fc7b507e9a5 tidy: add clang-tidy `modernize-use-starts-ends-with` check
7a8a6a06676 doc: Fix comment in `contrib/devtools/check-deps.sh` script
712d105e093 depends, doc: Do not install Autotools packages
b786449e663 ci: Do not install Autotools packages
a240e150e83 streams: remove AutoFile::Get() entirely
ae052957614 qt: Translations update
6a1aa510e31 rpc: check block index before reading block / undo data
6cbf2e5f819 rpc: Improve gettxoutproof error when only header is available.
69fc867ea19 test: add coverage to getblock and getblockstats
5290cbd5850 rpc: Improve getblock / getblockstats error when only header is available.
e5b537bbdfb rest: improve error when only header of a block is available.
e624a9bef16 streams: cache file position within AutoFile
89bf11b8072 guix: build Linux GCC with --enable-cet
a93c171faa7 Drop unneeded nullptr check from CreateNewBlock()
dd87b6dff35 Have createNewBlock return BlockTemplate interface
fae9b60c4ff test: Use LogPrintStr to test m_log_sourcelocations
33381ea530a scripted-diff: Modernize nLocalServices to m_local_services
2a581144f28 build: Minimize I/O operations in GenerateHeaderFromJson.cmake
aa003d1568b build: Minimize I/O operations in GenerateHeaderFromRaw.cmake
9ad2fe7e69e clusterlin: only start/use search when enough iterations left
bd044356edb clusterlin: improve heuristic to decide split transaction (optimization)
71f26293988 clusterlin: include topological pot subsets automatically (optimization)
e20fda77a2d clusterlin: reduce computation of unnecessary pot sets (optimization)
6060a948caf clusterlin bench: add example hard cluster benchmarks
2965fbf203f clusterlin: track upper bound potential set for work items (optimization)
9e43e4ce109 clusterlin: use feerate-sorted depgraph in SearchCandidateFinder
b80e6dfe780 clusterlin: add reordering support for DepGraph
85a285a3061 clusterlin: separate initial search entries per component (optimization)
e4faea9ca79 clusterlin bench: have low/high iter benchmarks instead of per-iter
fa39b1ca638 doc: move-only logging warning
fa252da0b9c ci: Remove hardcoded CCACHE_DIR in cirrus
fa146904e19 ci: Bump default CCACHE_MAXSIZE to 500M
aaaa7cf8bad cirrus: Drop CCACHE_NOHASHDIR
fa7ca182a9b ci: Print inner env
84663291275 chain: simplify `deleteRwSettings` code and improve it's doc
f8d91f49c70 chain: dont check for null settings value in `overwriteRwSetting`
df601993f2d chain: ensure `updateRwSetting` doesn't update to a null settings
5e190cd11f6 Replace CScript _hex_v_u8 appends with _hex
cac846c2fbf Allow CScript's operator<< to accept spans, not just vectors
c78d8ff4cb8 prevector: avoid GCC bogus warnings in insert method
e4e3b44e9cc net: call `Select` with reachable networks in `ThreadOpenConnections`
829becd990b addrman: change `Select` to support multiple networks
f698636ec86 net: add `All()` in `ReachableNets`
a97f43d63a6 fuzz: Add harness for p2p headers sync
c8e2eeeffb4 chain: uniformly use `SettingsAction` enum in settings methods
f482d0e366a fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target
1e9e735670f chain: move new settings safely in `overwriteRwSetting`
1c409004c80 test: remove wallet context from `write_wallet_settings_concurrently`
58499b00d0a refactor: move `SignSignature` helpers to test utils
cd0edf26c07 tracing: cast block_connected duration to nanoseconds
cfd03de965a Add Testnet4 launch shortcut for Windows
77b2923f871 Add Signet launch shortcut for Windows
bc52cda1f3c fix use int32_t instead of int type for risczero compile with (-march=rv32i, -mabi=ilp32)
a0eaa4749fe Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
a3f6f5acd89 build: Automatically define FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION for fuzz builds
0c02d4b2bdb net_processing: Make MAX_HEADERS_RESULTS a PeerManager option
51f7668d31e addrman: change nid_type from int to int64_t
051ba3290e3 addrman, refactor: introduce user-defined type for internal nId
bdad0243be8 rpc, net: getrawaddrman "mapped_as" follow-ups
fa1b139d17d Bump python minimum supported version to 3.10
ec585f11c38 Reserve space for transaction inputs in CreateTransactionInternal
c76aaaf9003 Reserve space for transaction outputs in CreateTransactionInternal
bb3b980dfd9 validation: drop maximum -dbcache
REVERT: e70e527ef21 kernel: Add pure kernel bitcoin-chainstate
REVERT: ed9a8a54d3c kernel: Add block index utility functions to C header
REVERT: 6338dd45b55 kernel: Add function to read block undo data from disk to C header
REVERT: a2ac0c1e7c9 kernel: Add functions to read block from disk to C header
REVERT: 170060c3372 kernel: Add function for copying  block data to C header
REVERT: 0f8c00bba07 kernel: Add functions for the block validation state to C header
REVERT: 41dba7d2603 kernel: Add validation interface to C header
REVERT: 877cf01f22c kernel: Add interrupt function to C header
REVERT: f77c2b90422 kernel: Add import blocks function to C header
REVERT: 254e17dbeab kernel: Add chainstate load options for in-memory dbs in C header
REVERT: 8baa06d318f kernel: Add options for reindexing in C header
REVERT: 0243ed8a200 kernel: Add block validation to C header
REVERT: 36fbab87e9e Kernel: Add chainstate loading to kernel C header
REVERT: b249e93f295 kernel: Add chainstate manager object to C header
REVERT: 2546745a393 kernel: Add notifications context option to C header
REVERT: 2578746e87f kerenl: Add chain params context option to C header
REVERT: 21107de0ca7 kernel: Add kernel library context object
REVERT: 83cc65c4911 kernel: Add logging to kernel library C header
REVERT: 2f47169f91e kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: 1047757ea3b4b78b51d7338ea44e2123851143fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants