build: drop obj/ subdirectory for generated build.h #30856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
My Guix build: |
Sounds reasonable and simple enough (if I didn't miss anything), added a commit for that in this PR. |
|
Could you rebase this, now that guix builds are reproducible again. |
79a5e32 to
253a691
Compare
Sure, done. |
|
Guix Build d4baa1d2e9ee7abeb60d115dd52c6bc7d02e8116fe4b94c0f040371321e37b80 guix-build-253a691441dd/output/aarch64-linux-gnu/SHA256SUMS.part
7c38410b9468799b74371ba195f34121a4789e917dcf611f2ccc4b81f8a63eee guix-build-253a691441dd/output/aarch64-linux-gnu/bitcoin-253a691441dd-aarch64-linux-gnu-debug.tar.gz
4a6ec8df80822e5938b1a55f2e08a945b12a9d4f8b2f1bad05ea8be90a3b6173 guix-build-253a691441dd/output/aarch64-linux-gnu/bitcoin-253a691441dd-aarch64-linux-gnu.tar.gz
48de6fea5e2d35be40534dedfc51e30e759366b5b6cb6b14e053dbb5cce1c183 guix-build-253a691441dd/output/arm-linux-gnueabihf/SHA256SUMS.part
698a07e7d4cc5b98e64fec240735c7982ccd64abd30ef39eb09f3e1bf10627e7 guix-build-253a691441dd/output/arm-linux-gnueabihf/bitcoin-253a691441dd-arm-linux-gnueabihf-debug.tar.gz
1d33f5c6dab8dea66801ef49c33217bd538fd76d7a1a97cd6609530b94f71805 guix-build-253a691441dd/output/arm-linux-gnueabihf/bitcoin-253a691441dd-arm-linux-gnueabihf.tar.gz
91e2daf2c6fd4c1a97b51e33ee8699a747c16dad2ad27dc3a1e5de0ca6385dbc guix-build-253a691441dd/output/arm64-apple-darwin/SHA256SUMS.part
b2c439dec7f332d8d46b6473e3015095084297cc871f91eb368889c999a930b5 guix-build-253a691441dd/output/arm64-apple-darwin/bitcoin-253a691441dd-arm64-apple-darwin-unsigned.tar.gz
aa85020faab673502192ccf3ab0dfb972df786961317d608c66092729baed133 guix-build-253a691441dd/output/arm64-apple-darwin/bitcoin-253a691441dd-arm64-apple-darwin-unsigned.zip
3a3fce1fd98d6670006daf414ac6bb5ea73336f7846d076606b1c0f0601b09a9 guix-build-253a691441dd/output/arm64-apple-darwin/bitcoin-253a691441dd-arm64-apple-darwin.tar.gz
943a992518ab2b54e93316e89c5ac65e7250004756ac9b37277af5d267e157a8 guix-build-253a691441dd/output/dist-archive/bitcoin-253a691441dd.tar.gz
94088a64cc9d06bea8dd591cbf140f9e4ef7727532254c5b5e0614d5178780f4 guix-build-253a691441dd/output/powerpc64-linux-gnu/SHA256SUMS.part
a7f2db2812ec521162c9e06a8206d76f65ec8fd6be6c11a2d6bf53b863e93577 guix-build-253a691441dd/output/powerpc64-linux-gnu/bitcoin-253a691441dd-powerpc64-linux-gnu-debug.tar.gz
9081f9d3bbdea50045253fddd390aa657c505c74eb6654458cba245a6ef13870 guix-build-253a691441dd/output/powerpc64-linux-gnu/bitcoin-253a691441dd-powerpc64-linux-gnu.tar.gz
efd4c7418f08418adb975790f52222c700ab59851555a3e8e0f59579d2aebebe guix-build-253a691441dd/output/riscv64-linux-gnu/SHA256SUMS.part
e385f0716031f7e6681a93add935cf29345d15909ee3993b7725cc89b260dcb4 guix-build-253a691441dd/output/riscv64-linux-gnu/bitcoin-253a691441dd-riscv64-linux-gnu-debug.tar.gz
4c6aec6956291cc28ec5d46627cfb02456ab223ba7a3b4528956b41f4868509d guix-build-253a691441dd/output/riscv64-linux-gnu/bitcoin-253a691441dd-riscv64-linux-gnu.tar.gz
aa4e835f3356675741c76634d71142bbf08cf082476c23bbb2b32fb039ec8181 guix-build-253a691441dd/output/x86_64-apple-darwin/SHA256SUMS.part
12c1a3964f2ba89ba9f19c8e3ec9b70eacbb7d2e76d3cfc13a12afc4f1dd29c9 guix-build-253a691441dd/output/x86_64-apple-darwin/bitcoin-253a691441dd-x86_64-apple-darwin-unsigned.tar.gz
0832fdf8af0c9512d2ed0aa51cfe967c48bafb39f98ab370f53837ffbdf908cc guix-build-253a691441dd/output/x86_64-apple-darwin/bitcoin-253a691441dd-x86_64-apple-darwin-unsigned.zip
8e80b5391bd2271a7791e43ca3869e964d35fa57ad4acdf07e81774c0bc30836 guix-build-253a691441dd/output/x86_64-apple-darwin/bitcoin-253a691441dd-x86_64-apple-darwin.tar.gz
e5c9a4e491818cd9b87f94c061eb381101a603c1136ac100fda940e000db94a6 guix-build-253a691441dd/output/x86_64-linux-gnu/SHA256SUMS.part
75b6c5dcf8993e264e2c5269521bf1334573ee3d6cf02aaabd9e6d062f9aecf9 guix-build-253a691441dd/output/x86_64-linux-gnu/bitcoin-253a691441dd-x86_64-linux-gnu-debug.tar.gz
a7169d35d96420260c9e2c2156c66f2130cfbdf649febad01627602306c55b74 guix-build-253a691441dd/output/x86_64-linux-gnu/bitcoin-253a691441dd-x86_64-linux-gnu.tar.gz
eefafa6cfbc56e44530634978ea114626693fe8a6b31e14f192b7e45173ff1fe guix-build-253a691441dd/output/x86_64-w64-mingw32/SHA256SUMS.part
279eb3acd6ccb3aa1362d07a37dd2fdeb877fac5d673620a405fa887806d8e2c guix-build-253a691441dd/output/x86_64-w64-mingw32/bitcoin-253a691441dd-win64-debug.zip
1524efbd8e36b3b06ecfbdd5e0889b5c06c25c82ef782671725fc8068dd7eb1a guix-build-253a691441dd/output/x86_64-w64-mingw32/bitcoin-253a691441dd-win64-setup-unsigned.exe
037a06e7ef58c70681b6415584fd61f67cc266bc25db89a5935f1a937bbf86db guix-build-253a691441dd/output/x86_64-w64-mingw32/bitcoin-253a691441dd-win64-unsigned.tar.gz
05f61faaf023e70a420a6c6bf9fd5b0fb7e123b725e7df076e6593f5d9a6fa33 guix-build-253a691441dd/output/x86_64-w64-mingw32/bitcoin-253a691441dd-win64.zip |
|
My Guix build: |
hebasto
approved these changes
Sep 12, 2024
Closed
|
Could rebase once more please to refresh the CI? |
253a691 to
807a429
Compare
Yes, done. |
hebasto
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
re-ACK 807a429, rebased only since my recent review.
My Guix build:
aarch64
f6a91156bc9ac2ec9367d75a433d903db4fe5c4ff0c5680289882f1ca58b9759 guix-build-807a429a33cd/output/aarch64-linux-gnu/SHA256SUMS.part
2704a2fbc76888fb9073631513ea1fc2203edb344814dbe5db02fd51c6d9949d guix-build-807a429a33cd/output/aarch64-linux-gnu/bitcoin-807a429a33cd-aarch64-linux-gnu-debug.tar.gz
a5cd59cb03c5df4eb20b614ead7f64e1e3843924b70f5f33023e78d0a3625f1a guix-build-807a429a33cd/output/aarch64-linux-gnu/bitcoin-807a429a33cd-aarch64-linux-gnu.tar.gz
d6b3372d5c9105cd27b31fb60fca5290c988f1ba6ff05f25f4b0f93b6202e451 guix-build-807a429a33cd/output/arm-linux-gnueabihf/SHA256SUMS.part
b466d2d031ab5d96d984a9be9839cc50d4c146b71d0f551e088d5132b73ee218 guix-build-807a429a33cd/output/arm-linux-gnueabihf/bitcoin-807a429a33cd-arm-linux-gnueabihf-debug.tar.gz
43b47b6cb243aab6c54c7d6234ab7db83b381a3006874294cce106494f1ed8a9 guix-build-807a429a33cd/output/arm-linux-gnueabihf/bitcoin-807a429a33cd-arm-linux-gnueabihf.tar.gz
c05ccde98443c4ec9e6e792fd5fdfac63f46a8d518eb6937516c988d124995f3 guix-build-807a429a33cd/output/arm64-apple-darwin/SHA256SUMS.part
1170f7ceec52a6a6b942e98d7a21e001a0941c2ce57b06068420b09a957f2602 guix-build-807a429a33cd/output/arm64-apple-darwin/bitcoin-807a429a33cd-arm64-apple-darwin-unsigned.tar.gz
e15922f916e5a9937b81eb9d103462650dcc46bada100f4f1a80511166207e56 guix-build-807a429a33cd/output/arm64-apple-darwin/bitcoin-807a429a33cd-arm64-apple-darwin-unsigned.zip
990b9725acf3fa985dd351932d748095d2cc56a8d6d460042ce68ccc2bce913e guix-build-807a429a33cd/output/arm64-apple-darwin/bitcoin-807a429a33cd-arm64-apple-darwin.tar.gz
ace1924445a06db05bc63a79fa162bd02c654069308098e3169273fe84c0401d guix-build-807a429a33cd/output/dist-archive/bitcoin-807a429a33cd.tar.gz
6ecb2cf38ac08c865c30521335b3d9816d9b1dbeaf5c2e2301a9dbc0efb8b83d guix-build-807a429a33cd/output/powerpc64-linux-gnu/SHA256SUMS.part
f6d82f9ba0965dbcf4b69b678b0b16647bb4dfcb44b8f325629cfbcc11a90a9f guix-build-807a429a33cd/output/powerpc64-linux-gnu/bitcoin-807a429a33cd-powerpc64-linux-gnu-debug.tar.gz
4c6ea3b643afa85225881fc038e513e06b0a277f374d2af98a3f5d5413eabdeb guix-build-807a429a33cd/output/powerpc64-linux-gnu/bitcoin-807a429a33cd-powerpc64-linux-gnu.tar.gz
7887479bb46ba88ea44f392117e6a821ce38756e55d128c89bfd1dcb696c64a6 guix-build-807a429a33cd/output/riscv64-linux-gnu/SHA256SUMS.part
8d9a8b0810efe2ad59f5047c3fcf7625d1d3d0dfb9728c417ccf614184baf28d guix-build-807a429a33cd/output/riscv64-linux-gnu/bitcoin-807a429a33cd-riscv64-linux-gnu-debug.tar.gz
ccd28d502db7f25c74a06ab86bb24eb85351d84909b9d6baa025f89c4e907438 guix-build-807a429a33cd/output/riscv64-linux-gnu/bitcoin-807a429a33cd-riscv64-linux-gnu.tar.gz
a060ef9345d88e11b7b19c57984146e4e9ff27949359ed3df509fe8ec74744c3 guix-build-807a429a33cd/output/x86_64-apple-darwin/SHA256SUMS.part
56983cf5081c7afee7d748cf4b11c8ae644d2d53607d32fd9049300c54521217 guix-build-807a429a33cd/output/x86_64-apple-darwin/bitcoin-807a429a33cd-x86_64-apple-darwin-unsigned.tar.gz
28df06a998b94ece5832d3741a218184379e4ad0f244d51d25e2cbd3b4c11276 guix-build-807a429a33cd/output/x86_64-apple-darwin/bitcoin-807a429a33cd-x86_64-apple-darwin-unsigned.zip
5d339c04c55f5f532249c39e50c06a37d1f73cafa2db56ca180373432d002b66 guix-build-807a429a33cd/output/x86_64-apple-darwin/bitcoin-807a429a33cd-x86_64-apple-darwin.tar.gz
7d0e41f4863d3f7a18e50722c722f516653a4dca7963c6440c3b071a8bc5e3fc guix-build-807a429a33cd/output/x86_64-linux-gnu/SHA256SUMS.part
cf991810945fc14610bb309386d61c439bd59c62ba00e39bcc44482070c55415 guix-build-807a429a33cd/output/x86_64-linux-gnu/bitcoin-807a429a33cd-x86_64-linux-gnu-debug.tar.gz
5f13845e9cc99e8dc917e325ae100d5ff66f3d63b8beed53d2e89051a87b6d17 guix-build-807a429a33cd/output/x86_64-linux-gnu/bitcoin-807a429a33cd-x86_64-linux-gnu.tar.gz
cbf166153938607b190c01ade9eb831d1241144c5064251ea7d7df7542779776 guix-build-807a429a33cd/output/x86_64-w64-mingw32/SHA256SUMS.part
99420aefea0c34b7d61745b54f256cb2ad8ab29c9cbbe22b2b543b0829c67ef4 guix-build-807a429a33cd/output/x86_64-w64-mingw32/bitcoin-807a429a33cd-win64-debug.zip
245f5b169385d586fa87e2734a94234296f2c8d5232fb6e9c29e5c41f1bfdc89 guix-build-807a429a33cd/output/x86_64-w64-mingw32/bitcoin-807a429a33cd-win64-setup-unsigned.exe
ebea2cca9f194b7f727859c8f9a56649c204239f43dbd49096d43af8a38cbb42 guix-build-807a429a33cd/output/x86_64-w64-mingw32/bitcoin-807a429a33cd-win64-unsigned.tar.gz
6ad3b82009309c5063e666f2e57c35e4bef14809752117ce092255055c660ce0 guix-build-807a429a33cd/output/x86_64-w64-mingw32/bitcoin-807a429a33cd-win64.zip
hebasto
reviewed
Sep 17, 2024
theuni
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Concept ACK.
Though, obj/ was acting as a bit of a namespace here (IIRC, that was another reason for it to be in a subdir). Especially since this is included with <> as opposed to "", while we're at it, I think we should rename this file. build.h seems generic enough to collide with something else. bitcoin-build.h maybe?
|
Likewise for Err.. I guess that would mean touching a lot of files though :) |
maflcko
approved these changes
Sep 18, 2024
src/clientversion.cpp
Outdated
| #ifdef HAVE_BUILD_INFO | ||
| #include <obj/build.h> | ||
| // The <obj/build.h>, which is generated by the build environment (cmake/script/GenerateBuildInfo.cmake), | ||
| #include <build.h> |
There was a problem hiding this comment.
nit: Now that HAVE_BUILD_INFO is removed, this can be placed under the "normal" includes, no? Also, a more descriptive name could be used, while touching this? Maybe build_info.h or build_git_info.h, as it may only contain the git commit or tag?
There was a problem hiding this comment.
Now that HAVE_BUILD_INFO is removed, this can be placed under the "normal" includes, no?
I left it where it is for now, as I thought it make sense if the comments and the preprocessor commands evaluating BUILD_GIT_TAG are immediately below, but no hard feelings. Happy to move only the include up if that is preferred.
|
Thanks for the reviews! Added a commit renaming the file build.h to bitcoin-build-info.h, to account for both the namespacing suggestions (#30856 (review)) and the request for a more descriptive name (#30856 (comment)). Let me know if another name is preferred (dashes vs. underscores? put "git" into filename or not?) and if a scripted-diff for moving bitcoin-config.h is preferred in this or a follow-up PR. |
maflcko
approved these changes
Sep 19, 2024
…d-info.h Now that this file is not in a subfolder anymore, prefix it with "bitcoin-" to avoid potential collisions. Also add "info" for a more descriptive name.
bitcoin-build-info.h should always be generated before clientversion.cpp is compiled due to the following explicit dependency in src/CMakeLists.txt: add_dependencies(bitcoin_clientversion generate_build_info) Hence there is no need to gate the inclusion of that header with an extra define.
7e43602 to
7025942
Compare
Makes sense yeah, done. |
theuni
approved these changes
Sep 19, 2024
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
|
|
Guix build (x86_64): f65f7839cb8ce4b194ab55a698b9840dd335d790a5499d3303cf79885405bedb guix-build-7025942687fd/output/aarch64-linux-gnu/SHA256SUMS.part
7953c080586b3500c73edd93731b8b9bcfd79ac4f5fe7953d51dc54643899255 guix-build-7025942687fd/output/aarch64-linux-gnu/bitcoin-7025942687fd-aarch64-linux-gnu-debug.tar.gz
c82339ac1813727df996deda765087d430080a62d5fff7e16f46727be703a68c guix-build-7025942687fd/output/aarch64-linux-gnu/bitcoin-7025942687fd-aarch64-linux-gnu.tar.gz
ffe2b02e6187d2c04e3d9c22359448cdacab537794ebd19d5f3b0ccd907a915a guix-build-7025942687fd/output/arm-linux-gnueabihf/SHA256SUMS.part
a5765dcee8bf4f0901ecc3821408f2f9429720c1fa62566c2789e332c151681b guix-build-7025942687fd/output/arm-linux-gnueabihf/bitcoin-7025942687fd-arm-linux-gnueabihf-debug.tar.gz
cdc734e3c0f1801688bdedb006da10a2e6632fadbdd59e604df274d07e887c27 guix-build-7025942687fd/output/arm-linux-gnueabihf/bitcoin-7025942687fd-arm-linux-gnueabihf.tar.gz
ba20403a2d49bde31172d25145a3f1f8d0fb6eb45721412ab591780e2fede9b4 guix-build-7025942687fd/output/arm64-apple-darwin/SHA256SUMS.part
4bb2e1643b9f496ed6a46af49c4c9246c3efe91b48ac7da290bd902abd893e8d guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin-unsigned.tar.gz
8670598c71bfbe86770231d11dece2d5d43544f120be4287c0ff5017712b09b3 guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin-unsigned.zip
40c783b17d607bae4e5e0f6e71a0dfb1e55e4ff4951ebdce981bdd8e72edad4b guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin.tar.gz
e45543e43185d2b35a69ff6177340077e34064b922ac1f6f50bc152f4eaed806 guix-build-7025942687fd/output/dist-archive/bitcoin-7025942687fd.tar.gz
02793c2b05814c10fd900e659d753a383333c89e0c8a4d57daec556454fff3a3 guix-build-7025942687fd/output/powerpc64-linux-gnu/SHA256SUMS.part
7d4434d13c53c27d1e2f34767f373a026181e4a72f4613d3bdba8d3f4812961a guix-build-7025942687fd/output/powerpc64-linux-gnu/bitcoin-7025942687fd-powerpc64-linux-gnu-debug.tar.gz
14bc762c2429377069b49146fde9712747faf4fcfcad06a94e8c27abd32c0b4e guix-build-7025942687fd/output/powerpc64-linux-gnu/bitcoin-7025942687fd-powerpc64-linux-gnu.tar.gz
d8534437521bdfbdd01c36ccf8f5da28fc9677098aaadbeaaffcc5aec992150e guix-build-7025942687fd/output/riscv64-linux-gnu/SHA256SUMS.part
243ad7cabe6cf8778970a83a977a3fce81c9086385e06097bfbefc2d32fab92e guix-build-7025942687fd/output/riscv64-linux-gnu/bitcoin-7025942687fd-riscv64-linux-gnu-debug.tar.gz
0d01e1d1cd9b3bb03ed9c4b08e2dae8d46eeac29c1105d13825e95917f144883 guix-build-7025942687fd/output/riscv64-linux-gnu/bitcoin-7025942687fd-riscv64-linux-gnu.tar.gz
eef35730f0a47bb3697ead2fe513e9f765c37fc06f4b2f2c053865ec6965c6a9 guix-build-7025942687fd/output/x86_64-apple-darwin/SHA256SUMS.part
d88c34c6a87d008a45ebb8c48c0c42c96a8e228d72826fbdef80f4a2676fd67f guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin-unsigned.tar.gz
d6298d8dd0a25e343b09d4cce735c7493aba7bf80ad95b863dafdfce53235749 guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin-unsigned.zip
803923f3e20ac251b15c5c9ccf18e6eeb8c7deb828b45bee7c9dcaf15363222f guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin.tar.gz
b50f1e5000d5301d481b9d0bceb74aa358500444489c87d9e8a81e0ba8886e79 guix-build-7025942687fd/output/x86_64-linux-gnu/SHA256SUMS.part
d95587edae05630ad2a126b25c3b1fe41b5fe2cc0b8de5474e0c6815f498f8ba guix-build-7025942687fd/output/x86_64-linux-gnu/bitcoin-7025942687fd-x86_64-linux-gnu-debug.tar.gz
bad3de3cff3467c6de928cda6dd554a5f4b974f7ae449713c0f5199450af909e guix-build-7025942687fd/output/x86_64-linux-gnu/bitcoin-7025942687fd-x86_64-linux-gnu.tar.gz
dfcf9ad8bf6615d00ee393cd1ae9b2123c8e86701d75a3e9bfdb73b094693c93 guix-build-7025942687fd/output/x86_64-w64-mingw32/SHA256SUMS.part
969ff114447e139dcf4f6c3c4d20ac8b1f1e41affc5f6797bae1de8f59da0e63 guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-debug.zip
523c24b241dc6e55603266344bd0aad47aed526543a22ed37760aba29bb5759b guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-setup-unsigned.exe
8ce71925b01017e2aa85e36559635a739bc5306d9d28ff81a77d1f79b8a6ba4d guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-unsigned.tar.gz
61739b2e4af4dcf58af182088325c45ed1aa9103dcec8dfe29252d25f2203049 guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64.zip |
theStack
added a commit
to theStack/bitcoin
that referenced
this pull request
Sep 20, 2024
Follow-up for PR bitcoin#30856, commit 0dd6625. -BEGIN VERIFY SCRIPT- sed -i "s|config/bitcoin-config.h|bitcoin-config.h|g" $(git grep -l config/bitcoin-config.h) -END VERIFY SCRIPT-
hebasto
reviewed
Sep 20, 2024
There was a problem hiding this comment.
My Guix build:
aarch64
f65f7839cb8ce4b194ab55a698b9840dd335d790a5499d3303cf79885405bedb guix-build-7025942687fd/output/aarch64-linux-gnu/SHA256SUMS.part
7953c080586b3500c73edd93731b8b9bcfd79ac4f5fe7953d51dc54643899255 guix-build-7025942687fd/output/aarch64-linux-gnu/bitcoin-7025942687fd-aarch64-linux-gnu-debug.tar.gz
c82339ac1813727df996deda765087d430080a62d5fff7e16f46727be703a68c guix-build-7025942687fd/output/aarch64-linux-gnu/bitcoin-7025942687fd-aarch64-linux-gnu.tar.gz
ffe2b02e6187d2c04e3d9c22359448cdacab537794ebd19d5f3b0ccd907a915a guix-build-7025942687fd/output/arm-linux-gnueabihf/SHA256SUMS.part
a5765dcee8bf4f0901ecc3821408f2f9429720c1fa62566c2789e332c151681b guix-build-7025942687fd/output/arm-linux-gnueabihf/bitcoin-7025942687fd-arm-linux-gnueabihf-debug.tar.gz
cdc734e3c0f1801688bdedb006da10a2e6632fadbdd59e604df274d07e887c27 guix-build-7025942687fd/output/arm-linux-gnueabihf/bitcoin-7025942687fd-arm-linux-gnueabihf.tar.gz
ba20403a2d49bde31172d25145a3f1f8d0fb6eb45721412ab591780e2fede9b4 guix-build-7025942687fd/output/arm64-apple-darwin/SHA256SUMS.part
4bb2e1643b9f496ed6a46af49c4c9246c3efe91b48ac7da290bd902abd893e8d guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin-unsigned.tar.gz
8670598c71bfbe86770231d11dece2d5d43544f120be4287c0ff5017712b09b3 guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin-unsigned.zip
40c783b17d607bae4e5e0f6e71a0dfb1e55e4ff4951ebdce981bdd8e72edad4b guix-build-7025942687fd/output/arm64-apple-darwin/bitcoin-7025942687fd-arm64-apple-darwin.tar.gz
e45543e43185d2b35a69ff6177340077e34064b922ac1f6f50bc152f4eaed806 guix-build-7025942687fd/output/dist-archive/bitcoin-7025942687fd.tar.gz
02793c2b05814c10fd900e659d753a383333c89e0c8a4d57daec556454fff3a3 guix-build-7025942687fd/output/powerpc64-linux-gnu/SHA256SUMS.part
7d4434d13c53c27d1e2f34767f373a026181e4a72f4613d3bdba8d3f4812961a guix-build-7025942687fd/output/powerpc64-linux-gnu/bitcoin-7025942687fd-powerpc64-linux-gnu-debug.tar.gz
14bc762c2429377069b49146fde9712747faf4fcfcad06a94e8c27abd32c0b4e guix-build-7025942687fd/output/powerpc64-linux-gnu/bitcoin-7025942687fd-powerpc64-linux-gnu.tar.gz
d8534437521bdfbdd01c36ccf8f5da28fc9677098aaadbeaaffcc5aec992150e guix-build-7025942687fd/output/riscv64-linux-gnu/SHA256SUMS.part
243ad7cabe6cf8778970a83a977a3fce81c9086385e06097bfbefc2d32fab92e guix-build-7025942687fd/output/riscv64-linux-gnu/bitcoin-7025942687fd-riscv64-linux-gnu-debug.tar.gz
0d01e1d1cd9b3bb03ed9c4b08e2dae8d46eeac29c1105d13825e95917f144883 guix-build-7025942687fd/output/riscv64-linux-gnu/bitcoin-7025942687fd-riscv64-linux-gnu.tar.gz
eef35730f0a47bb3697ead2fe513e9f765c37fc06f4b2f2c053865ec6965c6a9 guix-build-7025942687fd/output/x86_64-apple-darwin/SHA256SUMS.part
d88c34c6a87d008a45ebb8c48c0c42c96a8e228d72826fbdef80f4a2676fd67f guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin-unsigned.tar.gz
d6298d8dd0a25e343b09d4cce735c7493aba7bf80ad95b863dafdfce53235749 guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin-unsigned.zip
803923f3e20ac251b15c5c9ccf18e6eeb8c7deb828b45bee7c9dcaf15363222f guix-build-7025942687fd/output/x86_64-apple-darwin/bitcoin-7025942687fd-x86_64-apple-darwin.tar.gz
b50f1e5000d5301d481b9d0bceb74aa358500444489c87d9e8a81e0ba8886e79 guix-build-7025942687fd/output/x86_64-linux-gnu/SHA256SUMS.part
d95587edae05630ad2a126b25c3b1fe41b5fe2cc0b8de5474e0c6815f498f8ba guix-build-7025942687fd/output/x86_64-linux-gnu/bitcoin-7025942687fd-x86_64-linux-gnu-debug.tar.gz
bad3de3cff3467c6de928cda6dd554a5f4b974f7ae449713c0f5199450af909e guix-build-7025942687fd/output/x86_64-linux-gnu/bitcoin-7025942687fd-x86_64-linux-gnu.tar.gz
dfcf9ad8bf6615d00ee393cd1ae9b2123c8e86701d75a3e9bfdb73b094693c93 guix-build-7025942687fd/output/x86_64-w64-mingw32/SHA256SUMS.part
969ff114447e139dcf4f6c3c4d20ac8b1f1e41affc5f6797bae1de8f59da0e63 guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-debug.zip
523c24b241dc6e55603266344bd0aad47aed526543a22ed37760aba29bb5759b guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-setup-unsigned.exe
8ce71925b01017e2aa85e36559635a739bc5306d9d28ff81a77d1f79b8a6ba4d guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64-unsigned.tar.gz
61739b2e4af4dcf58af182088325c45ed1aa9103dcec8dfe29252d25f2203049 guix-build-7025942687fd/output/x86_64-w64-mingw32/bitcoin-7025942687fd-win64.zip
hebasto
reviewed
Sep 20, 2024
theStack
added a commit
to theStack/bitcoin
that referenced
this pull request
Sep 23, 2024
…tcoin-build-config.h Follow-up for PR bitcoin#30856, commit 0dd6625. -BEGIN VERIFY SCRIPT- sed -i "s|config/bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l config/bitcoin-config\.h) sed -i "s|bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l "bitcoin-config\.h" ./src ./test ./cmake) git mv ./cmake/bitcoin-config.h.in ./cmake/bitcoin-build-config.h.in -END VERIFY SCRIPT-
theStack
added a commit
to theStack/bitcoin
that referenced
this pull request
Oct 10, 2024
…tcoin-build-config.h Follow-up for PR bitcoin#30856, commit 0dd6625. -BEGIN VERIFY SCRIPT- sed -i "s|config/bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l config/bitcoin-config\.h) sed -i "s|bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l "bitcoin-config\.h" ./src ./test ./cmake) git mv ./cmake/bitcoin-config.h.in ./cmake/bitcoin-build-config.h.in -END VERIFY SCRIPT-
fanquake
added a commit
that referenced
this pull request
Oct 10, 2024
…onfig.h 882f736 doc: lint: correct outdated comment (s/Makefile.am/CMakeLists.txt/) (Sebastian Falbesoner) 1786be7 scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h (Sebastian Falbesoner) Pull request description: This PR is a follow-up to #30856, as suggested in comment #30856 (comment). With the scripted diff, review should be fairly trivial, but it could still be seen as controversial due to the large number of files (78 in total) being touched. ACKs for top commit: fanquake: ACK 882f736 Tree-SHA512: 2e6cae4590f660e741edf84df456168b8b1f3861d381cfebf6647bb0a303c26bf7b969a837e0058e59bf852d220990dd8f5f400d8975fd0fab106d0507a70c9b
m3dwards
pushed a commit
to m3dwards/bitcoin
that referenced
this pull request
Oct 15, 2024
…tcoin-build-config.h Follow-up for PR bitcoin#30856, commit 0dd6625. -BEGIN VERIFY SCRIPT- sed -i "s|config/bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l config/bitcoin-config\.h) sed -i "s|bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l "bitcoin-config\.h" ./src ./test ./cmake) git mv ./cmake/bitcoin-config.h.in ./cmake/bitcoin-build-config.h.in -END VERIFY SCRIPT-
TheCharlatan
added a commit
to TheCharlatan/rust-bitcoinkernel
that referenced
this pull request
Nov 2, 2024
…47757ea3b 1047757ea3b kernel: Add pure kernel bitcoin-chainstate c568fdf75fd kernel: Add block index utility functions to C header 0f1da1dcba5 kernel: Add function to read block undo data from disk to C header 45af559c9f6 kernel: Add functions to read block from disk to C header 2a7f8a8240c kernel: Add function for copying block data to C header b19f5336c03 kernel: Add functions for the block validation state to C header 9c0ffa913f4 kernel: Add validation interface to C header a93318c6152 kernel: Add interrupt function to C header 51053f33720 kernel: Add import blocks function to C header 6b0ada2af42 kernel: Add chainstate load options for in-memory dbs in C header 34427bfa9c7 kernel: Add options for reindexing in C header ca57311c969 kernel: Add block validation to C header 44156d84838 Kernel: Add chainstate loading to kernel C header 2cee46cdcc1 kernel: Add chainstate manager object to C header 7102c7ae45e kernel: Add notifications context option to C header ed628a2a3c4 kerenl: Add chain params context option to C header 27643297ff7 kernel: Add kernel library context object 2ba22cf3f90 kernel: Add logging to kernel library C header 873874c03e9 kernel: Introduce initial kernel C header API d94adc7270b Merge bitcoin/bitcoin#29702: fees: Remove CLIENT_VERSION serialization 7290bc61c00 Merge bitcoin/bitcoin#31078: build: Fix kernel static lib component install 68f29b24907 Merge bitcoin/bitcoin#31141: doc: Make list of targets in depends README consistent e9b95665eea Merge bitcoin/bitcoin#31046: init: Some small chainstate load improvements b8c821cc1ea Merge bitcoin/bitcoin#30724: test: add test for specifying custom pidfile via `-pid` a0c9595810c doc: Make list of targets in depends README consistent fa1c5cc9df1 fees: Log non-fatal errors as [warning], instead of info-level ffe4261cb06 Merge bitcoin/bitcoin#30935: ci: Approximate MAKEJOBS in image build phase 28ce159bc32 Merge bitcoin/bitcoin#30183: rpc: net: follow-ups for #30062 684873931b3 Merge bitcoin/bitcoin#26334: Add Signet and testnet4 launch shortcuts for Windows 9b0e2598089 Merge bitcoin/bitcoin#31121: guix: Enable CET for `glibc` package d9f8dc64534 Merge bitcoin/bitcoin#31097: validation: Improve input script check error reporting a16917fb598 rpc, net: improve `mapped_as` doc for getrawaddrman/getpeerinfo 563c4d29268 Merge bitcoin/bitcoin#31105: Update libmultiprocess library 0e9f20625a1 Merge bitcoin/bitcoin#31063: lint: commit-script-check.sh: echo to stderr e8f72aefd20 Merge bitcoin/bitcoin#29877: tracing: explicitly cast block_connected duration to nanoseconds 86e2a6b749c [test] A non-standard transaction which is also consensus-invalid should return the consensus error 4d3da08d1b9 guix: Enable CET for `glibc` package a38603456e9 Merge bitcoin/bitcoin#31100: doc: remove dependency install instructions from win docs 90b405516f7 Update libmultiprocess library 479715e9db0 Merge bitcoin/bitcoin#30996: doc: update signet documentation related to build directories 99e041f86fd Merge bitcoin/bitcoin#31099: doc: drop macOS LLVM install instructions 21e2f06a1cc Merge bitcoin/bitcoin#31067: test: Print CompletedProcess object on error 184f12c1542 doc: remove dependency install instructions from win docs dea9fb9a8b8 Merge bitcoin/bitcoin#30093: optimization: reserve memory allocation for transaction inputs/outputs 79aa8280b2e doc: drop LLVM install instructions 2123c94448e Merge bitcoin/bitcoin#30527: Bump python minimum supported version to 3.10 538ccaed004 Merge bitcoin/bitcoin#31048: build: Bump minimum supported macOS to 13.0 f859ff8a4e9 [validation] Improve script check error reporting ddddbac9c10 fees: Pin required version to 149900 fa5126adcb1 fees: Pin "version that wrote" to 0 0ca1d1bf69c Merge bitcoin/bitcoin#31092: doc: fuzz: remove Honggfuzz NetDriver instructions d823ba6e20b doc: fuzz: remove Honggfuzz NetDriver instructions 15563d3388e Merge bitcoin/bitcoin#30859: doc: cmake: prepend "build" to functional/test_runner.py 2ac5ba24bf0 Merge bitcoin/bitcoin#31083: doc: add doxygen for m_args in tests a0e089a71dc build: Bump minimum supported macOS to 13.0 1fe1b3ba8e9 doc: doxygen comment for m_args usage in tests 82e16e69832 cmake: Refactor install kernel dependencies 42e62779873 build: Add static libraries to Kernel install component e64b2f1a16e doc: cmake: prepend and explain "build/" where needed 48cf3da6360 Merge bitcoin/bitcoin#30970: build: Add missing USDT header dependency to kernel d8b835cf18c Merge bitcoin/bitcoin#31070: contrib: fix typos in check-deps.sh da8824ba301 Fix typos in check-deps.sh fa43c4f93ca test: Print CompletedProcess object on error 489e5aa3a29 Merge bitcoin/bitcoin#30857: cluster mempool: extend DepGraph functionality 9f45062b9b0 Merge bitcoin/bitcoin#30937: build: scripted-diff: drop config/ subdir for bitcoin-config.h 882f736d0a6 doc: lint: correct outdated comment (s/Makefile.am/CMakeLists.txt/) 1786be7b4a5 scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h 0c2c3bb3f5c Merge bitcoin/bitcoin#30955: Mining interface: getCoinbaseMerklePath() and submitSolution() 9909a34d794 Merge bitcoin/bitcoin#30992: doc: update IBD requirements in doc/README.md fac6cfe5ac0 lint: commit-script-check.sh: echo to stderr 5fb94550638 Merge bitcoin/bitcoin#31058: refactor: include the proper header rather than forward-declaring RemovalReasonToString e569eb8d917 Merge bitcoin/bitcoin#30885: scripted-diff: Modernize nLocalServices naming 31cc5006c3d init: Return fatal failure on snapshot validation failure 8f1246e8338 init: Improve chainstate init db error messages 5837e3463fe Merge bitcoin/bitcoin#30967: refactor: Replace g_genesis_wait_cv with m_tip_block_cv ca2e4ba352c refactor: include the proper header rather than forward-declaring RemovalReasonToString a9f6a57b691 Merge bitcoin/bitcoin#30920: test: Remove 0.16.3 test from wallet_backwards_compatibility.py fa71bedf860 ci: Approximate MAKEJOBS in image build phase 03696bb1bd5 Merge bitcoin/bitcoin#31045: ci: Add missing -DWERROR=ON to test-each-commit 56093565bbe Merge bitcoin/bitcoin#31018: test: Treat exclude list warning as failure in CI bb47b5a6576 Merge bitcoin/bitcoin#31038: test: Fix copy-paste in wallet/test/db_tests ostream operator 3fecf36c7b3 Merge bitcoin/bitcoin#31056: ci: Double ctest timeout 3c4a9419dbe Merge bitcoin/bitcoin#31013: depends: For mingw cross compile use -gcc-posix to prevent library conflict 5d5cc021ce3 Merge bitcoin/bitcoin#31051: test: remove unused code from `script_tests` caf44e500eb Merge bitcoin/bitcoin#31008: depends: Print ready-to-use `--toolchain` option for CMake invocation fa5ebc99207 ci: Double ctest timeout 0b3ec8c59b2 clusterlin: remove Cluster type 1c24c625105 clusterlin: merge two DepGraph fuzz tests into simulation test 0606e66fdbb clusterlin: add DepGraph::RemoveTransactions and support for holes in DepGraph 75b5d42419e clusterlin: make DepGraph::AddDependency support multiple dependencies at once abf50649d13 clusterlin: simplify DepGraphFormatter::Ser eaab55ffc81 clusterlin: rework DepGraphFormatter::Unser 5901cf7100a clusterlin: abstract out DepGraph::GetReduced{Parents,Children} e0287bc4b2d test: remove unused code from script_tests 62e45167221 Merge bitcoin/bitcoin#31026: ci: set a ctest test timeout of 1200 (20 minutes) cd093049dda init: Remove incorrect comment about shutdown condition 635e9f85d76 init: Remove misleading log line when user chooses not to retry fa1cffacae6 ci: Install missing nproc in macos task faf7a2bccc7 ci: Add missing -DWERROR=ON to test-each-commit 56aad83307e ci: set a ctest timeout of 1200 (20 minutes) 1b707146717 Merge bitcoin-core/gui#840: qt6: Handle different signatures of `QANEF::nativeEventFilter` 720ce880a35 init: Improve comment describing chainstate load retry behaviour baea842ff18 init: Remove unneeded argument for mempool_opts checks ec58dfe8f74 Merge bitcoin/bitcoin#31010: cmake: Avoid hardcoding Qt's major version in Find module / variable names 5fe6878b5f7 Merge bitcoin-core/gui#836: Fix display issues for IPv6 proxy setup in Options Dialog (UI only, no functionality impact) f50557f5d36 test: Fix copy-paste in db_tests ostream operator 5ea335a97f8 Merge bitcoin/bitcoin#30793: rpc: add getorphantxs 76e2e8aabd8 Merge bitcoin/bitcoin#31035: doc: Archive 28.0 release notes f019fcec412 doc: Archive 28.0 release notes 80761afced1 qt6: Handle different signatures of `QANEF::nativeEventFilter` 51c698161b5 Merge bitcoin-core/gui#837: qt6: Fix linking when configured with `-DENABLE_WALLET=OFF` 4be785b3e33 Merge bitcoin-core/gui#839: qt6, test: Handle deprecated code f117f3f7473 Merge bitcoin-core/gui#838: qt6: Handle deprecated `QLocale::nativeCountryName` 5625840c11d qt6, test: Handle deprecated `QVERIFY_EXCEPTION_THROWN` 772928a13c2 Merge bitcoin/bitcoin#30982: docs: Add instructions on how to self-sign bitcoin-core binaries for macOS 27709f51ee0 docs: Add instructions on how to self-sign bitcoin-core binaries for macOS cfb59da4b3b Merge bitcoin/bitcoin#30980: fuzz: fix bug in p2p_headers_presync harness dda2613239b Merge bitcoin/bitcoin#30929: log: Enforce trailing newline e0ae9c14c4e Merge bitcoin/bitcoin#31011: refactor: move util/pcp and util/netif to common/ 98c1536852d test: add getorphantxs tests 93f48fceb7d test: add tx_in_orphanage() 34a9c10e8cd rpc: add getorphantxs f511ff3654d refactor: move verbosity parsing to rpc/util 36a6d4b0078 doc: update IBD requirements in doc/README.md fa6d14eacb2 test: Treat exclude list warning as failure in CI 6a370435526 Merge bitcoin/bitcoin#31007: doc: add testnet4 section header for config file 70910eb2ecb Merge bitcoin/bitcoin#31016: test: add missing sync to feature_fee_estimation.py 532491faf1a net: add GetOrphanTransactions() to PeerManager 91b65adff2a refactor: add OrphanTxBase for external use a1576edab35 test: add missing sync to feature_fee_estimation.py ae56b3230b2 depends: For mingw cross compile use -gcc-posix to prevent library conflict fd38711217c ci: make CI job fail when check-deps.sh script fails d51edecddcb common: move pcp.cpp and netif.cpp files from util to common library since they depend on netaddress.cpp 61cdb1c9d83 doc: add testnet4 section header for config file deacf3c7cd6 cmake: Avoid hardcoding Qt's major version in Find module 605926da0ab depends: Print ready-to-use `--toolchain` option for CMake invocation fa2b7d8d6b3 Remove redundant unterminated-logprintf tidy check bbbb2e43ee9 log: Enforce trailing newline, Remove redundant m_started_new_line fa22e5c430a refactor: Remove dead code that assumed tip == nullptr fa2e4439652 refactor: Replace g_genesis_wait_cv with m_tip_block_cv fa7f52af1a4 refactor: Use wait_for predicate to check for interrupt 5ca28ef28bc refactor: Split up NodeContext shutdown_signal and shutdown_request fad8e7fba7b bugfix: Mark m_tip_block_cv as guarded by m_tip_block_mutex fa18586c29d refactor: Add missing GUARDED_BY(m_tip_block_mutex) fa4c0750331 doc: Clarify waitTipChanged docs fc642c33ef2 Merge bitcoin/bitcoin#30718: test: switch MiniWallet padding unit from weight to vsize d7f956a309e Merge bitcoin/bitcoin#30968: init: Remove retry for loop c33eb2360e2 Merge bitcoin/bitcoin#30043: net: Replace libnatpmp with built-in PCP+NATPMP implementation f3c74c4a7e1 Merge bitcoin/bitcoin#30989: guix: Drop no longer needed `PATH` modification 5c7cacf649a ci: Remove natpmp build option and libnatpmp dependency 7e7ec984da5 doc: Remove mention of natpmp build options 061c3e32a26 depends: Drop natpmp and associated option from depends 20a18bf6aa3 build: Drop libnatpmp from build system 7b04709862f qt: Changes for built-in PCP+NAT-PMP 52f8ef66c61 net: Replace libnatpmp with built-in NATPMP+PCP implementation in mapport 97c97177cdb net: Add PCP and NATPMP implementation cb750b4b405 qt6, test: Use `qWarning()` instead of `QWARN()` macro 9123a286e97 qt6: Handle deprecated `QLocale::nativeCountryName` 940edd6ac24 test: refactor: introduce and use `TRUC_CHILD_MAX_VSIZE` constant c16ae717689 test: switch MiniWallet padding unit from weight to vsize a647d4400d5 doc: update signet documentation related to build directories f1daa80521e guix: Drop no longer needed `PATH` modification d812cf11896 Merge bitcoin/bitcoin#30879: test: re-bucket long-running tests 18d4c43cab4 Merge bitcoin/bitcoin#30921: test: generalize HasReason and use it in FailFmtWithError d7fcc91416a Merge bitcoin/bitcoin#30974: ci: Inline PACKAGE_MANAGER_INSTALL 29d00a1cee1 Merge bitcoin/bitcoin#30940: depends: Fix build with `MULTIPROCESS=1` in Guix environment 89a8e9b732f Merge bitcoin/bitcoin#30979: contrib: Update asmap link in seeds readme fafd1a0f648 ci: Inline PACKAGE_MANAGER_INSTALL 36ad9516dbd Merge bitcoin/bitcoin#30981: ci: add timestamps to cirrus jobs fa7c2838a5f Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fill_mempool() f951f1fab25 ci: add timestamps to cirrus jobs f158993fd55 contrib: Update asmap link in seeds readme d5af7d28f47 Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note about CMake a7498cc7e26 Fix bug in p2p_headers_presync harness 4cf84b344de depends, doc: No need to specify general requirement e13da501db9 Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example 513b7136c79 Merge bitcoin/bitcoin#30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fuzz job 286725168ae doc: fix loadtxoutset example 525e9dcba0b Add submitSolution to BlockTemplate interface 47b4875ef05 Add getCoinbaseMerklePath() to Mining interface 63d6ad7c89c Move BlockMerkleBranch back to merkle.{h,cpp} 65f6e7078b1 Merge bitcoin/bitcoin#30510: multiprocess: Add IPC wrapper for Mining interface da612cea032 Merge bitcoin/bitcoin#30962: validation: Disable CheckForkWarningConditions for background chainstate e9d60af9889 refactor: Replace init retry for loop with if statement c1d8870ea41 refactor: Move most of init retry for loop to a function ccd10fdb97f build: Add missing USDT header dependency to kernel 781c01f5806 init: Check mempool arguments in AppInitParameterInteractions 39219fe145e Merge bitcoin/bitcoin#30946: doc: correct the zmq automatic build info 06e7e836329 doc: correct the zmq automatic build info a9773b6215e Merge bitcoin/bitcoin#30963: doc: Adjust links in OSS-Fuzz section fa6c1946d23 doc: Adjust links in OSS-Fuzz section c0a0c72b4d6 validation: Disable CheckForkWarningConditions for background chainstate c1832584bfd ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job 393f323bd60 Merge bitcoin/bitcoin#30952: test: Use shell builtins in run_command test case faf801515f8 test: Add missing sync_mempools() to fill_mempool() fa48be6f023 test: Refactor fill_mempool to extract send_batch helper 1a332817665 doc: multiprocess documentation improvements 90a5786bba4 Merge bitcoin/bitcoin#30678: wallet: Write best block to disk before backup d043950ba24 multiprocess: Add serialization code for BlockValidationState 33c2eee285e multiprocess: Add IPC wrapper for Mining interface 06882f84017 multiprocess: Add serialization code for vector<char> 095286f790a multiprocess: Add serialization code for CTransaction 69dfeb18761 multiprocess: update common-types.h to use C++20 concepts 206c6e78eec build: Make bitcoin_ipc_test depend on bitcoin_ipc 070e6a32d5f depends: Update libmultiprocess library for cmake headers target dabc74e86c3 Merge bitcoin/bitcoin#30409: Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block 7bd3ee62f6d test: Use shell builtins in run_command test case f5a2000579b test: re-bucket long-running tests 06b4c339e89 depends: Fix reproducibility when building with `MULTIPROCESS=1` 04e4d52420a test: add test for specifying custom pidfile via `-pid` b832ffe0446 refactor: introduce default pid file name constant in tests d8e3afc3352 depends: Fix build with `MULTIPROCESS=1` in Guix environment f20fe33e94c test: Add basic balance coverage to wallet_assumeutxo.py d72df63d169 net: Use GetLocalAddresses in Discover e02030432b7 net: Add netif utility 754e4254388 crypto: Add missing WriteBE16 function 33adc7521cc Merge bitcoin/bitcoin#30765: refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors 0894748316c Merge bitcoin/bitcoin#30918: fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work f57a6754ed6 Merge bitcoin/bitcoin#30826: fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target 48c20dbd86c Merge bitcoin/bitcoin#30794: interpreter: use int32_t instead of int type for risczero compile 4148e60909e Merge bitcoin/bitcoin#30679: fix: handle invalid `-rpcbind` port earlier a8a2628b7a9 Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups 0d81b3ddedc Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t c985a34b9c3 Merge bitcoin/bitcoin#26990: cli: Improve error message on multiwallet cli-side commands 037b101e808 test: Add coverage for best block locator write in wallet_backup 31c0df03890 wallet: migration, write best locator before unloading wallet 7e3dbe4180c wallet: Write best block to disk before backup 79f20fa1b1e Merge bitcoin/bitcoin#30561: refactor: move `SignSignature` helpers to test utils 284bd17309a add check that chainwork doesn't exceed minimum work 9aa5d1c3fcd add clarification in comment 197aa249551 Merge bitcoin/bitcoin#30856: build: drop obj/ subdirectory for generated build.h 7025942687f build: drop superfluous `HAVE_BUILD_INFO` define 0dd662510c5 build: drop obj/ subdir for generated build.h, rename to bitcoin-build-info.h 84cd6478c42 Merge bitcoin/bitcoin#30927: Follow-up after AutoFile position caching: remove unused code caac06f784c streams: reorder/document functions 67a3d590768 streams: remove unused code 2db926f49c8 Merge bitcoin/bitcoin#30889: log: Use ConstevalFormatString fee4cba4847 gui: Fix proxy details display in Options Dialog 9ba56884f62 Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config more flexible 6c3c619b35c test: generalize HasReason and use it in FailFmtWithError ab0b5706b25 Merge bitcoin/bitcoin#30875: doc: fixed inconsistencies in documentation between autotools to cmake change fd08fded63a Merge bitcoin/bitcoin#30639: ci: Use clang-19 in msan tasks 5be34bacf6d qt: Fix linking when configured with `-DENABLE_WALLET=OFF` a9964c04447 doc: Updating docs from autotools to cmake fae44c83da9 test: Remove 0.16.3 test from wallet_backwards_compatibility.py 69409bc6e55 Merge bitcoin/bitcoin#30908: doc: remove Eclipser fuzzing documentation 6b97882ab53 Merge bitcoin/bitcoin#30915: ci: Use `ninja` to build in macOS native CI job e6994efe08b fix: increase rpcbind check robustness d38e3aed89e fix: handle invalid rpcbind port earlier 83b67f2e6d5 refactor: move host/port checking 73c243965ab test: add tests for invalid rpcbind ports 54227e681a4 rpc, cli: improve error message on multiwallet mode 735436df8ce Remove outdated Eclipser fuzzing documentation ccccb67851b ci: Use clang-19 in msan tasks facbcd4cef8 log: Use ConstevalFormatString d01b85bfecb ci: Use `ninja` to build in macOS native CI job 6fc46927971 Merge bitcoin/bitcoin#29624: doc: update NeedsRedownload() and nStatus comment 2a0949f0977 Merge bitcoin/bitcoin#30888: build: optimize .h generation in GenerateHeaderFrom{Raw,Json}.cmake bdbc90f29ac Merge bitcoin/bitcoin#30902: Remove Autotools packages from CI (and depends doc) a95e742b692 Merge bitcoin/bitcoin#30913: ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0) 225718eda89 Merge bitcoin/bitcoin#30438: guix: (explicitly) build Linux GCC with `--enable-cet` fab932b4211 ci: Remove incorrectly hardcoded HOST in mac_native task af9f9878934 doc: update NeedsRedownload() comment fa8f35d7865 ci: Use macos-14 GHA image 7942951e3fc Remove unused g_best_block e3a560ca68d rpc: use waitTipChanged for longpoll 460687a09c2 Remove unused CRPCSignals dca923150e3 Replace RPCNotifyBlockChange with waitTipChanged() 2a40ee11219 rpc: check for negative timeout arg in waitfor* de7c855b3af rpc: recommend -rpcclienttimeout=0 for waitfor* 77ec072925a rpc: fix waitfornewblock description 285fe9fb51c rpc: add test for waitforblock and waitfornewblock b94b27cf05c Add waitTipChanged to Mining interface 7eccdaf1608 node: Track last block that received a blockTip notification ebb8215f236 Rename getTipHash() to getTip() and return BlockRef 89a8f74bbbb refactor: rename BlockKey to BlockRef 9f1aa88d4d9 Merge bitcoin/bitcoin#30884: streams: cache file position within AutoFile 06329eb1348 Merge bitcoin/bitcoin#29436: net: call `Select` with reachable networks in `ThreadOpenConnections` e983ed41d9f Merge bitcoin/bitcoin#30410: rpc, rest: Improve block rpc error handling, check header before attempting to read block data. fce9e065c16 Merge bitcoin/bitcoin#28358: Drop -dbcache limit 8d000b85dd4 Merge bitcoin/bitcoin#30868: refactor: add clang-tidy `modernize-use-starts-ends-with` check 3f66642820b Merge bitcoin/bitcoin#30440: Have createNewBlock() return a BlockTemplate interface 2bf721e76a5 Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p c38e9993de7 Merge bitcoin/bitcoin#30286: cluster mempool: optimized candidate search fa99e4521b6 ci: Allow CCACHE_DIR bind mount 37679b856ce Merge bitcoin/bitcoin#30899: qt: Translations update fc7b507e9a5 tidy: add clang-tidy `modernize-use-starts-ends-with` check 7a8a6a06676 doc: Fix comment in `contrib/devtools/check-deps.sh` script 712d105e093 depends, doc: Do not install Autotools packages b786449e663 ci: Do not install Autotools packages a240e150e83 streams: remove AutoFile::Get() entirely ae052957614 qt: Translations update 6a1aa510e31 rpc: check block index before reading block / undo data 6cbf2e5f819 rpc: Improve gettxoutproof error when only header is available. 69fc867ea19 test: add coverage to getblock and getblockstats 5290cbd5850 rpc: Improve getblock / getblockstats error when only header is available. e5b537bbdfb rest: improve error when only header of a block is available. e624a9bef16 streams: cache file position within AutoFile 89bf11b8072 guix: build Linux GCC with --enable-cet a93c171faa7 Drop unneeded nullptr check from CreateNewBlock() dd87b6dff35 Have createNewBlock return BlockTemplate interface fae9b60c4ff test: Use LogPrintStr to test m_log_sourcelocations 33381ea530a scripted-diff: Modernize nLocalServices to m_local_services 2a581144f28 build: Minimize I/O operations in GenerateHeaderFromJson.cmake aa003d1568b build: Minimize I/O operations in GenerateHeaderFromRaw.cmake 9ad2fe7e69e clusterlin: only start/use search when enough iterations left bd044356edb clusterlin: improve heuristic to decide split transaction (optimization) 71f26293988 clusterlin: include topological pot subsets automatically (optimization) e20fda77a2d clusterlin: reduce computation of unnecessary pot sets (optimization) 6060a948caf clusterlin bench: add example hard cluster benchmarks 2965fbf203f clusterlin: track upper bound potential set for work items (optimization) 9e43e4ce109 clusterlin: use feerate-sorted depgraph in SearchCandidateFinder b80e6dfe780 clusterlin: add reordering support for DepGraph 85a285a3061 clusterlin: separate initial search entries per component (optimization) e4faea9ca79 clusterlin bench: have low/high iter benchmarks instead of per-iter fa39b1ca638 doc: move-only logging warning fa252da0b9c ci: Remove hardcoded CCACHE_DIR in cirrus fa146904e19 ci: Bump default CCACHE_MAXSIZE to 500M aaaa7cf8bad cirrus: Drop CCACHE_NOHASHDIR fa7ca182a9b ci: Print inner env 84663291275 chain: simplify `deleteRwSettings` code and improve it's doc f8d91f49c70 chain: dont check for null settings value in `overwriteRwSetting` df601993f2d chain: ensure `updateRwSetting` doesn't update to a null settings 5e190cd11f6 Replace CScript _hex_v_u8 appends with _hex cac846c2fbf Allow CScript's operator<< to accept spans, not just vectors c78d8ff4cb8 prevector: avoid GCC bogus warnings in insert method e4e3b44e9cc net: call `Select` with reachable networks in `ThreadOpenConnections` 829becd990b addrman: change `Select` to support multiple networks f698636ec86 net: add `All()` in `ReachableNets` a97f43d63a6 fuzz: Add harness for p2p headers sync c8e2eeeffb4 chain: uniformly use `SettingsAction` enum in settings methods f482d0e366a fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target 1e9e735670f chain: move new settings safely in `overwriteRwSetting` 1c409004c80 test: remove wallet context from `write_wallet_settings_concurrently` 58499b00d0a refactor: move `SignSignature` helpers to test utils cd0edf26c07 tracing: cast block_connected duration to nanoseconds cfd03de965a Add Testnet4 launch shortcut for Windows 77b2923f871 Add Signet launch shortcut for Windows bc52cda1f3c fix use int32_t instead of int type for risczero compile with (-march=rv32i, -mabi=ilp32) a0eaa4749fe Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check a3f6f5acd89 build: Automatically define FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION for fuzz builds 0c02d4b2bdb net_processing: Make MAX_HEADERS_RESULTS a PeerManager option 51f7668d31e addrman: change nid_type from int to int64_t 051ba3290e3 addrman, refactor: introduce user-defined type for internal nId bdad0243be8 rpc, net: getrawaddrman "mapped_as" follow-ups fa1b139d17d Bump python minimum supported version to 3.10 ec585f11c38 Reserve space for transaction inputs in CreateTransactionInternal c76aaaf9003 Reserve space for transaction outputs in CreateTransactionInternal bb3b980dfd9 validation: drop maximum -dbcache REVERT: e70e527ef21 kernel: Add pure kernel bitcoin-chainstate REVERT: ed9a8a54d3c kernel: Add block index utility functions to C header REVERT: 6338dd45b55 kernel: Add function to read block undo data from disk to C header REVERT: a2ac0c1e7c9 kernel: Add functions to read block from disk to C header REVERT: 170060c3372 kernel: Add function for copying block data to C header REVERT: 0f8c00bba07 kernel: Add functions for the block validation state to C header REVERT: 41dba7d2603 kernel: Add validation interface to C header REVERT: 877cf01f22c kernel: Add interrupt function to C header REVERT: f77c2b90422 kernel: Add import blocks function to C header REVERT: 254e17dbeab kernel: Add chainstate load options for in-memory dbs in C header REVERT: 8baa06d318f kernel: Add options for reindexing in C header REVERT: 0243ed8a200 kernel: Add block validation to C header REVERT: 36fbab87e9e Kernel: Add chainstate loading to kernel C header REVERT: b249e93f295 kernel: Add chainstate manager object to C header REVERT: 2546745a393 kernel: Add notifications context option to C header REVERT: 2578746e87f kerenl: Add chain params context option to C header REVERT: 21107de0ca7 kernel: Add kernel library context object REVERT: 83cc65c4911 kernel: Add logging to kernel library C header REVERT: 2f47169f91e kernel: Introduce initial kernel C header API git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 1047757ea3b4b78b51d7338ea44e2123851143fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated by the TODO, the obj subdirectory is not needed anymore now for the generated build.h header, since autotools are gone and we don't have in-source builds anymore (see #30454, #30664). In the second commit the superflous
HAVE_BUILD_INFOmacro is dropped, as suggested in #30856 (review).