depends: bump miniupnpc to 2.2.8 #30301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK. From the CI output, this has to wait for #30283 to be merged first, right? |
|
cc @laanwj |
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
|
Marked as draft until #30283 is merged. |
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
|
Can rebase / undraft this now. |
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes.
cbcf508 to
545bb6c
Compare
|
Guix builds (aarch64): |
|
tACK 545bb6c I looked at the diff between the packaged 2.2.7 and 2.2.8. There's a Tested on macOS 14.5 with When I turn UPnP support off in the router: When I turn it on: My OPNSense router identifies this as So I'm not sure what Guix hashes: |
This was referenced Aug 1, 2024
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
I think #31130 is going to go in for |
yes... i dont think i've seen any PR that (uncontroversially) popular in my time here 😄 |
|
Woohoo! I like that much better than a bump :) |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 6, 2025
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes. Github-Pull: bitcoin#30301 Rebased-From: 545bb6c
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jul 17, 2025
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes. Github-Pull: bitcoin#30301 Rebased-From: 545bb6c
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jul 24, 2025
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes. Github-Pull: bitcoin#30301 Rebased-From: 545bb6c
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jul 29, 2025
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes. Github-Pull: bitcoin#30301 Rebased-From: 545bb6c
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Aug 5, 2025
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes. Github-Pull: bitcoin#30301 Rebased-From: 545bb6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops two of our patches that have been merged upstream and adjusts the other to deal with recent changes.
Follow-up from #30283. I can't vouch for the upstream changes here.