Skip to content

Conversation

justinvforvendetta
Copy link
Contributor

@justinvforvendetta justinvforvendetta commented Aug 7, 2024

This reverts commit 21b8a14.

started fresh fanquake

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 7, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30301 (depends: bump miniupnpc to 2.2.8 by theuni)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c2cc63 - please don't @ mention anyone in your pull request descriptions, otherwise they are likely to just get spammed with notifications.

@fanquake fanquake merged commit 3530db3 into bitcoin:master Aug 12, 2024
16 checks passed
@bitcoin bitcoin locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants